From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: build-style/python3-pep517: use a generic glob for wheels
Date: Thu, 25 May 2023 16:56:16 +0200 [thread overview]
Message-ID: <20230525145616.VkCuk2GcphnVXHeOwJuhDrmztlw46XIs0_bdMYt7yUE@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44071@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 449 bytes --]
New comment by tornaria on void-packages repository
https://github.com/void-linux/void-packages/pull/44071#issuecomment-1563055680
Comment:
LGTM, thanks! I made a minor suggestion so the style in `do_install()` matches the style in `do_check()`. I prefer the other way (setting default values at the top of the function) since that acts as documentation and makes it much more clear what are default values, etc. and it's a style used throughout.
next prev parent reply other threads:[~2023-05-25 14:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-24 23:04 [PR PATCH] " tornaria
2023-05-25 14:06 ` [PR PATCH] [Updated] " ahesford
2023-05-25 14:11 ` ahesford
2023-05-25 14:13 ` icp1994
2023-05-25 14:15 ` [PR PATCH] [Updated] " ahesford
2023-05-25 14:16 ` ahesford
2023-05-25 14:51 ` [PR REVIEW] " tornaria
2023-05-25 14:56 ` tornaria [this message]
2023-05-25 15:25 ` ahesford
2023-05-25 17:43 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525145616.VkCuk2GcphnVXHeOwJuhDrmztlw46XIs0_bdMYt7yUE@z \
--to=tornaria@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).