Github messages for voidlinux
 help / color / mirror / Atom feed
From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: common/build-style/python3-pep517.sh: ignore tests in temp destdir
Date: Thu, 25 May 2023 18:15:22 +0200	[thread overview]
Message-ID: <20230525161522.f4hA30p6AyHZKMCYXHzx16pQz2tfrFDh9umE3p3mduc@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43946@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 539 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/43946#issuecomment-1563172638

Comment:
That's okay, because failing tests will already abort a build and any subsequent attempt probably ought to start from a clean masterdir for proper behavior anyway. Cleaning up at the end of `do_check` after a successful test should be good enough. Leaving the temporary directory around after a failed test also lets users inspect the installation for defects that might have triggered the error.

  parent reply	other threads:[~2023-05-25 16:15 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-19 19:32 [PR PATCH] " icp1994
2023-05-24 22:40 ` tornaria
2023-05-25 14:25 ` [PR PATCH] [Updated] " icp1994
2023-05-25 14:27 ` icp1994
2023-05-25 14:59 ` tornaria
2023-05-25 15:11 ` icp1994
2023-05-25 15:20 ` ahesford
2023-05-25 15:36 ` ahesford
2023-05-25 15:44 ` icp1994
2023-05-25 16:15 ` ahesford [this message]
2023-05-25 19:13 ` [PR PATCH] [Updated] " icp1994
2023-05-25 19:15 ` icp1994
2023-05-25 19:19 ` ahesford
2023-05-31 13:59 ` [PR REVIEW] " ahesford
2023-05-31 14:00 ` ahesford
2023-05-31 21:44 ` tornaria
2023-05-31 21:56 ` tornaria
2023-06-01  7:06 ` [PR REVIEW] " icp1994
2023-06-01 13:44 ` tornaria
2023-06-01 13:57 ` ahesford
2023-06-01 14:01 ` ahesford
2023-06-02 17:16 ` [PR PATCH] [Updated] " icp1994
2023-06-02 17:19 ` [PR REVIEW] " icp1994
2023-06-05  1:42 ` tornaria
2023-06-05  3:58 ` [PR REVIEW] " ahesford
2023-06-05  3:59 ` ahesford
2023-06-05  3:59 ` ahesford
2023-06-05 15:10 ` ahesford
2023-06-05 19:36 ` [PR PATCH] [Updated] " icp1994
2023-06-05 19:42 ` icp1994
2023-06-05 19:44 ` [PR REVIEW] " icp1994
2023-06-05 19:46 ` [PR PATCH] [Updated] " icp1994
2023-06-05 20:27 ` [PR PATCH] [Closed]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230525161522.f4hA30p6AyHZKMCYXHzx16pQz2tfrFDh9umE3p3mduc@z \
    --to=ahesford@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).