From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] common/build-style/python3-pep517.sh: ignore tests in temp destdir
Date: Wed, 31 May 2023 15:59:32 +0200 [thread overview]
Message-ID: <20230531135932.ipX6digSCpNev0NS2US0HPXYzdWiLwFu8y-nsFwmSVw@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43946@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 481 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/43946#discussion_r1211768371
Comment:
I've been thinking about this some more and believe we should be more targeted in the removal:
```suggestion
rm -r "${testdir}"
```
Yes, this will leave `tmp` around if we created it, but I suspect that won't cause any problems, and it might avoid a problem where a package actually ships a `tmp` directory. What do you think?
next prev parent reply other threads:[~2023-05-31 13:59 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 19:32 [PR PATCH] " icp1994
2023-05-24 22:40 ` tornaria
2023-05-25 14:25 ` [PR PATCH] [Updated] " icp1994
2023-05-25 14:27 ` icp1994
2023-05-25 14:59 ` tornaria
2023-05-25 15:11 ` icp1994
2023-05-25 15:20 ` ahesford
2023-05-25 15:36 ` ahesford
2023-05-25 15:44 ` icp1994
2023-05-25 16:15 ` ahesford
2023-05-25 19:13 ` [PR PATCH] [Updated] " icp1994
2023-05-25 19:15 ` icp1994
2023-05-25 19:19 ` ahesford
2023-05-31 13:59 ` ahesford [this message]
2023-05-31 14:00 ` [PR REVIEW] " ahesford
2023-05-31 21:44 ` tornaria
2023-05-31 21:56 ` tornaria
2023-06-01 7:06 ` [PR REVIEW] " icp1994
2023-06-01 13:44 ` tornaria
2023-06-01 13:57 ` ahesford
2023-06-01 14:01 ` ahesford
2023-06-02 17:16 ` [PR PATCH] [Updated] " icp1994
2023-06-02 17:19 ` [PR REVIEW] " icp1994
2023-06-05 1:42 ` tornaria
2023-06-05 3:58 ` [PR REVIEW] " ahesford
2023-06-05 3:59 ` ahesford
2023-06-05 3:59 ` ahesford
2023-06-05 15:10 ` ahesford
2023-06-05 19:36 ` [PR PATCH] [Updated] " icp1994
2023-06-05 19:42 ` icp1994
2023-06-05 19:44 ` [PR REVIEW] " icp1994
2023-06-05 19:46 ` [PR PATCH] [Updated] " icp1994
2023-06-05 20:27 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230531135932.ipX6digSCpNev0NS2US0HPXYzdWiLwFu8y-nsFwmSVw@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).