From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-pybind11: add symlinks to include, cmake, pkg-config dirs
Date: Thu, 25 May 2023 20:30:50 +0200 [thread overview]
Message-ID: <20230525183050.VJHr20KsRaG6wb8DgZHbbbyYV8OwaQJOIr1SLYlDplY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43981@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 711 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/43981#issuecomment-1563333481
Comment:
When you touch packages that are actively maintained, please tag the maintainer, especially if you are proposing structural changes to the package.
I'm on the fence about this change. On the one hand, it emulates the behavior of the `pybind11-global` package that upstream distributes. On the other, it should generally be unnecessary if you properly configure the build environment to look for the CMake and pkg-config files where they are actually installed.
Moving the directories would have been the wrong choice, because that would break the Python package.
next prev parent reply other threads:[~2023-05-25 18:30 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 1:21 [PR PATCH] " chrysos349
2023-05-21 1:26 ` classabbyamp
2023-05-21 1:54 ` chrysos349
2023-05-25 18:30 ` ahesford [this message]
2023-05-26 14:34 ` chrysos349
2023-05-26 15:28 ` ahesford
2023-05-26 16:03 ` chrysos349
2023-05-26 16:03 ` [PR PATCH] [Closed]: " chrysos349
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230525183050.VJHr20KsRaG6wb8DgZHbbbyYV8OwaQJOIr1SLYlDplY@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).