From: chrysos349 <chrysos349@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-pybind11: add symlinks to include, cmake, pkg-config dirs
Date: Fri, 26 May 2023 18:03:21 +0200 [thread overview]
Message-ID: <20230526160321.0RJL02qRxKtPPt3C0mlEwUfbV8Q2kfGFCu-qLKienCs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-43981@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1382 bytes --]
New comment by chrysos349 on void-packages repository
https://github.com/void-linux/void-packages/pull/43981#issuecomment-1564609864
Comment:
> Why are you using `xbps-src` variables like `${XBPS_CROSS_BASE}` and `${py3_sitelib}`?
That's what @classabbyamp suggested above (https://github.com/void-linux/void-packages/pull/43981#issuecomment-1556058510).
`-Dpybind11_DIR=${XBPS_CROSS_BASE}/${py3_sitelib}/pybind11/share/cmake/pybind11` is used in `gnuradio` templates.
> Is there some Void template that is not building properly?
No, there's not. I created a template for `audiotube`. cmake couldn't find `pybind11Config.cmake`. So I modified `python3-pybind11`'s template, and recompiled it. I didn't know I could've defined `-Dpybind11_DIR`.
BTW, it turns out there's already a pr for `audiotube` - #37569. At least I learnt something while building it.
> "I'd rather not do any extra steps" isn't a sufficient reason for moving the complexity into the Void package; if upstream decides to move things around in the future, the symlinks we create could easily be broken without going noticed. The `pybind11-global` package is a bit different because they provide a proper setup script to copy files from a location they know exists into the system paths.
Well then, I'm not gonna complicate things any longer. PR closed. Thanks for your valuable feedback.
next prev parent reply other threads:[~2023-05-26 16:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-21 1:21 [PR PATCH] " chrysos349
2023-05-21 1:26 ` classabbyamp
2023-05-21 1:54 ` chrysos349
2023-05-25 18:30 ` ahesford
2023-05-26 14:34 ` chrysos349
2023-05-26 15:28 ` ahesford
2023-05-26 16:03 ` chrysos349 [this message]
2023-05-26 16:03 ` [PR PATCH] [Closed]: " chrysos349
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230526160321.0RJL02qRxKtPPt3C0mlEwUfbV8Q2kfGFCu-qLKienCs@z \
--to=chrysos349@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).