* [PR PATCH] wireplumber: create /var/lib/wireplumber
@ 2023-05-28 2:27 dkwo
2023-05-28 3:23 ` [PR PATCH] [Merged]: " ahesford
` (13 more replies)
0 siblings, 14 replies; 15+ messages in thread
From: dkwo @ 2023-05-28 2:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 503 bytes --]
There is a new pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages wp
https://github.com/void-linux/void-packages/pull/44122
wireplumber: create /var/lib/wireplumber
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)
This fixes a warning from pipewire complaining that the folder does not exist.
A patch file from https://github.com/void-linux/void-packages/pull/44122.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-wp-44122.patch --]
[-- Type: text/x-diff, Size: 1117 bytes --]
From c4ba297f11838232a828fd9b42a249a9d104de84 Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Sat, 27 May 2023 21:45:39 -0400
Subject: [PATCH] wireplumber: create /var/lib/wireplumber
---
srcpkgs/wireplumber/template | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/wireplumber/template b/srcpkgs/wireplumber/template
index f0ca35159469..80f8f1b7845f 100644
--- a/srcpkgs/wireplumber/template
+++ b/srcpkgs/wireplumber/template
@@ -1,7 +1,7 @@
# Template file for 'wireplumber'
pkgname=wireplumber
version=0.4.14
-revision=2
+revision=3
build_style=meson
build_helper=gir
configure_args="-Dintrospection=enabled -Dsystem-lua=true"
@@ -16,6 +16,7 @@ changelog="https://gitlab.freedesktop.org/pipewire/wireplumber/-/raw/master/NEWS
distfiles="https://gitlab.freedesktop.org/pipewire/wireplumber/-/archive/$version/wireplumber-$version.tar.gz"
checksum=b160424ce7c3eeeccba388726f6a448f53501d25085e5fa1bf6c690c1bcd85ea
provides="pipewire-session-manager-0_1"
+make_dirs="/var/lib/wireplumber 0755 _pipewire _pipewire"
post_install() {
vlicense LICENSE
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: [PR PATCH] [Merged]: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
@ 2023-05-28 3:23 ` ahesford
2023-05-28 11:46 ` Duncaen
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2023-05-28 3:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 363 bytes --]
There's a merged pull request on the void-packages repository
wireplumber: create /var/lib/wireplumber
https://github.com/void-linux/void-packages/pull/44122
Description:
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)
This fixes a warning from pipewire complaining that the folder does not exist.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
2023-05-28 3:23 ` [PR PATCH] [Merged]: " ahesford
@ 2023-05-28 11:46 ` Duncaen
2023-05-28 11:58 ` Duncaen
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Duncaen @ 2023-05-28 11:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 194 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1566108270
Comment:
What is this and where are the warnings coming from?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
2023-05-28 3:23 ` [PR PATCH] [Merged]: " ahesford
2023-05-28 11:46 ` Duncaen
@ 2023-05-28 11:58 ` Duncaen
2023-05-28 14:17 ` dkwo
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Duncaen @ 2023-05-28 11:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 284 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1566108270
Comment:
What is this and where are the warnings coming from?
Edit: Ok its from the unsupported system services I guess, which set `XDG_STATE_HOME`.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (2 preceding siblings ...)
2023-05-28 11:58 ` Duncaen
@ 2023-05-28 14:17 ` dkwo
2023-06-02 20:43 ` Duncaen
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-05-28 14:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 207 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1566154940
Comment:
@Duncaen You're most likely right, I'm using pipewire runit service.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (3 preceding siblings ...)
2023-05-28 14:17 ` dkwo
@ 2023-06-02 20:43 ` Duncaen
2023-06-02 20:46 ` TeusLollo
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Duncaen @ 2023-06-02 20:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 295 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574292937
Comment:
This causes issues when installing on a new system when the `_pipewire` user doesn't exist yet.
https://github.com/void-linux/void-packages/issues/44231
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (4 preceding siblings ...)
2023-06-02 20:43 ` Duncaen
@ 2023-06-02 20:46 ` TeusLollo
2023-06-02 20:54 ` TeusLollo
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: TeusLollo @ 2023-06-02 20:46 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 234 bytes --]
New comment by TeusLollo on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574295094
Comment:
Indeed, that's what I was guessing, but I wasn't going to learn Pipiwire just to confirm.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (5 preceding siblings ...)
2023-06-02 20:46 ` TeusLollo
@ 2023-06-02 20:54 ` TeusLollo
2023-06-02 21:00 ` TeusLollo
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: TeusLollo @ 2023-06-02 20:54 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 676 bytes --]
New comment by TeusLollo on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574295094
Comment:
Indeed, that's what I was guessing, but I wasn't going to learn Pipewire just to confirm.
EDIT:
I don't suppose there's a way to run a conditional check on the `make_dirs` to see if other Pipewire components are present (They will not if wireplumber was pulled as a dependency, which is the case in which the https://github.com/void-linux/void-packages/issues/44231 error will appear)?
It could be otherwise be left as it is, maybe just echoing that, if an user has not Pipewire installed, such an error is not relevant.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (6 preceding siblings ...)
2023-06-02 20:54 ` TeusLollo
@ 2023-06-02 21:00 ` TeusLollo
2023-06-02 21:08 ` dkwo
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: TeusLollo @ 2023-06-02 21:00 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 804 bytes --]
New comment by TeusLollo on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574295094
Comment:
Indeed, that's what I was guessing, but I wasn't going to learn Pipewire just to confirm.
EDIT:
I don't suppose there's a way to run a conditional check on the `make_dirs` to see if other Pipewire components are present (They will not if wireplumber was pulled as a dependency, which is the case in which the https://github.com/void-linux/void-packages/issues/44231 error will appear)?
It could be otherwise be left as it is, maybe just echoing that, if an user has not Pipewire installed, such an error is not relevant.
EDIT:
Nevermind, I didn't see https://github.com/void-linux/void-packages/commit/37c289b2b62d5accb04861b7de53cab3ded68014
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (7 preceding siblings ...)
2023-06-02 21:00 ` TeusLollo
@ 2023-06-02 21:08 ` dkwo
2023-06-02 21:15 ` Duncaen
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-06-02 21:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 391 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574317359
Comment:
> This causes issues when installing on a new system when the `_pipewire` user doesn't exist yet. #44231
wireplumber should only be used with pipewire, as far as i know.
#44231 looks like an issue with Waybar, in which case i think it's irrelevant.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (8 preceding siblings ...)
2023-06-02 21:08 ` dkwo
@ 2023-06-02 21:15 ` Duncaen
2023-06-02 21:24 ` TeusLollo
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: Duncaen @ 2023-06-02 21:15 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
New comment by Duncaen on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574323991
Comment:
Its an issue with depending on accounts from different packages. Even with a dependency on pipewire, the order of installation/script execution can not be depended on and is basically undefined behavior.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (9 preceding siblings ...)
2023-06-02 21:15 ` Duncaen
@ 2023-06-02 21:24 ` TeusLollo
2023-06-02 22:16 ` ahesford
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: TeusLollo @ 2023-06-02 21:24 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 741 bytes --]
New comment by TeusLollo on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574331709
Comment:
As coded here: https://github.com/void-linux/void-packages/blob/master/srcpkgs/Waybar/template in `makedepends`
`$(vopt_if pipewire 'wireplumber-devel pipewire-devel')`
Seems that only `wireplumber-devel` is required to build waybar with `pipewire` support.
Also relevant, in `config_args`:
`-Dwireplumber=$(vopt_if pipewire enabled disabled)`
I guess, theoretically, `waybar` could drop the `wireplumber` package.
However, such dependencies have reasons: https://github.com/void-linux/void-packages/pull/41610#issuecomment-1516716575
Yep, seems the problem lies elsewhere.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (10 preceding siblings ...)
2023-06-02 21:24 ` TeusLollo
@ 2023-06-02 22:16 ` ahesford
2023-06-03 13:47 ` dkwo
2023-06-03 16:52 ` ahesford
13 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2023-06-02 22:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 213 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574376928
Comment:
We can probably revert this because we killed the unofficial services.
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (11 preceding siblings ...)
2023-06-02 22:16 ` ahesford
@ 2023-06-03 13:47 ` dkwo
2023-06-03 16:52 ` ahesford
13 siblings, 0 replies; 15+ messages in thread
From: dkwo @ 2023-06-03 13:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 198 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1574960628
Comment:
I see. How about adding this to the pipewire template then?
^ permalink raw reply [flat|nested] 15+ messages in thread
* Re: wireplumber: create /var/lib/wireplumber
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
` (12 preceding siblings ...)
2023-06-03 13:47 ` dkwo
@ 2023-06-03 16:52 ` ahesford
13 siblings, 0 replies; 15+ messages in thread
From: ahesford @ 2023-06-03 16:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 442 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/44122#issuecomment-1575065864
Comment:
Adding a wireplumber home directory to the pipewire package doesn't make sense. I think our revised example service is immune to this issue (I don't have the wireplumber directory and have no issues), and you can always just create the directory yourself if you really want the old service behavior.
^ permalink raw reply [flat|nested] 15+ messages in thread
end of thread, other threads:[~2023-06-03 16:52 UTC | newest]
Thread overview: 15+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-05-28 2:27 [PR PATCH] wireplumber: create /var/lib/wireplumber dkwo
2023-05-28 3:23 ` [PR PATCH] [Merged]: " ahesford
2023-05-28 11:46 ` Duncaen
2023-05-28 11:58 ` Duncaen
2023-05-28 14:17 ` dkwo
2023-06-02 20:43 ` Duncaen
2023-06-02 20:46 ` TeusLollo
2023-06-02 20:54 ` TeusLollo
2023-06-02 21:00 ` TeusLollo
2023-06-02 21:08 ` dkwo
2023-06-02 21:15 ` Duncaen
2023-06-02 21:24 ` TeusLollo
2023-06-02 22:16 ` ahesford
2023-06-03 13:47 ` dkwo
2023-06-03 16:52 ` ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).