[PR PATCH] common/xbps-src/shutils/update_check.sh: fix url for gitlab

[PR PATCH] common/xbps-src/shutils/update_check.sh: fix url for gitlab

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 562 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages fix-gitlab-update-check
https://github.com/void-linux/void-packages/pull/43944

common/xbps-src/shutils/update_check.sh: fix url for gitlab
#### Testing the changes
- I tested the changes in this PR: **YES**

All update checks which only rely on Gitlab are currently broken. The `code.videolan.org` counterpart also works with this change.

A patch file from https://github.com/void-linux/void-packages/pull/43944.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-fix-gitlab-update-check-43944.patch --]
[-- Type: text/x-diff, Size: 2234 bytes --]

From d8dc3e603554894a425f31f461a000203eeae0da Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Fri, 19 May 2023 19:23:08 +0530
Subject: [PATCH 1/3] common/xbps-src/shutils/update_check.sh: fix url for
 gitlab

---
 common/xbps-src/shutils/update_check.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index cd3bb369bdb3..e656cf06fbcc 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -136,7 +136,7 @@ update_check() {
                     */-/*) pkgurlname="$(printf %s "$url" | sed -e 's%/-/.*%%g; s%/$%%')";;
                     *) pkgurlname="$(printf %s "$url" | cut -d / -f 1-5)";;
                 esac
-                url="$pkgurlname/tags"
+                url="$pkgurlname/-/tags"
                 rx='/archive/[^/]+/\Q'"$pkgname"'\E-v?\K[\d.]+(?=\.tar\.gz")';;
             *bitbucket.org*)
                 pkgurlname="$(printf %s "$url" | cut -d/ -f4,5)"

From 6a6e0e9a639d8c3e88c9927521902dffb4d1a3e7 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 20 May 2023 00:40:07 +0530
Subject: [PATCH 2/3] megapixels: remove redundant update checker

---
 srcpkgs/megapixels/update | 1 -
 1 file changed, 1 deletion(-)
 delete mode 100644 srcpkgs/megapixels/update

diff --git a/srcpkgs/megapixels/update b/srcpkgs/megapixels/update
deleted file mode 100644
index 3172862eef09..000000000000
--- a/srcpkgs/megapixels/update
+++ /dev/null
@@ -1 +0,0 @@
-site="https://gitlab.com/postmarketOS/megapixels/-/tags"

From e72e86b64833f6e8f5f453444a7c3f5d0edcf1bf Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 20 May 2023 00:41:47 +0530
Subject: [PATCH 3/3] goimapnotify: remove redundant update checker

---
 srcpkgs/goimapnotify/update | 2 --
 1 file changed, 2 deletions(-)
 delete mode 100644 srcpkgs/goimapnotify/update

diff --git a/srcpkgs/goimapnotify/update b/srcpkgs/goimapnotify/update
deleted file mode 100644
index b9a4e2b6728e..000000000000
--- a/srcpkgs/goimapnotify/update
+++ /dev/null
@@ -1,2 +0,0 @@
-site="https://gitlab.com/shackra/goimapnotify/-/tags/"
-pattern="goimapnotify-\K[\d.]*(?=\.tar\.gz)"

Re: common/xbps-src/shutils/update_check.sh: fix url for gitlab

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 828 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/43944#issuecomment-1556206216

Comment:
Please merge, I was going to PR the same.

Testing:
```
$ git grep -l homepage=.*gitlab.* srcpkgs/*/template | cut -d/ -f2 | xargs -P0 -n1 ./xbps-src update-check |& sed -ne 's/^NO VERSION found for //p' | sort
amtk
cmake-vala
deadbeef-fb
gnome-themes-extra
interception-tools
juCi++
libcloudproviders
liborcus
libxcvt
openrgb
python3-atspi
python3-cjkwrap
python3-libevdev
rest0
sugar
surfraw
tiptop
vmap
wlroots0.15
xboxdrv
```

Running the same  without  this PR gives 74 packages with "NO VERSION found" (including all those 20).

IOW, this PR fixes 54 pkgs without breaking any.

Another redundant one that can be removed is `srcpkgs/sympow/update`.

Re: [PR PATCH] [Closed]: common/xbps-src/shutils/update_check.sh: fix url for gitlab

[sgn]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

There's a closed pull request on the void-packages repository

common/xbps-src/shutils/update_check.sh: fix url for gitlab
https://github.com/void-linux/void-packages/pull/43944

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

All update checks which only rely on Gitlab are currently broken. The `code.videolan.org` counterpart also works with this change.

Re: common/xbps-src/shutils/update_check.sh: fix url for gitlab

[sgn]

[-- Attachment #1: Type: text/plain, Size: 149 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/43944#issuecomment-1569413537

Comment:
fc68d5f800c