[PR PATCH] New package: git-credential-oauth-0.8.0

[PR PATCH] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 1285 bytes --]

There is a new pull request by hickford against master on the void-packages repository

https://github.com/hickford/void-packages git-credential-oauth
https://github.com/void-linux/void-packages/pull/44237

New package: git-credential-oauth-0.8.0
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-git-credential-oauth-44237.patch --]
[-- Type: text/x-diff, Size: 1144 bytes --]

From aea33c3016349099df8729fad0f1a58988079ace Mon Sep 17 00:00:00 2001
From: M Hickford <mirth.hickford@gmail.com>
Date: Sat, 3 Jun 2023 09:16:17 +0100
Subject: [PATCH] New package: git-credential-oauth-0.8.0

---
 srcpkgs/git-credential-oauth/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/git-credential-oauth/template

diff --git a/srcpkgs/git-credential-oauth/template b/srcpkgs/git-credential-oauth/template
new file mode 100644
index 000000000000..e9a7fb99935c
--- /dev/null
+++ b/srcpkgs/git-credential-oauth/template
@@ -0,0 +1,13 @@
+# Template file for 'git-credential-oauth'
+pkgname=git-credential-oauth
+version=0.8.0
+revision=1
+build_style=go
+build_helper=qemu
+go_import_path=github.com/hickford/git-credential-oauth
+short_desc="Git credential helper that authenticate using OAuth"
+maintainer="M Hickford <mirth.hickford@gmail.com>"
+license="Apache-2.0	"
+homepage="https://github.com/hickford/git-credential-oauth"
+distfiles="https://github.com/hickford/git-credential-oauth/archive/v${version}.tar.gz"
+checksum=3c48505c9fc02ef46a5ecadcbc4470a5389d82c7e607448d2d24333726c08809

Re: [PR PATCH] [Updated] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

There is an updated pull request by hickford against master on the void-packages repository

https://github.com/hickford/void-packages git-credential-oauth
https://github.com/void-linux/void-packages/pull/44237

New package: git-credential-oauth-0.8.0
https://github.com/hickford/git-credential-oauth

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-git-credential-oauth-44237.patch --]
[-- Type: text/x-diff, Size: 1144 bytes --]

From 91c9379123837bb3a7365e486f1c644a82e27b40 Mon Sep 17 00:00:00 2001
From: M Hickford <mirth.hickford@gmail.com>
Date: Sat, 3 Jun 2023 09:16:17 +0100
Subject: [PATCH] New package: git-credential-oauth-0.8.0

---
 srcpkgs/git-credential-oauth/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/git-credential-oauth/template

diff --git a/srcpkgs/git-credential-oauth/template b/srcpkgs/git-credential-oauth/template
new file mode 100644
index 000000000000..e9a7fb99935c
--- /dev/null
+++ b/srcpkgs/git-credential-oauth/template
@@ -0,0 +1,13 @@
+# Template file for 'git-credential-oauth'
+pkgname=git-credential-oauth
+version=0.8.0
+revision=1
+build_style=go
+build_helper=qemu
+go_import_path=github.com/hickford/git-credential-oauth
+short_desc="Git credential helper that authenticate using OAuth"
+maintainer="M Hickford <mirth.hickford@gmail.com>"
+license="Apache-2.0	"
+homepage="https://github.com/hickford/git-credential-oauth"
+distfiles="https://github.com/hickford/git-credential-oauth/archive/v${version}.tar.gz"
+checksum=3c48505c9fc02ef46a5ecadcbc4470a5389d82c7e607448d2d24333726c08809

Re: [PR PATCH] [Updated] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 1331 bytes --]

There is an updated pull request by hickford against master on the void-packages repository

https://github.com/hickford/void-packages git-credential-oauth
https://github.com/void-linux/void-packages/pull/44237

New package: git-credential-oauth-0.8.0
https://github.com/hickford/git-credential-oauth

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**|**briefly**|**NO**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-git-credential-oauth-44237.patch --]
[-- Type: text/x-diff, Size: 1143 bytes --]

From d8ed87c5926cfacaad48ca45bd26090799629f6e Mon Sep 17 00:00:00 2001
From: M Hickford <mirth.hickford@gmail.com>
Date: Sat, 3 Jun 2023 09:16:17 +0100
Subject: [PATCH] New package: git-credential-oauth-0.8.0

---
 srcpkgs/git-credential-oauth/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/git-credential-oauth/template

diff --git a/srcpkgs/git-credential-oauth/template b/srcpkgs/git-credential-oauth/template
new file mode 100644
index 000000000000..9a7115c813da
--- /dev/null
+++ b/srcpkgs/git-credential-oauth/template
@@ -0,0 +1,13 @@
+# Template file for 'git-credential-oauth'
+pkgname=git-credential-oauth
+version=0.8.0
+revision=1
+build_style=go
+build_helper=qemu
+go_import_path=github.com/hickford/git-credential-oauth
+short_desc="Git credential helper that authenticate using OAuth"
+maintainer="M Hickford <mirth.hickford@gmail.com>"
+license="Apache-2.0"
+homepage="https://github.com/hickford/git-credential-oauth"
+distfiles="https://github.com/hickford/git-credential-oauth/archive/v${version}.tar.gz"
+checksum=3c48505c9fc02ef46a5ecadcbc4470a5389d82c7e607448d2d24333726c08809

Re: [PR REVIEW] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New review comment by hickford on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#discussion_r1215341734

Comment:
Is qemu necessary? I copied from another Go template

Re: [PR PATCH] [Updated] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There is an updated pull request by hickford against master on the void-packages repository

https://github.com/hickford/void-packages git-credential-oauth
https://github.com/void-linux/void-packages/pull/44237

New package: git-credential-oauth-0.8.0
https://github.com/hickford/git-credential-oauth

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (I don't have a Void Linux system)

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**



A patch file from https://github.com/void-linux/void-packages/pull/44237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-git-credential-oauth-44237.patch --]
[-- Type: text/x-diff, Size: 1912 bytes --]

From d8ed87c5926cfacaad48ca45bd26090799629f6e Mon Sep 17 00:00:00 2001
From: M Hickford <mirth.hickford@gmail.com>
Date: Sat, 3 Jun 2023 09:16:17 +0100
Subject: [PATCH 1/2] New package: git-credential-oauth-0.8.0

---
 srcpkgs/git-credential-oauth/template | 13 +++++++++++++
 1 file changed, 13 insertions(+)
 create mode 100644 srcpkgs/git-credential-oauth/template

diff --git a/srcpkgs/git-credential-oauth/template b/srcpkgs/git-credential-oauth/template
new file mode 100644
index 000000000000..9a7115c813da
--- /dev/null
+++ b/srcpkgs/git-credential-oauth/template
@@ -0,0 +1,13 @@
+# Template file for 'git-credential-oauth'
+pkgname=git-credential-oauth
+version=0.8.0
+revision=1
+build_style=go
+build_helper=qemu
+go_import_path=github.com/hickford/git-credential-oauth
+short_desc="Git credential helper that authenticate using OAuth"
+maintainer="M Hickford <mirth.hickford@gmail.com>"
+license="Apache-2.0"
+homepage="https://github.com/hickford/git-credential-oauth"
+distfiles="https://github.com/hickford/git-credential-oauth/archive/v${version}.tar.gz"
+checksum=3c48505c9fc02ef46a5ecadcbc4470a5389d82c7e607448d2d24333726c08809

From d42ec5c0f374c814ef577398a1e173b36931c617 Mon Sep 17 00:00:00 2001
From: M Hickford <mirth.hickford@gmail.com>
Date: Mon, 5 Jun 2023 00:20:25 +0100
Subject: [PATCH 2/2] no qemu

---
 srcpkgs/git-credential-oauth/template | 1 -
 1 file changed, 1 deletion(-)

diff --git a/srcpkgs/git-credential-oauth/template b/srcpkgs/git-credential-oauth/template
index 9a7115c813da..d8decf12f1f2 100644
--- a/srcpkgs/git-credential-oauth/template
+++ b/srcpkgs/git-credential-oauth/template
@@ -3,7 +3,6 @@ pkgname=git-credential-oauth
 version=0.8.0
 revision=1
 build_style=go
-build_helper=qemu
 go_import_path=github.com/hickford/git-credential-oauth
 short_desc="Git credential helper that authenticate using OAuth"
 maintainer="M Hickford <mirth.hickford@gmail.com>"

Re: [PR PATCH] [Updated] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There is an updated pull request by hickford against master on the void-packages repository

https://github.com/hickford/void-packages git-credential-oauth
https://github.com/void-linux/void-packages/pull/44237

New package: git-credential-oauth-0.8.0
https://github.com/hickford/git-credential-oauth

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (I don't have a Void Linux system)

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**



A patch file from https://github.com/void-linux/void-packages/pull/44237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-git-credential-oauth-44237.patch --]
[-- Type: text/x-diff, Size: 1172 bytes --]

From 007b91ea4b9a6f11348b639424410ef88f0de086 Mon Sep 17 00:00:00 2001
From: M Hickford <mirth.hickford@gmail.com>
Date: Sat, 3 Jun 2023 09:16:17 +0100
Subject: [PATCH] New package: git-credential-oauth-0.8.0

https://github.com/hickford/git-credential-oauth
---
 srcpkgs/git-credential-oauth/template | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 srcpkgs/git-credential-oauth/template

diff --git a/srcpkgs/git-credential-oauth/template b/srcpkgs/git-credential-oauth/template
new file mode 100644
index 000000000000..d8decf12f1f2
--- /dev/null
+++ b/srcpkgs/git-credential-oauth/template
@@ -0,0 +1,12 @@
+# Template file for 'git-credential-oauth'
+pkgname=git-credential-oauth
+version=0.8.0
+revision=1
+build_style=go
+go_import_path=github.com/hickford/git-credential-oauth
+short_desc="Git credential helper that authenticate using OAuth"
+maintainer="M Hickford <mirth.hickford@gmail.com>"
+license="Apache-2.0"
+homepage="https://github.com/hickford/git-credential-oauth"
+distfiles="https://github.com/hickford/git-credential-oauth/archive/v${version}.tar.gz"
+checksum=3c48505c9fc02ef46a5ecadcbc4470a5389d82c7e607448d2d24333726c08809

Re: [PR REVIEW] New package: git-credential-oauth-0.8.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 277 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#discussion_r1220216166

Comment:
not here, it's used for the `vtargetrun` function to run, for example to run a built binary to generate shell completions

Re: [PR REVIEW] New package: git-credential-oauth-0.8.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#discussion_r1220216166

Comment:
not here, it's used for the `vtargetrun` function, for example to run a built binary to generate shell completions

Re: [PR REVIEW] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 155 bytes --]

New review comment by hickford on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#discussion_r1220217829

Comment:
Thanks

Re: [PR REVIEW] New package: git-credential-oauth-0.8.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 273 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#discussion_r1220957084

Comment:
```suggestion
distfiles="https://github.com/hickford/git-credential-oauth/archive/refs/tags/v${version}.tar.gz"
```

Re: [PR PATCH] [Updated] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 768 bytes --]

There is an updated pull request by hickford against master on the void-packages repository

https://github.com/hickford/void-packages git-credential-oauth
https://github.com/void-linux/void-packages/pull/44237

New package: git-credential-oauth-0.8.0
https://github.com/hickford/git-credential-oauth

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (I don't have a Void Linux system)

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**



A patch file from https://github.com/void-linux/void-packages/pull/44237.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-git-credential-oauth-44237.patch --]
[-- Type: text/x-diff, Size: 2252 bytes --]

From 007b91ea4b9a6f11348b639424410ef88f0de086 Mon Sep 17 00:00:00 2001
From: M Hickford <mirth.hickford@gmail.com>
Date: Sat, 3 Jun 2023 09:16:17 +0100
Subject: [PATCH 1/2] New package: git-credential-oauth-0.8.0

https://github.com/hickford/git-credential-oauth
---
 srcpkgs/git-credential-oauth/template | 12 ++++++++++++
 1 file changed, 12 insertions(+)
 create mode 100644 srcpkgs/git-credential-oauth/template

diff --git a/srcpkgs/git-credential-oauth/template b/srcpkgs/git-credential-oauth/template
new file mode 100644
index 000000000000..d8decf12f1f2
--- /dev/null
+++ b/srcpkgs/git-credential-oauth/template
@@ -0,0 +1,12 @@
+# Template file for 'git-credential-oauth'
+pkgname=git-credential-oauth
+version=0.8.0
+revision=1
+build_style=go
+go_import_path=github.com/hickford/git-credential-oauth
+short_desc="Git credential helper that authenticate using OAuth"
+maintainer="M Hickford <mirth.hickford@gmail.com>"
+license="Apache-2.0"
+homepage="https://github.com/hickford/git-credential-oauth"
+distfiles="https://github.com/hickford/git-credential-oauth/archive/v${version}.tar.gz"
+checksum=3c48505c9fc02ef46a5ecadcbc4470a5389d82c7e607448d2d24333726c08809

From 799dc27f8a8fb4e1c5bac5456e87fcfe608d7b34 Mon Sep 17 00:00:00 2001
From: M Hickford <mirth.hickford@gmail.com>
Date: Fri, 9 Jun 2023 19:38:34 +0100
Subject: [PATCH 2/2] Update srcpkgs/git-credential-oauth/template

Co-authored-by: Marcin Puc <tranzystorek.io@protonmail.com>
---
 srcpkgs/git-credential-oauth/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/git-credential-oauth/template b/srcpkgs/git-credential-oauth/template
index d8decf12f1f2..6ef5ec690f93 100644
--- a/srcpkgs/git-credential-oauth/template
+++ b/srcpkgs/git-credential-oauth/template
@@ -8,5 +8,5 @@ short_desc="Git credential helper that authenticate using OAuth"
 maintainer="M Hickford <mirth.hickford@gmail.com>"
 license="Apache-2.0"
 homepage="https://github.com/hickford/git-credential-oauth"
-distfiles="https://github.com/hickford/git-credential-oauth/archive/v${version}.tar.gz"
+distfiles="https://github.com/hickford/git-credential-oauth/archive/refs/tags/v${version}.tar.gz"
 checksum=3c48505c9fc02ef46a5ecadcbc4470a5389d82c7e607448d2d24333726c08809

Re: [PR REVIEW] New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New review comment by hickford on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#discussion_r1224634154

Comment:
Both links work, is there any difference?

Re: [PR REVIEW] New package: git-credential-oauth-0.8.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#discussion_r1224635812

Comment:
Just a good practice, and there have been cases where a tag is named the same as a branch and fetch fails due to ambiguity

Re: [PR REVIEW] New package: git-credential-oauth-0.8.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 291 bytes --]

New review comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#discussion_r1224635812

Comment:
Just a good practice, and there have been cases where a tag is named the same as a branch and fetch fails due to ambiguity without this

Re: New package: git-credential-oauth-0.8.0

[hickford]

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

New comment by hickford on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#issuecomment-1627474413

Comment:
@tranzystorek-io I agree, best maintainer would be a Void Linux user, but I'm happy to maintain this package in the interim, as I do in other distros. Unless I'm missing something, `build_style=go` does all the work, so package update is as simple as updating the version and checksum. CI covers package build.

Re: New package: git-credential-oauth-0.8.0

[tranzystorek-io]

[-- Attachment #1: Type: text/plain, Size: 348 bytes --]

New comment by tranzystorek-io on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#issuecomment-1627546471

Comment:
If what we aimed for was just bumping template version on release. there are bots and scripts for that, but a maintainer is generally expected to manually run some functional tests on their package.

Re: New package: git-credential-oauth-0.8.0

[sgn]

[-- Attachment #1: Type: text/plain, Size: 345 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#issuecomment-1694221311

Comment:
> If what we aimed for was just bumping template version on release. there are bots and scripts for that, but a maintainer is generally expected to manually run some functional tests on their package.

This!

Re: New package: git-credential-oauth-0.8.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44237#issuecomment-1826182871

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: git-credential-oauth-0.8.0

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 626 bytes --]

There's a closed pull request on the void-packages repository

New package: git-credential-oauth-0.8.0
https://github.com/void-linux/void-packages/pull/44237

Description:
https://github.com/hickford/git-credential-oauth (I'm the upstream developer)

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO** (I don't have a Void Linux system)

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**