From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] python3-ipython: update to 8.14.0.
Date: Mon, 05 Jun 2023 17:05:07 +0200 [thread overview]
Message-ID: <20230605150507.7d7EyeEsnDaZvN4HN6bq0ES-0bZHvf_Bu5ZMA56uVLY@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44268@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 962 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/44268#discussion_r1218208379
Comment:
The problem isn't that this works in a `venv`, it's how you're calling `pytest`. The default `do_build` runs `pytest3` but you are running `python3 -m pytest`, which means you add `.` to the Python path by default. If you were to run
```sh
ln -Tsf /usr/bin/pytest3 "${testdir}/bin/pytest3"
"${testdir}/bin/pytest3"
```
instead of `python3 -m pytest`, the tests would again fail with an inability to find `IPython`.
This suggests that `pytest` is not actually testing against the contents of the wheel, but is instead testing the contents of the source tree. (Although, in the single test `test_ipython_embed`, it expects to find an `ipython` entrypoint and fails.) In fact, it is sufficient to do
```sh
do_check() {
python3 -m pytest -k 'not(test_ipython_embed)'
}
```
for a successful test run.
next prev parent reply other threads:[~2023-06-05 15:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-04 21:07 [PR PATCH] " tornaria
2023-06-04 21:27 ` tornaria
2023-06-04 21:34 ` [PR PATCH] [Updated] " tornaria
2023-06-05 1:19 ` tornaria
2023-06-05 1:42 ` tornaria
2023-06-05 6:20 ` [PR REVIEW] " tornaria
2023-06-05 15:05 ` ahesford
2023-06-05 15:05 ` ahesford
2023-06-05 15:05 ` ahesford [this message]
2023-06-05 17:03 ` tornaria
2023-06-05 17:05 ` [PR PATCH] [Updated] " tornaria
2023-06-05 17:07 ` [PR REVIEW] " ahesford
2023-06-05 17:35 ` [PR PATCH] [Closed]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230605150507.7d7EyeEsnDaZvN4HN6bq0ES-0bZHvf_Bu5ZMA56uVLY@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).