Github messages for voidlinux
 help / color / mirror / Atom feed
From: tornaria <tornaria@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: [PR PATCH] python3-ipython: update to 8.14.0.
Date: Sun, 04 Jun 2023 23:07:11 +0200	[thread overview]
Message-ID: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44268@inbox.vuxu.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages ipython
https://github.com/void-linux/void-packages/pull/44268

python3-ipython: update to 8.14.0.
 - switch to pep517 build style: needs using a venv
 - update depends and checkdepends
 - break unnecessary checkdepends cycle with ipython_ipykernel

#### Testing the changes
- I tested the changes in this PR: **briefly**

I will run sagemath testsuite with this update and report back.

@ahesford here's one package where testing with `PYTHONPATH` breaks and testing in a venv works. I wrote a custom `do_check()` function but you'll see it's quite generic and could be moved to `build-style/python3-pep517.sh`.

Maybe you can figure out a different way to make the generic testing with `PYTHONPATH` to work.

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44268.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ipython-44268.patch --]
[-- Type: text/x-diff, Size: 2516 bytes --]

From a36beda891dfeb232cc5ec73b7d902be01143afd Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Sat, 3 Jun 2023 15:50:15 -0300
Subject: [PATCH] python3-ipython: update to 8.14.0.

 - switch to pep517 build style: needs using a venv
 - update depends and checkdepends
 - break unnecessary checkdepends cycle with ipython_ipykernel
---
 srcpkgs/python3-ipython/template | 27 +++++++++++++++++++--------
 1 file changed, 19 insertions(+), 8 deletions(-)

diff --git a/srcpkgs/python3-ipython/template b/srcpkgs/python3-ipython/template
index 14b1cc291123..65a74e218d40 100644
--- a/srcpkgs/python3-ipython/template
+++ b/srcpkgs/python3-ipython/template
@@ -1,24 +1,35 @@
 # Template file for 'python3-ipython'
 pkgname=python3-ipython
-version=8.13.2
+version=8.14.0
 revision=1
-build_style=python3-module
-hostmakedepends="python3-setuptools"
-depends="python3-setuptools python3-jedi python3-decorator python3-pickleshare
+build_style=python3-pep517
+hostmakedepends="python3-wheel"
+depends="python3-jedi python3-decorator python3-pickleshare
  python3-traitlets python3-prompt_toolkit python3-Pygments python3-backcall
  python3-matplotlib-inline python3-pexpect python3-stack_data"
-checkdepends="python3-pytest $depends python3-matplotlib python3-Pillow
- python3-requests python3-testpath python3-numpy python3-ipython_ipykernel
- python3-jupyter_nbformat python3-Pygments"
+checkdepends="$depends python3-pytest-asyncio python3-testpath
+ python3-curio python3-jupyter_nbformat python3-matplotlib
+ python3-numpy python3-pandas python3-trio"
 short_desc="Enhanced interactive Python3 shell"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="BSD-3-Clause"
 homepage="https://ipython.org/"
 changelog="https://github.com/ipython/ipython/raw/main/docs/source/whatsnew/version8.rst"
 distfiles="${PYPI_SITE}/i/ipython/ipython-${version}.tar.gz"
-checksum=7dff3fad32b97f6488e02f87b970f309d082f758d7b7fc252e3b19ee0e432dbb
+checksum=1d197b907b6ba441b692c48cf2a3a2de280dc0ac91a3405b39349a50272ca0a1
 conflicts="python-ipython<=5.8.0_2"
 
+do_check() {
+	# Running via PYTHONPATH breaks... venv works
+	# This could be moved to build-style/python3-pep517.sh
+	local testdir="${wrksrc}/.xbps-testdir"
+	rm -rf "${testdir}"
+	python3 -m venv --system-site-packages --without-pip "${testdir}"
+	local -x PATH="${testdir}/bin:${PATH}"
+	python3 -m installer dist/*.whl
+	python3 -m pytest
+}
+
 post_install() {
 	# remove iptest
 	rm -f ${DESTDIR}/usr/bin/iptest*

             reply	other threads:[~2023-06-04 21:07 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-04 21:07 tornaria [this message]
2023-06-04 21:27 ` tornaria
2023-06-04 21:34 ` [PR PATCH] [Updated] " tornaria
2023-06-05  1:19 ` tornaria
2023-06-05  1:42 ` tornaria
2023-06-05  6:20 ` [PR REVIEW] " tornaria
2023-06-05 15:05 ` ahesford
2023-06-05 15:05 ` ahesford
2023-06-05 15:05 ` ahesford
2023-06-05 17:03 ` tornaria
2023-06-05 17:05 ` [PR PATCH] [Updated] " tornaria
2023-06-05 17:07 ` [PR REVIEW] " ahesford
2023-06-05 17:35 ` [PR PATCH] [Closed]: " ahesford

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44268@inbox.vuxu.org \
    --to=tornaria@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).