[PR PATCH] New package: libudunits-2.2.28

[PR PATCH] New package: libudunits-2.2.28

[brihadeesh]

[-- Attachment #1: Type: text/plain, Size: 1397 bytes --]

There is a new pull request by brihadeesh against master on the void-packages repository

https://github.com/brihadeesh/void-packages np_udunits
https://github.com/void-linux/void-packages/pull/40818

New package: libudunits-2.2.28
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

#### Notes:

There are some issues with the license. I've marked this as MIT, but the only available file (COPYRIGHT) doesn't state this explicitly. It appears to be a modified MIT license but Fedora wiki suggests it's compatible with MIT, GPL v2 and v3. 

Based on what we discussed on the IRC, this appears to be "nonfree", so are there any changes I'll have to make for this?

A patch file from https://github.com/void-linux/void-packages/pull/40818.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-np_udunits-40818.patch --]
[-- Type: text/x-diff, Size: 1147 bytes --]

From 20b244dafc23f0c81137442584c9e985af8cb781 Mon Sep 17 00:00:00 2001
From: Brihadeesh S <brihadeesh.santharam@gmail.com>
Date: Mon, 28 Nov 2022 14:55:12 +0530
Subject: [PATCH] New package: libudunits-2.2.28

---
 srcpkgs/libudunits/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/libudunits/template

diff --git a/srcpkgs/libudunits/template b/srcpkgs/libudunits/template
new file mode 100644
index 000000000000..779ce3260bc4
--- /dev/null
+++ b/srcpkgs/libudunits/template
@@ -0,0 +1,17 @@
+# Template file for 'libudunits'
+pkgname=libudunits
+version=2.2.28
+revision=1
+build_style=gnu-configure
+hostmakedepends="texinfo"
+makedepends="expat-devel"
+short_desc="C library for physical unit-definition and value-conversion utility"
+maintainer="Brihadeesh <brihadeesh@protonmail.com>"
+license="MIT"
+homepage="https://www.unidata.ucar.edu/software/udunits/"
+distfiles="https://artifacts.unidata.ucar.edu/repository/downloads-udunits/${version}/udunits-${version}.tar.gz"
+checksum=590baec83161a3fd62c00efa66f6113cec8a7c461e3f61a5182167e0cc5d579e
+
+post_install() {
+    vlicense COPYRIGHT
+}

Re: [PR PATCH] [Updated] New package: libudunits-2.2.28

[brihadeesh]

[-- Attachment #1: Type: text/plain, Size: 1402 bytes --]

There is an updated pull request by brihadeesh against master on the void-packages repository

https://github.com/brihadeesh/void-packages np_udunits
https://github.com/void-linux/void-packages/pull/40818

New package: libudunits-2.2.28
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

#### Notes:

There are some issues with the license. I've marked this as MIT, but the only available file (COPYRIGHT) doesn't state this explicitly. It appears to be a modified MIT license but Fedora wiki suggests it's compatible with MIT, GPL v2 and v3. 

Based on what we discussed on the IRC, this appears to be "nonfree", so are there any changes I'll have to make for this?

A patch file from https://github.com/void-linux/void-packages/pull/40818.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-np_udunits-40818.patch --]
[-- Type: text/x-diff, Size: 1144 bytes --]

From 8ced0e96cd33f0a5339159c8606f794c128c32b5 Mon Sep 17 00:00:00 2001
From: Brihadeesh S <brihadeesh.santharam@gmail.com>
Date: Mon, 28 Nov 2022 14:55:12 +0530
Subject: [PATCH] New package: libudunits-2.2.28

---
 srcpkgs/libudunits/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/libudunits/template

diff --git a/srcpkgs/libudunits/template b/srcpkgs/libudunits/template
new file mode 100644
index 000000000000..694188ac1e19
--- /dev/null
+++ b/srcpkgs/libudunits/template
@@ -0,0 +1,17 @@
+# Template file for 'libudunits'
+pkgname=libudunits
+version=2.2.28
+revision=1
+build_style=gnu-configure
+hostmakedepends="texinfo"
+makedepends="expat-devel"
+short_desc="C library for physical unit-definition and value-conversion utility"
+maintainer="Brihadeesh <brihadeesh@protonmail.com>"
+license="MIT"
+homepage="https://www.unidata.ucar.edu/software/udunits/"
+distfiles="https://artifacts.unidata.ucar.edu/repository/downloads-udunits/${version}/udunits-${version}.tar.gz"
+checksum=590baec83161a3fd62c00efa66f6113cec8a7c461e3f61a5182167e0cc5d579e
+
+post_install() {
+	vlicense COPYRIGHT
+}

Re: New package: libudunits-2.2.28

[brihadeesh]

[-- Attachment #1: Type: text/plain, Size: 278 bytes --]

New comment by brihadeesh on void-packages repository

https://github.com/void-linux/void-packages/pull/40818#issuecomment-1328803977

Comment:
This was based on a package request #40816 I'd opened earlier. This happens to be an indirect dependency for the `ggthemes` R package

Re: New package: libudunits-2.2.28

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/40818#issuecomment-1329500210

Comment:
@brihadeesh maybe add ggthemes R package to this PR?

Re: New package: libudunits-2.2.28

[brihadeesh]

[-- Attachment #1: Type: text/plain, Size: 387 bytes --]

New comment by brihadeesh on void-packages repository

https://github.com/void-linux/void-packages/pull/40818#issuecomment-1329535374

Comment:
@CameronNemo I actually install most R packages from within R and I'm not sure I'll have the time to maintain something like that. I'm also fairly new to this so perhaps once I get a little more familiar? Unless someone's willing to help out.

Re: New package: libudunits-2.2.28

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/40818#issuecomment-1445560466

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR REVIEW] New package: libudunits-2.2.28

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 235 bytes --]

New review comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/40818#discussion_r1118240144

Comment:
Looks like "UCAR" was added as an SPDX license. https://spdx.org/licenses/UCAR.html

Re: New package: libudunits-2.2.28

[CameronNemo]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

New comment by CameronNemo on void-packages repository

https://github.com/void-linux/void-packages/pull/40818#issuecomment-1445627195

Comment:
This should probably have a `-devel` subpackage with any development files like headers or package config files. See libslirp/libslirp-devel for an example.

Re: New package: libudunits-2.2.28

[brihadeesh]

[-- Attachment #1: Type: text/plain, Size: 201 bytes --]

New comment by brihadeesh on void-packages repository

https://github.com/void-linux/void-packages/pull/40818#issuecomment-1446765024

Comment:
Will push changes tomorrow (i'm nearly done for the day)

Re: New package: libudunits-2.2.28

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/40818#issuecomment-1567662952

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: libudunits-2.2.28

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

There's a closed pull request on the void-packages repository

New package: libudunits-2.2.28
https://github.com/void-linux/void-packages/pull/40818

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

#### Notes:

There are some issues with the license. I've marked this as MIT, but the only available file (COPYRIGHT) doesn't state this explicitly. It appears to be a modified MIT license but Fedora wiki suggests it's compatible with MIT, GPL v2 and v3. 

Based on what we discussed on the IRC, this appears to be "nonfree", so are there any changes I'll have to make for this?