[PR PATCH] devilutionX: update to 1.5.0

[PR PATCH] devilutionX: update to 1.5.0

[SolitudeSF]

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

There is a new pull request by SolitudeSF against master on the void-packages repository

https://github.com/SolitudeSF/void-packages devilution
https://github.com/void-linux/void-packages/pull/44521

devilutionX: update to 1.5.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64 glibc

A patch file from https://github.com/void-linux/void-packages/pull/44521.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-devilution-44521.patch --]
[-- Type: text/x-diff, Size: 1231 bytes --]

From 6efc6d69f5e6bc75c11e47771f725d71eab5ef1f Mon Sep 17 00:00:00 2001
From: SolitudeSF <solitudesf@protonmail.com>
Date: Mon, 19 Jun 2023 18:55:33 +0300
Subject: [PATCH] devilutionX: update to 1.5.0

---
 srcpkgs/devilutionX/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index b9a7c445409f..17467ad8f98b 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,7 +1,7 @@
 # Template file for 'devilutionX'
 pkgname=devilutionX
-version=1.4.1
-revision=2
+version=1.5.0
+revision=1
 build_style=cmake
 configure_args="-DVERSION_NUM=$version -DDISABLE_ZERO_TIER=ON"
 hostmakedepends="pkg-config"
@@ -13,8 +13,8 @@ license="Unlicense"
 homepage="https://github.com/diasurgical/devilutionX"
 changelog="https://raw.githubusercontent.com/diasurgical/devilutionX/master/docs/CHANGELOG.md"
 distfiles="https://github.com/diasurgical/devilutionX/releases/download/${version}/devilutionx-src.tar.xz"
-checksum=f80a5414bb7b5a5ae9f6dbc69cec4ae080c29dd0a8a553cedd405d631011da9f
+checksum=425e63891792c4ab213865f8e1b4401317439bf47450f18064ee72ebf9a2abf8
 
 post_install() {
-	vlicense LICENSE
+	vlicense LICENSE.md
 }

Re: devilutionX: update to 1.5.0

[SolitudeSF]

[-- Attachment #1: Type: text/plain, Size: 205 bytes --]

New comment by SolitudeSF on void-packages repository

https://github.com/void-linux/void-packages/pull/44521#issuecomment-1597602204

Comment:
check fails because of the test that requires original data.

Re: [PR PATCH] [Updated] devilutionX: update to 1.5.0

[SolitudeSF]

[-- Attachment #1: Type: text/plain, Size: 491 bytes --]

There is an updated pull request by SolitudeSF against master on the void-packages repository

https://github.com/SolitudeSF/void-packages devilution
https://github.com/void-linux/void-packages/pull/44521

devilutionX: update to 1.5.0
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64 glibc

A patch file from https://github.com/void-linux/void-packages/pull/44521.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-devilution-44521.patch --]
[-- Type: text/x-diff, Size: 1915 bytes --]

From 0e7b120edada61ea1041eb6d692a1c9fc9168c29 Mon Sep 17 00:00:00 2001
From: SolitudeSF <solitudesf@protonmail.com>
Date: Mon, 19 Jun 2023 18:55:33 +0300
Subject: [PATCH] devilutionX: update to 1.5.0

---
 srcpkgs/devilutionX/patches/disable_test.patch | 12 ++++++++++++
 srcpkgs/devilutionX/template                   |  8 ++++----
 2 files changed, 16 insertions(+), 4 deletions(-)
 create mode 100644 srcpkgs/devilutionX/patches/disable_test.patch

diff --git a/srcpkgs/devilutionX/patches/disable_test.patch b/srcpkgs/devilutionX/patches/disable_test.patch
new file mode 100644
index 000000000000..b89421cd7aaa
--- /dev/null
+++ b/srcpkgs/devilutionX/patches/disable_test.patch
@@ -0,0 +1,12 @@
+diff --git a/test/CMakeLists.txt b/test/CMakeLists.txt
+index b84cb2e..bcdcf51 100644
+--- a/test/CMakeLists.txt
++++ b/test/CMakeLists.txt
+@@ -38,7 +38,6 @@ set(tests
+   scrollrt_test
+   stores_test
+   str_cat_test
+-  timedemo_test
+   utf8_test
+   writehero_test
+ )
diff --git a/srcpkgs/devilutionX/template b/srcpkgs/devilutionX/template
index b9a7c445409f..17467ad8f98b 100644
--- a/srcpkgs/devilutionX/template
+++ b/srcpkgs/devilutionX/template
@@ -1,7 +1,7 @@
 # Template file for 'devilutionX'
 pkgname=devilutionX
-version=1.4.1
-revision=2
+version=1.5.0
+revision=1
 build_style=cmake
 configure_args="-DVERSION_NUM=$version -DDISABLE_ZERO_TIER=ON"
 hostmakedepends="pkg-config"
@@ -13,8 +13,8 @@ license="Unlicense"
 homepage="https://github.com/diasurgical/devilutionX"
 changelog="https://raw.githubusercontent.com/diasurgical/devilutionX/master/docs/CHANGELOG.md"
 distfiles="https://github.com/diasurgical/devilutionX/releases/download/${version}/devilutionx-src.tar.xz"
-checksum=f80a5414bb7b5a5ae9f6dbc69cec4ae080c29dd0a8a553cedd405d631011da9f
+checksum=425e63891792c4ab213865f8e1b4401317439bf47450f18064ee72ebf9a2abf8
 
 post_install() {
-	vlicense LICENSE
+	vlicense LICENSE.md
 }

Re: devilutionX: update to 1.5.0

[SolitudeSF]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by SolitudeSF on void-packages repository

https://github.com/void-linux/void-packages/pull/44521#issuecomment-1597602204

Comment:
~~check fails because of the test that requires original data.~~

patched out invalid test.

Re: [PR PATCH] [Closed]: devilutionX: update to 1.5.0

[SolitudeSF]

[-- Attachment #1: Type: text/plain, Size: 326 bytes --]

There's a closed pull request on the void-packages repository

devilutionX: update to 1.5.0
https://github.com/void-linux/void-packages/pull/44521

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, x86_64 glibc

Re: devilutionX: update to 1.5.0

[kedodrill]

[-- Attachment #1: Type: text/plain, Size: 328 bytes --]

New comment by kedodrill on void-packages repository

https://github.com/void-linux/void-packages/pull/44425#issuecomment-1647043425

Comment:
Fwiw, played through the shareware version of diablo with this and it was fine. Although the license changed and now must be stuck in the nonfree repo, 1.5.0 does bring a lot of fixes.

Re: devilutionX: update to 1.5.0

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/44425#issuecomment-1610854178

Comment:
> Unless you somehow included game data in chroot, there should be test errors. As indicated by CI.

I added your patch!

Re: devilutionX: update to 1.5.0

[SolitudeSF]

[-- Attachment #1: Type: text/plain, Size: 242 bytes --]

New comment by SolitudeSF on void-packages repository

https://github.com/void-linux/void-packages/pull/44425#issuecomment-1608957643

Comment:
Unless you somehow included game data in chroot, there should be test errors. As indicated by CI.

Re: devilutionX: update to 1.5.0

[SolitudeSF]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by SolitudeSF on void-packages repository

https://github.com/void-linux/void-packages/pull/44425#issuecomment-1608957643

Comment:
Unless you somehow included game data in chroot, there should be test errors.

Re: devilutionX: update to 1.5.0

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/44425#issuecomment-1608819280

Comment:
I compiled on 2 different machines for x86_64, x86_64-musl and i686, there were no test errors.

Re: devilutionX: update to 1.5.0

[SolitudeSF]

[-- Attachment #1: Type: text/plain, Size: 223 bytes --]

New comment by SolitudeSF on void-packages repository

https://github.com/void-linux/void-packages/pull/44425#issuecomment-1598933681

Comment:
https://github.com/void-linux/void-packages/pull/44521#issuecomment-1597602204

Re: devilutionX: update to 1.5.0

[bugcrazy]

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New comment by bugcrazy on void-packages repository

https://github.com/void-linux/void-packages/pull/44425#issuecomment-1598256470

Comment:
> This may be "nonfree".

It's a nonfree license!

https://blog.n8n.io/announcing-new-sustainable-use-license/

https://n8n.io/blog/fair-code-for-sustainable-open-source-alternatives/

Re: devilutionX: update to 1.5.0

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44425#issuecomment-1597638542

Comment:
This may be "nonfree".