From: CtrlC-Root <CtrlC-Root@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR REVIEW] libspnav: update to 1.1, minor fixes
Date: Sun, 25 Jun 2023 15:33:09 +0200 [thread overview]
Message-ID: <20230625133309.1hWTdzyzglLhwmPbjnwLLqeJcGJ32whCrzHukIHNX5A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44552@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 653 bytes --]
New review comment by CtrlC-Root on void-packages repository
https://github.com/void-linux/void-packages/pull/44552#discussion_r1241178734
Comment:
I tried to discuss this in an issue (https://github.com/void-linux/void-packages/issues/44550) which you closed without feedback. Granted I used the wrong issue template it seems but we're talking about a few lines here so absent any guidance from you I figured we could discuss it in a PR.
I'll force push this branch in a minute to revert this. I tried to guess based on PRs you reviewed whether I'd have to adopt it for this PR to be approved and I was aiming for approval on the first review :).
next prev parent reply other threads:[~2023-06-25 13:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-21 17:41 [PR PATCH] " CtrlC-Root
2023-06-21 17:42 ` CtrlC-Root
2023-06-21 19:00 ` [PR PATCH] [Updated] " CtrlC-Root
2023-06-21 19:00 ` CtrlC-Root
2023-06-24 19:26 ` [PR REVIEW] " classabbyamp
2023-06-25 13:33 ` CtrlC-Root [this message]
2023-06-25 13:34 ` [PR PATCH] [Updated] " CtrlC-Root
2023-06-25 13:34 ` [PR REVIEW] " CtrlC-Root
2023-06-25 13:36 ` CtrlC-Root
2023-06-25 13:38 ` [PR PATCH] [Updated] " CtrlC-Root
2023-06-25 13:39 ` [PR REVIEW] " CtrlC-Root
2023-06-25 18:07 ` [PR PATCH] [Merged]: " classabbyamp
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230625133309.1hWTdzyzglLhwmPbjnwLLqeJcGJ32whCrzHukIHNX5A@z \
--to=ctrlc-root@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).