Github messages for voidlinux
 help / color / mirror / Atom feed
From: CtrlC-Root <CtrlC-Root@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] libspnav: update to 1.1, minor fixes
Date: Sun, 25 Jun 2023 15:38:55 +0200	[thread overview]
Message-ID: <20230625133855.s5wXpCnoysGAOpUGLU0ntZw1JrUDtTOQoYo-Tk6OpJs@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44552@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1489 bytes --]

There is an updated pull request by CtrlC-Root against master on the void-packages repository

https://github.com/CtrlC-Root/void-packages update-libspnav
https://github.com/void-linux/void-packages/pull/44552

libspnav: update to 1.1, minor fixes
#### Testing the changes
- I tested the changes in this PR: **YES**

Using a SpaceMouse Pro Wireless with the latest upstream versions of `spacenavd`, `spnavcfg`, and the latest version of FreeCAD in the repository.

![libspnav-1 1-test-spacemouse-pro-wireless](https://github.com/void-linux/void-packages/assets/4819590/652ba122-021a-4f17-954d-7243073f1f2e)

#### Local build testing
- I built this PR locally for my native architecture, x86_64

#### Notes

* The upstream sources are now accessible on GitHub (for all three related packages). The 1.1 version is not on SourceForge so I switched the `distfiles` to GitHub.
* I dropped the `do_build()` section as it doesn't seem to be necessary when using the `gnu-configure` build style. If there's something I missed here for why this should be kept in please let me know.
* The library supports a non-X11 build but I'm not sure how to expose that. Does XBPS support variants like that? If it matters to someone and you can point me to the relevant documentation I would be willing to add it.
* I plan to package `spacenavd` and `spnavcfg` next which will depend on this library.


A patch file from https://github.com/void-linux/void-packages/pull/44552.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-update-libspnav-44552.patch --]
[-- Type: text/x-diff, Size: 1406 bytes --]

From e12ba9a9e6cc180f038eb1506dd2d9a1b16220eb Mon Sep 17 00:00:00 2001
From: Alexandru Barbur <alex@ctrlc.name>
Date: Wed, 21 Jun 2023 13:34:50 -0400
Subject: [PATCH] libspnav: update to 1.1, switch upstream to github

---
 srcpkgs/libspnav/template | 14 +++++---------
 1 file changed, 5 insertions(+), 9 deletions(-)

diff --git a/srcpkgs/libspnav/template b/srcpkgs/libspnav/template
index 059d254e17b7..170a840ad618 100644
--- a/srcpkgs/libspnav/template
+++ b/srcpkgs/libspnav/template
@@ -1,24 +1,20 @@
 # Template file for 'libspnav'
 pkgname=libspnav
-version=1.0
-revision=2
+version=1.1
+revision=1
 build_style=gnu-configure
-configure_args="--disable-opt"
 makedepends="libX11-devel"
 short_desc="Open source alternative to 3DConnextion drivers"
 maintainer="yopito <pierre.bourgin@free.fr>"
 license="BSD-3-Clause"
 homepage="http://spacenav.sourceforge.net/"
-distfiles="${SOURCEFORGE_SITE}/spacenav/${pkgname}-${version}.tar.gz"
-checksum=8849b7f7826d750f6956cf8f4f53937f2359ab6da97d6c834c71d5f771212e7c
-
-do_build() {
-	make CC="${CC}" AR="${AR}"
-}
+distfiles="https://github.com/FreeSpacenav/libspnav/archive/refs/tags/v${version}.tar.gz"
+checksum=04b297f68a10db4fa40edf68d7f823ba7b9d0442f2b665181889abe2cea42759
 
 post_install() {
 	vlicense LICENSE
 }
+
 libspnav-devel_package() {
 	short_desc+=" - development files"
 	depends="${makedepends} ${sourcepkg}>=${version}_${revision}"

  parent reply	other threads:[~2023-06-25 13:38 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-06-21 17:41 [PR PATCH] " CtrlC-Root
2023-06-21 17:42 ` CtrlC-Root
2023-06-21 19:00 ` [PR PATCH] [Updated] " CtrlC-Root
2023-06-21 19:00 ` CtrlC-Root
2023-06-24 19:26 ` [PR REVIEW] " classabbyamp
2023-06-25 13:33 ` CtrlC-Root
2023-06-25 13:34 ` [PR PATCH] [Updated] " CtrlC-Root
2023-06-25 13:34 ` [PR REVIEW] " CtrlC-Root
2023-06-25 13:36 ` CtrlC-Root
2023-06-25 13:38 ` CtrlC-Root [this message]
2023-06-25 13:39 ` [PR REVIEW] " CtrlC-Root
2023-06-25 18:07 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230625133855.s5wXpCnoysGAOpUGLU0ntZw1JrUDtTOQoYo-Tk6OpJs@z \
    --to=ctrlc-root@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).