Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: xidlehook-0.10.0
@ 2023-06-02 12:31 MOIS3Y
  2023-06-25 17:00 ` [PR REVIEW] " Duncaen
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: MOIS3Y @ 2023-06-02 12:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1005 bytes --]

There is a new pull request by MOIS3Y against master on the void-packages repository

https://github.com/MOIS3Y/void-packages xidlehook
https://github.com/void-linux/void-packages/pull/44225

New package: xidlehook-0.10.0
This PR is an updated version of https://github.com/void-linux/void-packages/pull/27774 since the original is closed. The requested changes have also been added.
There's also an associated package request for this PR: https://github.com/void-linux/void-packages/issues/27422

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures:
    - armv6l


A patch file from https://github.com/void-linux/void-packages/pull/44225.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xidlehook-44225.patch --]
[-- Type: text/x-diff, Size: 1373 bytes --]

From 3dd46bc471a63cbcd8490b7c566c6da6e9f75337 Mon Sep 17 00:00:00 2001
From: MOIS3Y <stepan@zhukovsky.me>
Date: Fri, 2 Jun 2023 21:09:02 +0900
Subject: [PATCH] New package: xidlehook-0.10.0

---
 srcpkgs/xidlehook/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/xidlehook/template

diff --git a/srcpkgs/xidlehook/template b/srcpkgs/xidlehook/template
new file mode 100644
index 000000000000..0670e5a7c76f
--- /dev/null
+++ b/srcpkgs/xidlehook/template
@@ -0,0 +1,22 @@
+# Template file for 'xidlehook'
+pkgname=xidlehook
+version=0.10.0
+revision=1
+build_wrksrc="xidlehook-daemon"
+build_style=cargo
+configure_args="$(vopt_if audio '--features pulse' '--no-default-features')"
+hostmakedepends="pkg-config python3"
+makedepends="libxcb-devel libXScrnSaver-devel $(vopt_if audio pulseaudio-devel)"
+short_desc="Xautolock rewrite in Rust, with a few extra features"
+maintainer="MOIS3Y <stepan@zhukovsky.me>"
+license="MIT"
+homepage="https://gitlab.com/jD91mZM2/xidlehook"
+distfiles="${homepage}/-/archive/${version}/${pkgname}-${version}.tar.gz"
+checksum=66751b78c5174c0e430d9becd749771d593f388db348514d8c3256670dc77cd8
+build_options_default="audio"
+desc_option_audio="Don't invoke the timer when any audio is playing (Only works with Pulseaudio)"
+build_options="audio"
+
+post_install() {
+	vlicense ../LICENSE
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
@ 2023-06-25 17:00 ` Duncaen
  2023-06-25 17:02 ` Duncaen
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2023-06-25 17:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 232 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44225#discussion_r1241238524

Comment:
Could you remove the variables `homepage` and `pkgname` here, they are not variable.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
  2023-06-25 17:00 ` [PR REVIEW] " Duncaen
@ 2023-06-25 17:02 ` Duncaen
  2023-06-25 17:02 ` Duncaen
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2023-06-25 17:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 256 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44225#discussion_r1241238750

Comment:
Randomly named build options are hardly useful, this should probably just use the `pulseaudio` build option.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
  2023-06-25 17:00 ` [PR REVIEW] " Duncaen
  2023-06-25 17:02 ` Duncaen
@ 2023-06-25 17:02 ` Duncaen
  2023-06-25 17:02 ` Duncaen
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2023-06-25 17:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44225#discussion_r1241238750

Comment:
Randomly named build options are hardly useful, this should probably just use the `pulseaudio` build option, which has a default description and used by other packages.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
                   ` (2 preceding siblings ...)
  2023-06-25 17:02 ` Duncaen
@ 2023-06-25 17:02 ` Duncaen
  2023-07-04 12:23 ` [PR PATCH] [Updated] " MOIS3Y
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2023-06-25 17:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 319 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44225#discussion_r1241238750

Comment:
Randomly named build options are hardly useful, this should probably just use the `pulseaudio` build option, which has a default description and is used by other packages.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Updated] New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
                   ` (3 preceding siblings ...)
  2023-06-25 17:02 ` Duncaen
@ 2023-07-04 12:23 ` MOIS3Y
  2023-07-04 12:25 ` [PR REVIEW] " MOIS3Y
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: MOIS3Y @ 2023-07-04 12:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1010 bytes --]

There is an updated pull request by MOIS3Y against master on the void-packages repository

https://github.com/MOIS3Y/void-packages xidlehook
https://github.com/void-linux/void-packages/pull/44225

New package: xidlehook-0.10.0
This PR is an updated version of https://github.com/void-linux/void-packages/pull/27774 since the original is closed. The requested changes have also been added.
There's also an associated package request for this PR: https://github.com/void-linux/void-packages/issues/27422

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures:
    - armv6l


A patch file from https://github.com/void-linux/void-packages/pull/44225.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-xidlehook-44225.patch --]
[-- Type: text/x-diff, Size: 1423 bytes --]

From 7a978b78ea6deeb1e89a04c44b82edbf45c9be2c Mon Sep 17 00:00:00 2001
From: MOIS3Y <stepan@zhukovsky.me>
Date: Fri, 2 Jun 2023 21:09:02 +0900
Subject: [PATCH] New package: xidlehook-0.10.0

---
 srcpkgs/xidlehook/template | 22 ++++++++++++++++++++++
 1 file changed, 22 insertions(+)
 create mode 100644 srcpkgs/xidlehook/template

diff --git a/srcpkgs/xidlehook/template b/srcpkgs/xidlehook/template
new file mode 100644
index 000000000000..3d1de47fda96
--- /dev/null
+++ b/srcpkgs/xidlehook/template
@@ -0,0 +1,22 @@
+# Template file for 'xidlehook'
+pkgname=xidlehook
+version=0.10.0
+revision=1
+build_wrksrc="xidlehook-daemon"
+build_style=cargo
+configure_args="$(vopt_if pulseaudio '--features pulse' '--no-default-features')"
+hostmakedepends="pkg-config python3"
+makedepends="libxcb-devel libXScrnSaver-devel $(vopt_if pulseaudio pulseaudio-devel)"
+short_desc="Xautolock rewrite in Rust, with a few extra features"
+maintainer="MOIS3Y <stepan@zhukovsky.me>"
+license="MIT"
+homepage="https://gitlab.com/jD91mZM2/xidlehook"
+distfiles="https://gitlab.com/jD91mZM2/xidlehook/-/archive/${version}/xidlehook-${version}.tar.gz"
+checksum=66751b78c5174c0e430d9becd749771d593f388db348514d8c3256670dc77cd8
+build_options_default="pulseaudio"
+desc_option_pulseaudio="Don't invoke the timer when any audio is playing (Only works with Pulseaudio)"
+build_options="pulseaudio"
+
+post_install() {
+	vlicense ../LICENSE
+}

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
                   ` (4 preceding siblings ...)
  2023-07-04 12:23 ` [PR PATCH] [Updated] " MOIS3Y
@ 2023-07-04 12:25 ` MOIS3Y
  2023-07-04 12:33 ` MOIS3Y
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: MOIS3Y @ 2023-07-04 12:25 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 151 bytes --]

New review comment by MOIS3Y on void-packages repository

https://github.com/void-linux/void-packages/pull/44225#discussion_r1251961731

Comment:
Done

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR REVIEW] New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
                   ` (5 preceding siblings ...)
  2023-07-04 12:25 ` [PR REVIEW] " MOIS3Y
@ 2023-07-04 12:33 ` MOIS3Y
  2023-10-03  1:45 ` github-actions
  2023-10-17  1:45 ` [PR PATCH] [Closed]: " github-actions
  8 siblings, 0 replies; 10+ messages in thread
From: MOIS3Y @ 2023-07-04 12:33 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 332 bytes --]

New review comment by MOIS3Y on void-packages repository

https://github.com/void-linux/void-packages/pull/44225#discussion_r1251970573

Comment:
Done too.
After the changes, I re-ran the build and check with the linter
```sh
./xbps-src pkg xidlehook
./xbps-src -a armv6l -Q pkg xidlehook
xlint srcpkgs/xidlehook/template
```

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
                   ` (6 preceding siblings ...)
  2023-07-04 12:33 ` MOIS3Y
@ 2023-10-03  1:45 ` github-actions
  2023-10-17  1:45 ` [PR PATCH] [Closed]: " github-actions
  8 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2023-10-03  1:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44225#issuecomment-1744033252

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PR PATCH] [Closed]: New package: xidlehook-0.10.0
  2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
                   ` (7 preceding siblings ...)
  2023-10-03  1:45 ` github-actions
@ 2023-10-17  1:45 ` github-actions
  8 siblings, 0 replies; 10+ messages in thread
From: github-actions @ 2023-10-17  1:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 854 bytes --]

There's a closed pull request on the void-packages repository

New package: xidlehook-0.10.0
https://github.com/void-linux/void-packages/pull/44225

Description:
This PR is an updated version of https://github.com/void-linux/void-packages/pull/27774 since the original is closed. The requested changes have also been added.
There's also an associated package request for this PR: https://github.com/void-linux/void-packages/issues/27422

#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**


#### Local build testing
- I built this PR locally for my native architecture, (x86_64)
- I built this PR locally for these architectures:
    - armv6l


^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2023-10-17  1:45 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-02 12:31 [PR PATCH] New package: xidlehook-0.10.0 MOIS3Y
2023-06-25 17:00 ` [PR REVIEW] " Duncaen
2023-06-25 17:02 ` Duncaen
2023-06-25 17:02 ` Duncaen
2023-06-25 17:02 ` Duncaen
2023-07-04 12:23 ` [PR PATCH] [Updated] " MOIS3Y
2023-07-04 12:25 ` [PR REVIEW] " MOIS3Y
2023-07-04 12:33 ` MOIS3Y
2023-10-03  1:45 ` github-actions
2023-10-17  1:45 ` [PR PATCH] [Closed]: " github-actions

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).