From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [ISSUE] [CLOSED] docker run --init must be supported not optional feature
Date: Mon, 26 Jun 2023 02:23:40 +0200 [thread overview]
Message-ID: <20230626002340.l6Qgot1bj-mUtk_wNFC9MuzKf5AJvJvk4HADDINPmec@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-44641@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
Closed issue by hholst80 on void-packages repository
https://github.com/void-linux/void-packages/issues/44641
Description:
docker-init or a similar process manager is required by docker to function properly. It is not a plugin like buildx or compose rather it's core functionality.
Example:
$ docker run --init hello-world
It is possible to solve this in at least 3 ways. Either to require an init manager and configuring docker to use that (as a virtual required pkg); introducing a hardwired dependency (to tini); or to simply ship tini-static as docker-init in the pkg.
In none of these solutions should tini include a symbolic link to docker-init. tini has no such responsibility and it has a hidden bidirectional dependency between the two packages. Complexity for no reason. I suggest we just ship a docker-init with docker and be done.
I'm happy to make a PR once we are in agreement that the correct fix is to either
1. Remove docker-init from tini
2. Include a bundled docker-init with core docker daemon package,
Or
1. (Same)
2. Require tini and symlink tini-static to docker-init OR custom configuration of dockerd.
I favor the configuration solution the least because I generally don't like the os to be opinionated on daemon config I am fiddling with myself.
next prev parent reply other threads:[~2023-06-26 0:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-25 23:25 [ISSUE] " hholst80
2023-06-25 23:57 ` classabbyamp
2023-06-26 0:23 ` ahesford [this message]
2023-06-26 0:23 ` ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230626002340.l6Qgot1bj-mUtk_wNFC9MuzKf5AJvJvk4HADDINPmec@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).