* [ISSUE] docker run --init must be supported not optional feature
@ 2023-06-25 23:25 hholst80
2023-06-25 23:57 ` classabbyamp
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: hholst80 @ 2023-06-25 23:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1278 bytes --]
New issue by hholst80 on void-packages repository
https://github.com/void-linux/void-packages/issues/44641
Description:
docker-init or a similar process manager is required by docker to function properly. It is not a plugin like buildx or compose rather it's core functionality.
Example:
$ docker run --init hello-world
It is possible to solve this in at least 3 ways. Either to require an init manager and configuring docker to use that (as a virtual required pkg); introducing a hardwired dependency (to tini); or to simply ship tini-static as docker-init in the pkg.
In none of these solutions should tini include a symbolic link to docker-init. tini has no such responsibility and it has a hidden bidirectional dependency between the two packages. Complexity for no reason. I suggest we just ship a docker-init with docker and be done.
I'm happy to make a PR once we are in agreement that the correct fix is to either
1. Remove docker-init from tini
2. Include a bundled docker-init with core docker daemon package,
Or
1. (Same)
2. Require tini and symlink tini-static to docker-init OR custom configuration of dockerd.
I favor the configuration solution the least because I generally don't like the os to be opinionated on daemon config I am fiddling with myself.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: docker run --init must be supported not optional feature
2023-06-25 23:25 [ISSUE] docker run --init must be supported not optional feature hholst80
@ 2023-06-25 23:57 ` classabbyamp
2023-06-26 0:23 ` ahesford
2023-06-26 0:23 ` [ISSUE] [CLOSED] " ahesford
2 siblings, 0 replies; 4+ messages in thread
From: classabbyamp @ 2023-06-25 23:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 228 bytes --]
New comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/issues/44641#issuecomment-1606338721
Comment:
`docker` already depends on `tini`, and that is the supported way to use docker
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: docker run --init must be supported not optional feature
2023-06-25 23:25 [ISSUE] docker run --init must be supported not optional feature hholst80
2023-06-25 23:57 ` classabbyamp
@ 2023-06-26 0:23 ` ahesford
2023-06-26 0:23 ` [ISSUE] [CLOSED] " ahesford
2 siblings, 0 replies; 4+ messages in thread
From: ahesford @ 2023-06-26 0:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 253 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/issues/44641#issuecomment-1606355076
Comment:
It's already been explained twice now that `docker` pulls in `tini`, so there is no need for further action.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [ISSUE] [CLOSED] docker run --init must be supported not optional feature
2023-06-25 23:25 [ISSUE] docker run --init must be supported not optional feature hholst80
2023-06-25 23:57 ` classabbyamp
2023-06-26 0:23 ` ahesford
@ 2023-06-26 0:23 ` ahesford
2 siblings, 0 replies; 4+ messages in thread
From: ahesford @ 2023-06-26 0:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]
Closed issue by hholst80 on void-packages repository
https://github.com/void-linux/void-packages/issues/44641
Description:
docker-init or a similar process manager is required by docker to function properly. It is not a plugin like buildx or compose rather it's core functionality.
Example:
$ docker run --init hello-world
It is possible to solve this in at least 3 ways. Either to require an init manager and configuring docker to use that (as a virtual required pkg); introducing a hardwired dependency (to tini); or to simply ship tini-static as docker-init in the pkg.
In none of these solutions should tini include a symbolic link to docker-init. tini has no such responsibility and it has a hidden bidirectional dependency between the two packages. Complexity for no reason. I suggest we just ship a docker-init with docker and be done.
I'm happy to make a PR once we are in agreement that the correct fix is to either
1. Remove docker-init from tini
2. Include a bundled docker-init with core docker daemon package,
Or
1. (Same)
2. Require tini and symlink tini-static to docker-init OR custom configuration of dockerd.
I favor the configuration solution the least because I generally don't like the os to be opinionated on daemon config I am fiddling with myself.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2023-06-26 0:23 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-06-25 23:25 [ISSUE] docker run --init must be supported not optional feature hholst80
2023-06-25 23:57 ` classabbyamp
2023-06-26 0:23 ` ahesford
2023-06-26 0:23 ` [ISSUE] [CLOSED] " ahesford
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).