[PR PATCH] spotify-player: add alsa and pulseaudio backend features

[PR PATCH] spotify-player: add alsa and pulseaudio backend features

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 553 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages spotify-player-backends
https://github.com/void-linux/void-packages/pull/44558

spotify-player: add alsa and pulseaudio backend features
fixes #44557

@0323pin please test

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**



A patch file from https://github.com/void-linux/void-packages/pull/44558.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-spotify-player-backends-44558.patch --]
[-- Type: text/x-diff, Size: 1046 bytes --]

From 9859a1d9497d425a97c890743594ec2a722f35df Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 22 Jun 2023 03:26:22 -0400
Subject: [PATCH] spotify-player: add alsa and pulseaudio backend features

fixes #44557
---
 srcpkgs/spotify-player/template | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/spotify-player/template b/srcpkgs/spotify-player/template
index 9716e81041ad..c9e74c34dd6e 100644
--- a/srcpkgs/spotify-player/template
+++ b/srcpkgs/spotify-player/template
@@ -1,11 +1,12 @@
 # Template file for 'spotify-player'
 pkgname=spotify-player
 version=0.14.0
-revision=1
+revision=2
 build_style=cargo
+configure_args="--features alsa-backend,pulseaudio-backend"
 make_install_args="--path spotify_player"
 hostmakedepends="pkg-config"
-makedepends="openssl-devel alsa-lib-devel dbus-devel"
+makedepends="openssl-devel alsa-lib-devel pulseaudio-devel dbus-devel"
 short_desc="Command driven spotify player"
 maintainer="Thang Pham <phamducthang1234@gmail.com>"
 license="MIT"

Re: spotify-player: add alsa and pulseaudio backend features

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 510 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/44558#issuecomment-1602177400

Comment:
@classabbyamp I'm having some issues installing packages built from source. `xbps-install --repository hostdir/binpkgs <package_name>` complains about the repository not being in `xbps.d`.

It's been a while I've used `xbps-src`, was there a change in behavior that hasn't been documented?

I'm sorry but, I can't test your change, I refuse to install `pulseaudio`

Re: spotify-player: add alsa and pulseaudio backend features

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 526 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/44558#issuecomment-1602177400

Comment:
@classabbyamp I'm having some issues installing packages built from source. `xbps-install --repository hostdir/binpkgs <package_name>` complains about the repository not being in `xbps.d`.

It's been a while since last time I've used `xbps-src`, was there a change in behavior that hasn't been documented?

I'm sorry but, I can't test your change, I refuse to install `pulseaudio`

Re: spotify-player: add alsa and pulseaudio backend features

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 449 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/44558#issuecomment-1602177400

Comment:
@classabbyamp I'm having some issues installing packages built from source. `xbps-install --repository hostdir/binpkgs <package_name>` complains about the repository not being in `xbps.d`.

It's been a while since last time I've used `xbps-src`, was there a change in behavior that hasn't been documented?

Re: spotify-player: add alsa and pulseaudio backend features

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 781 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/44558#issuecomment-1602447436

Comment:
@classabbyamp There was a typo on my install command, everything ok with `xbps-src`, sorry for the noise.

Still, I don't know what's wrong :(

Just built and installed with `xbps-src`
![2023-06-22-130147_1920x1080_scrot](https://github.com/void-linux/void-packages/assets/90570748/ebdd54a0-1b50-416f-8abe-c40f190ab6ff)

Built with `cargo`
![2023-06-22-130254_1920x1080_scrot](https://github.com/void-linux/void-packages/assets/90570748/a61bba14-3177-4992-ab22-e78de03a5413)


Btw, 0.14.1 was released [3 weeks ago](https://github.com/aome510/spotify-player/releases/tag/v0.14.1), you might want to bump the version as well.

Re: spotify-player: add alsa and pulseaudio backend features

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 216 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44558#issuecomment-1608924721

Comment:
sorry I don't have a spotify account so I can't really bump it myself

Re: [PR PATCH] [Closed]: spotify-player: add alsa and pulseaudio backend features

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

There's a closed pull request on the void-packages repository

spotify-player: add alsa and pulseaudio backend features
https://github.com/void-linux/void-packages/pull/44558

Description:
fixes #44557

@0323pin please test

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **NO**

Re: spotify-player: add alsa and pulseaudio backend features

[0323pin]

[-- Attachment #1: Type: text/plain, Size: 376 bytes --]

New comment by 0323pin on void-packages repository

https://github.com/void-linux/void-packages/pull/44558#issuecomment-1608974437

Comment:
@classabbyamp I had a chat with the dev and multiple backends are currently not well supported. Still, I have no clue why the default `rodio` backend doesn't work here. `rodio` uses `cpal` which in turn uses `alsa`, so it should work.