[PR PATCH] New package: mangadesk-0.7.8

[PR PATCH] New package: mangadesk-0.7.8

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 671 bytes --]

There is a new pull request by clyhtsuriva against master on the void-packages repository

https://github.com/clyhtsuriva/void-packages mangadesk-new
https://github.com/void-linux/void-packages/pull/44464

New package: mangadesk-0.7.8
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/44464.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mangadesk-new-44464.patch --]
[-- Type: text/x-diff, Size: 1094 bytes --]

From 505877f7eb292841d9e77f6418c75a9edeafe15d Mon Sep 17 00:00:00 2001
From: clyhtsuriva <aimeric@adjutor.xyz>
Date: Fri, 16 Jun 2023 13:54:57 +0200
Subject: [PATCH] New package: mangadesk-0.7.8

---
 srcpkgs/mangadesk/template | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 srcpkgs/mangadesk/template

diff --git a/srcpkgs/mangadesk/template b/srcpkgs/mangadesk/template
new file mode 100644
index 000000000000..ab236d2e5173
--- /dev/null
+++ b/srcpkgs/mangadesk/template
@@ -0,0 +1,19 @@
+# Template file for 'mangadesk'
+pkgname=mangadesk
+version=0.7.8
+revision=1
+archs="x86_64"
+build_style=go
+go_import_path=github.com/darylhjd/mangadesk
+depends="glibc-devel"
+short_desc="Terminal client for MangaDex"
+maintainer="Clyhtsuriva <void-packages@adjutor.xyz>"
+license="MIT"
+homepage="https://github.com/darylhjd/mangadesk"
+changelog="https://github.com/darylhjd/mangadesk/releases/"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=85120472113e2a98d4cd9fc731e268545facd194f6dc973e29a5b2867a8305c8
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: mangadesk-0.7.8

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44464#discussion_r1245590736

Comment:
Why is this limited to `x86_64`?

Re: [PR REVIEW] New package: mangadesk-0.7.8

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

New review comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/44464#discussion_r1248907124

Comment:
Hi, I limited it to `x86_64` to mimick what is being done on other distributions' mangadesk package.

It seems to cross build (armv7l, armv6l-musl, aarch64-musl) alright on my machine, though.
I guess I could remove the `archs` line and the `depends` line as well.

Re: [PR PATCH] [Updated] New package: mangadesk-0.7.8

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

There is an updated pull request by clyhtsuriva against master on the void-packages repository

https://github.com/clyhtsuriva/void-packages mangadesk-new
https://github.com/void-linux/void-packages/pull/44464

New package: mangadesk-0.7.8
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/44464.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mangadesk-new-44464.patch --]
[-- Type: text/x-diff, Size: 1053 bytes --]

From 4c1263f62efbf679a90196d11b6591a3421066cb Mon Sep 17 00:00:00 2001
From: clyhtsuriva <aimeric@adjutor.xyz>
Date: Fri, 16 Jun 2023 13:54:57 +0200
Subject: [PATCH] New package: mangadesk-0.7.8

---
 srcpkgs/mangadesk/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/mangadesk/template

diff --git a/srcpkgs/mangadesk/template b/srcpkgs/mangadesk/template
new file mode 100644
index 000000000000..98a1ced51ddc
--- /dev/null
+++ b/srcpkgs/mangadesk/template
@@ -0,0 +1,17 @@
+# Template file for 'mangadesk'
+pkgname=mangadesk
+version=0.7.8
+revision=1
+build_style=go
+go_import_path=github.com/darylhjd/mangadesk
+short_desc="Terminal client for MangaDex"
+maintainer="Clyhtsuriva <void-packages@adjutor.xyz>"
+license="MIT"
+homepage="https://github.com/darylhjd/mangadesk"
+changelog="https://github.com/darylhjd/mangadesk/releases/"
+distfiles="${homepage}/archive/v${version}.tar.gz"
+checksum=85120472113e2a98d4cd9fc731e268545facd194f6dc973e29a5b2867a8305c8
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: mangadesk-0.7.8

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44464#discussion_r1248908585

Comment:
yes, the depends is also wrong, it would depend on `glibc` not `glibc-devel`, but even then xbps-src detects linked shared libary dependencies on it own.

Re: [PR REVIEW] New package: mangadesk-0.7.8

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 194 bytes --]

New review comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/44464#discussion_r1248908815

Comment:
Force pushed a new commit to resolve this.

Re: New package: mangadesk-0.7.8

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 181 bytes --]

New comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/44464#issuecomment-1724412152

Comment:
Anything else to check or resolve ?

Re: [PR REVIEW] New package: mangadesk-0.7.8

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 252 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44464#discussion_r1329294620

Comment:
I would not use the homepage variable here and I would remove the trailing slash from the changelog url.

Re: [PR PATCH] [Updated] New package: mangadesk-0.7.8

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 676 bytes --]

There is an updated pull request by clyhtsuriva against master on the void-packages repository

https://github.com/clyhtsuriva/void-packages mangadesk-new
https://github.com/void-linux/void-packages/pull/44464

New package: mangadesk-0.7.8
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)


A patch file from https://github.com/void-linux/void-packages/pull/44464.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-mangadesk-new-44464.patch --]
[-- Type: text/x-diff, Size: 1080 bytes --]

From 39c9e1212d565be351de67db44686bd26a893853 Mon Sep 17 00:00:00 2001
From: clyhtsuriva <aimeric@adjutor.xyz>
Date: Tue, 19 Sep 2023 16:55:54 +0200
Subject: [PATCH] New package: mangadesk-0.7.8

---
 srcpkgs/mangadesk/template | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 srcpkgs/mangadesk/template

diff --git a/srcpkgs/mangadesk/template b/srcpkgs/mangadesk/template
new file mode 100644
index 0000000000000..2ae7f2dff5f8e
--- /dev/null
+++ b/srcpkgs/mangadesk/template
@@ -0,0 +1,17 @@
+# Template file for 'mangadesk'
+pkgname=mangadesk
+version=0.7.8
+revision=1
+build_style=go
+go_import_path=github.com/darylhjd/mangadesk
+short_desc="Terminal client for MangaDex"
+maintainer="Clyhtsuriva <void-packages@adjutor.xyz>"
+license="MIT"
+homepage="https://github.com/darylhjd/mangadesk"
+changelog="https://github.com/darylhjd/mangadesk/releases"
+distfiles="https://github.com/darylhjd/mangadesk/archive/v${version}.tar.gz"
+checksum=85120472113e2a98d4cd9fc731e268545facd194f6dc973e29a5b2867a8305c8
+
+post_install() {
+	vlicense LICENSE
+}

Re: [PR REVIEW] New package: mangadesk-0.7.8

[clyhtsuriva]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New review comment by clyhtsuriva on void-packages repository

https://github.com/void-linux/void-packages/pull/44464#discussion_r1330273830

Comment:
Resolved with the latest commit

Re: [PR PATCH] [Merged]: New package: mangadesk-0.7.8

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 506 bytes --]

There's a merged pull request on the void-packages repository

New package: mangadesk-0.7.8
https://github.com/void-linux/void-packages/pull/44464

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)