[PR PATCH] shake: fix build on musl

[PR PATCH] shake: fix build on musl

[hazen2215]

[-- Attachment #1: Type: text/plain, Size: 1080 bytes --]

There is a new pull request by hazen2215 against master on the void-packages repository

https://github.com/hazen2215/void-packages shake
https://github.com/void-linux/void-packages/pull/44674

shake: fix build on musl
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)


A patch file from https://github.com/void-linux/void-packages/pull/44674.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-shake-44674.patch --]
[-- Type: text/x-diff, Size: 932 bytes --]

From 88b1da3a47aeb4502a3115bc542cac2dd8d031c9 Mon Sep 17 00:00:00 2001
From: hazen2215 <haz@disroot.org>
Date: Wed, 28 Jun 2023 12:38:56 +0900
Subject: [PATCH] shake: fix build on musl

---
 srcpkgs/shake/template | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/srcpkgs/shake/template b/srcpkgs/shake/template
index 08790572f3c4..eccaccd75649 100644
--- a/srcpkgs/shake/template
+++ b/srcpkgs/shake/template
@@ -12,11 +12,11 @@ homepage="http://vleu.net/shake/"
 distfiles="https://github.com/unbrice/$pkgname/archive/v$version.tar.gz"
 checksum=ac5a57bd8d55e197734852bf66318ecf39b4c5c298e43a259ba1d8a4b7a2ced3
 
-case "$XBPS_TARGET_MACHINE" in
-*-musl)
-	broken="musl does not provide error.h required by this package"
-	;;
-esac
+CFLAGS="-D_GNU_SOURCE"
+
+if [ "$XBPS_TARGET_LIBC" = musl ]; then
+	makedepends+=" musl-legacy-compat"
+fi
 
 if [ -n "$CROSS_BUILD" ]; then
 	hostmakedepends+=" shake"

Re: [PR REVIEW] shake: fix build on musl

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 238 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/44674#discussion_r1245349426

Comment:
Is this line necessary? The build seems to complain a lot about redefining `_GNU_SOURCE`.

Re: [PR PATCH] [Closed]: shake: fix build on musl

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 927 bytes --]

There's a closed pull request on the void-packages repository

shake: fix build on musl
https://github.com/void-linux/void-packages/pull/44674

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)