* Re: yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
@ 2023-05-30 22:48 ` paper42
2023-05-31 0:39 ` dkwo
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: paper42 @ 2023-05-30 22:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 281 bytes --]
New comment by paper42 on void-packages repository
https://github.com/void-linux/void-packages/pull/44185#issuecomment-1569232746
Comment:
What exactly does this achieve? I don't see any failing tests right now without these dependencies. We don't use pip3 check, we use pytest.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
2023-05-30 22:48 ` paper42
@ 2023-05-31 0:39 ` dkwo
2023-05-31 2:30 ` sgn
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: dkwo @ 2023-05-31 0:39 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 242 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/44185#issuecomment-1569325642
Comment:
they may be not covered by tests, but see https://github.com/yt-dlp/yt-dlp/blob/master/requirements.txt
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
2023-05-30 22:48 ` paper42
2023-05-31 0:39 ` dkwo
@ 2023-05-31 2:30 ` sgn
2023-05-31 5:55 ` icp1994
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: sgn @ 2023-05-31 2:30 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 249 bytes --]
New comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/44185#issuecomment-1569407262
Comment:
IMO, Either we should add those dependency, or we need to modify requirements.txt to remove those requirements.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
` (2 preceding siblings ...)
2023-05-31 2:30 ` sgn
@ 2023-05-31 5:55 ` icp1994
2023-06-28 21:11 ` [PR PATCH] [Updated] " dkwo
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: icp1994 @ 2023-05-31 5:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 261 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/44185#issuecomment-1569539615
Comment:
related: https://github.com/void-linux/void-packages/pull/42661
upstream: https://github.com/yt-dlp/yt-dlp/issues/6484
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
` (3 preceding siblings ...)
2023-05-31 5:55 ` icp1994
@ 2023-06-28 21:11 ` dkwo
2023-09-12 17:18 ` dkwo
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: dkwo @ 2023-06-28 21:11 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages yt
https://github.com/void-linux/void-packages/pull/44185
yt-dlp: add depends from pip3 check
from running `pip3 check` on my system
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)
cc maintainer @paper42
A patch file from https://github.com/void-linux/void-packages/pull/44185.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-yt-44185.patch --]
[-- Type: text/x-diff, Size: 1354 bytes --]
From 06969de893b8b0142ed0baca07034be8b23fd82c Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 30 May 2023 17:58:13 -0400
Subject: [PATCH] yt-dlp: add depends from pip3 check
---
srcpkgs/yt-dlp/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/yt-dlp/template b/srcpkgs/yt-dlp/template
index fbad7395bf14..74b912ff72cf 100644
--- a/srcpkgs/yt-dlp/template
+++ b/srcpkgs/yt-dlp/template
@@ -1,16 +1,17 @@
# Template file for 'yt-dlp'
pkgname=yt-dlp
version=2023.06.22
-revision=1
+revision=2
build_style=python3-module
make_check_args="-k not(download)"
hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3 python3-Brotli python3-certifi python3-mutagen
+ python3-pycryptodomex python3-websockets"
checkdepends="python3-pytest-xdist"
short_desc="CLI program to download videos from YouTube and other sites"
maintainer="Michal Vasilek <michal@vasilek.cz>"
license="Unlicense"
homepage="https://github.com/yt-dlp/yt-dlp"
changelog="https://raw.githubusercontent.com/yt-dlp/yt-dlp/master/Changelog.md"
-distfiles="https://github.com/yt-dlp/yt-dlp/releases/download/$version/yt-dlp.tar.gz"
+distfiles="https://github.com/yt-dlp/yt-dlp/releases/download/${version}/yt-dlp.tar.gz"
checksum=5291eb8e077ee1bc2585f4f522d75f1e4f9fd4c3374bace1572cf59b97bdd9c3
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
` (4 preceding siblings ...)
2023-06-28 21:11 ` [PR PATCH] [Updated] " dkwo
@ 2023-09-12 17:18 ` dkwo
2023-09-12 17:20 ` [PR PATCH] [Updated] " dkwo
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: dkwo @ 2023-09-12 17:18 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 338 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/44185#issuecomment-1716131604
Comment:
According to upstream (linked): "Unless there is reason to, it is recommended to install the dependencies too" and "we want default installs (from pip or source) to have these dependencies included".
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
` (5 preceding siblings ...)
2023-09-12 17:18 ` dkwo
@ 2023-09-12 17:20 ` dkwo
2023-10-17 16:09 ` dkwo
2023-10-17 16:09 ` [PR PATCH] [Closed]: " dkwo
8 siblings, 0 replies; 10+ messages in thread
From: dkwo @ 2023-09-12 17:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 490 bytes --]
There is an updated pull request by dkwo against master on the void-packages repository
https://github.com/dkwo/void-packages yt
https://github.com/void-linux/void-packages/pull/44185
yt-dlp: add depends from pip3 check
from running `pip3 check` on my system
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)
cc maintainer @paper42
A patch file from https://github.com/void-linux/void-packages/pull/44185.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-yt-44185.patch --]
[-- Type: text/x-diff, Size: 1356 bytes --]
From 1df7c03a904e2b5d7d1661c6e022ce83d721323c Mon Sep 17 00:00:00 2001
From: dkwo <nicolopiazzalunga@gmail.com>
Date: Tue, 30 May 2023 17:58:13 -0400
Subject: [PATCH] yt-dlp: add depends from pip3 check
---
srcpkgs/yt-dlp/template | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/yt-dlp/template b/srcpkgs/yt-dlp/template
index e98badbb0a3ea..4d45f706db343 100644
--- a/srcpkgs/yt-dlp/template
+++ b/srcpkgs/yt-dlp/template
@@ -1,16 +1,17 @@
# Template file for 'yt-dlp'
pkgname=yt-dlp
version=2023.07.06
-revision=1
+revision=2
build_style=python3-module
make_check_args="-k not(download)"
hostmakedepends="python3-setuptools"
-depends="python3"
+depends="python3 python3-Brotli python3-certifi python3-mutagen
+ python3-pycryptodomex python3-websockets"
checkdepends="python3-pytest-xdist"
short_desc="CLI program to download videos from YouTube and other sites"
maintainer="Michal Vasilek <michal@vasilek.cz>"
license="Unlicense"
homepage="https://github.com/yt-dlp/yt-dlp"
changelog="https://raw.githubusercontent.com/yt-dlp/yt-dlp/master/Changelog.md"
-distfiles="https://github.com/yt-dlp/yt-dlp/releases/download/$version/yt-dlp.tar.gz"
+distfiles="https://github.com/yt-dlp/yt-dlp/releases/download/${version}/yt-dlp.tar.gz"
checksum=6d2115b84b6c11867f92cf4c23705b536bfa0ba9d538b1885f52da6756f8c980
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
` (6 preceding siblings ...)
2023-09-12 17:20 ` [PR PATCH] [Updated] " dkwo
@ 2023-10-17 16:09 ` dkwo
2023-10-17 16:09 ` [PR PATCH] [Closed]: " dkwo
8 siblings, 0 replies; 10+ messages in thread
From: dkwo @ 2023-10-17 16:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 158 bytes --]
New comment by dkwo on void-packages repository
https://github.com/void-linux/void-packages/pull/44185#issuecomment-1766733609
Comment:
time to close this.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Closed]: yt-dlp: add depends from pip3 check
2023-05-30 21:59 [PR PATCH] yt-dlp: add depends from pip3 check dkwo
` (7 preceding siblings ...)
2023-10-17 16:09 ` dkwo
@ 2023-10-17 16:09 ` dkwo
8 siblings, 0 replies; 10+ messages in thread
From: dkwo @ 2023-10-17 16:09 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 345 bytes --]
There's a closed pull request on the void-packages repository
yt-dlp: add depends from pip3 check
https://github.com/void-linux/void-packages/pull/44185
Description:
from running `pip3 check` on my system
- I tested the changes in this PR: yes
- I built this PR locally for my native architecture, (x86_64-musl)
cc maintainer @paper42
^ permalink raw reply [flat|nested] 10+ messages in thread