[PR PATCH] incidenceeditor: update to 23.04.2

[PR PATCH] incidenceeditor: update to 23.04.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 600 bytes --]

There is a new pull request by chrysos349 against master on the void-packages repository

https://github.com/chrysos349/void-packages incidenceeditor
https://github.com/void-linux/void-packages/pull/44712

incidenceeditor: update to 23.04.2
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64

A patch file from https://github.com/void-linux/void-packages/pull/44712.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-incidenceeditor-44712.patch --]
[-- Type: text/x-diff, Size: 1148 bytes --]

From c2c12be55785f5be9b9f75cbe71c274a2d704f54 Mon Sep 17 00:00:00 2001
From: chrysos349 <chrysostom349@gmail.com>
Date: Thu, 29 Jun 2023 13:18:26 +0300
Subject: [PATCH] incidenceeditor: update to 23.04.2

---
 srcpkgs/incidenceeditor/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/incidenceeditor/template b/srcpkgs/incidenceeditor/template
index d5d32ad243ef..06e921f6c36e 100644
--- a/srcpkgs/incidenceeditor/template
+++ b/srcpkgs/incidenceeditor/template
@@ -1,6 +1,6 @@
 # Template file for 'incidenceeditor'
 pkgname=incidenceeditor
-version=23.04.0
+version=23.04.2
 revision=1
 build_style=cmake
 hostmakedepends="extra-cmake-modules qt5-qmake qt5-host-tools kcoreaddons kconfig
@@ -11,7 +11,7 @@ maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-2.0-or-later"
 homepage="https://community.kde.org/KDE_PIM"
 distfiles="${KDE_SITE}/release-service/${version}/src/${pkgname}-${version}.tar.xz"
-checksum=9111a162e409b162ca5dc2811fca552e0cf5342101377d65bd851a94bd010c48
+checksum=b303bfafc5c470c34aecebe12c282653d459d4bf7c9e23c122ac51983f67a2cd
 
 do_check() {
 	# failing tests are disabled

Re: incidenceeditor: update to 23.04.2

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 428 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/44712#issuecomment-1612816647

Comment:

> - I tested the changes in this PR: **briefly**
> 
> #### Local build testing
> - I built this PR locally for my native architecture, (x86_64-LIBC)
> - I built this PR locally for these architectures (if supported. mark crossbuilds):
>   - aarch64

what did you do to test it? 

Re: incidenceeditor: update to 23.04.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44712#issuecomment-1612823072

Comment:
@classabbyamp I launched the executable file `/usr/bin/kincidenceeditor`.

Re: incidenceeditor: update to 23.04.2

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 211 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/44712#issuecomment-1613078284

Comment:
Clearly you aren't testing these. Stop making submissions like this.

Re: [PR PATCH] [Closed]: incidenceeditor: update to 23.04.2

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 435 bytes --]

There's a closed pull request on the void-packages repository

incidenceeditor: update to 23.04.2
https://github.com/void-linux/void-packages/pull/44712

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64

Re: incidenceeditor: update to 23.04.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 812 bytes --]

New comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44712#issuecomment-1613667837

Comment:
@ahesford Clearly you're wrong. I tested #44710, #44713, #44714, #44715, #44716 for a bit. I launched[^1] all of them, and used them briefly. I admit i don' know how to properly test #44712, #44711. 

All of those are minor releases without any breaking changes in the functionality, etc. What else do i need to do to test them?

There's hardly any information in the manual about how to test different types of packages - apps, libs, python modules, etc. Could you give me any advice?

[^1]: There is this line in CONTRIBUTING.md: "Also, new packages and updates will not be accepted unless they have been runtime tested by installing and running the package."

Re: incidenceeditor: update to 23.04.2

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 344 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/44712#issuecomment-1613701597

Comment:
The first step in testing the package is successfully building it. CI builds of your submission failed for every architecture against which we test. How did this build successfullly for you to test it?

Re: incidenceeditor: update to 23.04.2

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 1089 bytes --]

New comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/44712#issuecomment-1613820598

Comment:
@ahesford I know. Thanks for stating the obvious.

I build the packages for my own arch and aarch64. Here are the build logs and a check log.
[incidenceeditor-x86_64.txt](https://github.com/void-linux/void-packages/files/11910514/incidenceeditor-x86_64.txt)
[incidenceeditor-aarch64.txt](https://github.com/void-linux/void-packages/files/11910516/incidenceeditor-aarch64.txt)
[incidenceeditor-check.txt](https://github.com/void-linux/void-packages/files/11910517/incidenceeditor-check.txt)

Do I need to attach the built packages as well?

> How did this build successfully for you to test it?

See the logs above, and you tell me.

>There's hardly any information in the manual about how to test different types of packages - apps, libs, python modules, etc. Could you give me any advice?

Any comments?

P.S. What's your reasoning behind closing my other submissions? They passed the checks. I tested them briefly. What else?

Re: incidenceeditor: update to 23.04.2

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 536 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/44712#issuecomment-1613868230

Comment:
If we were interested in untested or trivially tested updates, we'd employ a bot to do the task.

Your other update PRs were closed because the rapid-fire nature of shoddy or poorly tested submissions has eroded your credibility. Please limit your contributions in the future to updates that you've spent some time using and can comment on with greater depth than "I launched an executable."

Re: incidenceeditor: update to 23.04.2

[sgn]

[-- Attachment #1: Type: text/plain, Size: 228 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/44712#issuecomment-1614017292

Comment:
Those packages needs to be built together. KDE requires all packages has the same version.