[PR PATCH] zlib: fix update-check

[PR PATCH] zlib: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 1227 bytes --]

There is a new pull request by Bnyro against master on the void-packages repository

https://github.com/Bnyro/void-packages zlib
https://github.com/void-linux/void-packages/pull/44760

zlib: fix update-check
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44760.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-zlib-44760.patch --]
[-- Type: text/x-diff, Size: 484 bytes --]

From f6e98e412c0788a8b3dc182f1a786d1347c3adb7 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Sat, 1 Jul 2023 16:12:15 +0200
Subject: [PATCH] zlib: fix update-check

---
 srcpkgs/zlib/update | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/zlib/update b/srcpkgs/zlib/update
index c96efe7b1c38..dfef0ea1c954 100644
--- a/srcpkgs/zlib/update
+++ b/srcpkgs/zlib/update
@@ -1 +1 @@
-pattern="<B> zlib \K.+?(?=</B>)"
+pattern="<B> zlib \K[\d.]+"

Re: zlib: fix update-check

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 183 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/44760#issuecomment-1616110170

Comment:
old pattern just works, why the change?

Re: zlib: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 197 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44760#issuecomment-1616111523

Comment:
It doesn't work, it outputs there word be a 1213 release.

Re: zlib: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44760#issuecomment-1616111723

Comment:
Because it doesn't handle dots properly.

Re: zlib: fix update-check

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 397 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/44760#issuecomment-1616112338

Comment:
?

```
./xbps-src update-check zlib      
using zlib/update overrides
fetching https://www.zlib.net and scanning with <B> zlib \K.+?(?=</B>)
fetching https://www.zlib.net/fossils/ and scanning with <B> zlib \K.+?(?=</B>)
found version 1.2.13
```

Re: zlib: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 436 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44760#issuecomment-1616433398

Comment:
Oh, I just noticed the issue is when checking for updates for `zlib-32bit`, `zlib` itself works properly:
```
$ ./xbps-src update-check zlib-32bit
zlib-1.2.13 -> zlib-1213
```
But I don't really have a clue why it works properly for zlib in the meanwhile, don't they use the same template?

Re: zlib: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 543 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44760#issuecomment-1616433398

Comment:
Oh, I just noticed the issue is when checking for updates for `zlib-32bit`, `zlib` itself works properly:
```
$ ./xbps-src update-check zlib-32bit
zlib-1.2.13 -> zlib-1213
```
But I don't really have a clue why it works properly for zlib in the meanwhile, don't they use the same template?

The changes in this PR don't have an impact on that, still claims to have a new 1213 release available.

Re: [PR PATCH] [Closed]: zlib: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

There's a closed pull request on the void-packages repository

zlib: fix update-check
https://github.com/void-linux/void-packages/pull/44760

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

Re: zlib: fix update-check

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 359 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/44760#issuecomment-1618807476

Comment:
update-check on `-32bit` packages is not an useful operation, as they are made from plain i686 build.
Going to details, this didn't work because xbps-src tries to read non-existent `srcpkgs/zlib-32bit/update` here.

Re: zlib: fix update-check

[Bnyro]

[-- Attachment #1: Type: text/plain, Size: 160 bytes --]

New comment by Bnyro on void-packages repository

https://github.com/void-linux/void-packages/pull/44760#issuecomment-1618813024

Comment:
Makes sense, thanks!