Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] phpMyAdmin: update to version 5.2.1
@ 2023-07-09 13:55 MeganerdNL
  2023-07-09 18:46 ` [PR PATCH] [Updated] " MeganerdNL
                   ` (27 more replies)
  0 siblings, 28 replies; 29+ messages in thread
From: MeganerdNL @ 2023-07-09 13:55 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

There is a new pull request by MeganerdNL against master on the void-packages repository

https://github.com/MeganerdNL/void-packages phpMyAdmin-5.2.1
https://github.com/void-linux/void-packages/pull/44946

phpMyAdmin: update to version 5.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
   - armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/44946.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-phpMyAdmin-5.2.1-44946.patch --]
[-- Type: text/x-diff, Size: 1173 bytes --]

From 7c6c80804ca816414a349dacf7360e9c79e09df4 Mon Sep 17 00:00:00 2001
From: MeganerdNL <meganerd@meganerd.nl>
Date: Sun, 9 Jul 2023 15:49:48 +0200
Subject: [PATCH] phpMyAdmin: update to version 5.2.1

---
 srcpkgs/phpMyAdmin/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/phpMyAdmin/template b/srcpkgs/phpMyAdmin/template
index 7f0b5f024df5..7b3f4a183f58 100644
--- a/srcpkgs/phpMyAdmin/template
+++ b/srcpkgs/phpMyAdmin/template
@@ -1,15 +1,15 @@
 # Template file for 'phpMyAdmin'
 pkgname=phpMyAdmin
-version=5.2.0
-revision=2
+version=5.2.1
+revision=1
 conf_files="/etc/webapps/phpMyAdmin/config.inc.php"
-depends="php8.1 mariadb"
+depends="php8.2 mariadb"
 short_desc="Web interface for MySQL and MariaDB"
 maintainer="Joel Beckmeyer <joel@beckmeyer.us>"
 license="GPL-2.0-only"
 homepage="https://www.phpmyadmin.net"
 distfiles="https://files.phpmyadmin.net/phpMyAdmin/${version}/phpMyAdmin-${version}-all-languages.tar.xz"
-checksum=66da31ca295f06182ac3f2e6e96057dc824c459baedf4b29de6ed0d3be039230
+checksum=373f9599dfbd96d6fe75316d5dad189e68c305f297edf42377db9dd6b41b2557
 
 do_install() {
 	vmkdir usr/share/webapps/

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PR PATCH] [Updated] phpMyAdmin: update to version 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
@ 2023-07-09 18:46 ` MeganerdNL
  2023-07-09 18:49 ` phpMyAdmin: update to 5.2.1 MeganerdNL
                   ` (26 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-07-09 18:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 576 bytes --]

There is an updated pull request by MeganerdNL against master on the void-packages repository

https://github.com/MeganerdNL/void-packages phpMyAdmin-5.2.1
https://github.com/void-linux/void-packages/pull/44946

phpMyAdmin: update to version 5.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
- I built this PR locally for these architectures:
   - armv6l-musl

A patch file from https://github.com/void-linux/void-packages/pull/44946.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-phpMyAdmin-5.2.1-44946.patch --]
[-- Type: text/x-diff, Size: 1165 bytes --]

From 0f3a816b519ee54440c84008dd83fe53f2e51454 Mon Sep 17 00:00:00 2001
From: MeganerdNL <meganerd@meganerd.nl>
Date: Sun, 9 Jul 2023 15:49:48 +0200
Subject: [PATCH] phpMyAdmin: update to 5.2.1

---
 srcpkgs/phpMyAdmin/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/phpMyAdmin/template b/srcpkgs/phpMyAdmin/template
index 7f0b5f024df5..7b3f4a183f58 100644
--- a/srcpkgs/phpMyAdmin/template
+++ b/srcpkgs/phpMyAdmin/template
@@ -1,15 +1,15 @@
 # Template file for 'phpMyAdmin'
 pkgname=phpMyAdmin
-version=5.2.0
-revision=2
+version=5.2.1
+revision=1
 conf_files="/etc/webapps/phpMyAdmin/config.inc.php"
-depends="php8.1 mariadb"
+depends="php8.2 mariadb"
 short_desc="Web interface for MySQL and MariaDB"
 maintainer="Joel Beckmeyer <joel@beckmeyer.us>"
 license="GPL-2.0-only"
 homepage="https://www.phpmyadmin.net"
 distfiles="https://files.phpmyadmin.net/phpMyAdmin/${version}/phpMyAdmin-${version}-all-languages.tar.xz"
-checksum=66da31ca295f06182ac3f2e6e96057dc824c459baedf4b29de6ed0d3be039230
+checksum=373f9599dfbd96d6fe75316d5dad189e68c305f297edf42377db9dd6b41b2557
 
 do_install() {
 	vmkdir usr/share/webapps/

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
  2023-07-09 18:46 ` [PR PATCH] [Updated] " MeganerdNL
@ 2023-07-09 18:49 ` MeganerdNL
  2023-07-23 19:22 ` [PR PATCH] [Updated] " MeganerdNL
                   ` (25 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-07-09 18:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 190 bytes --]

New comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1627794398

Comment:
Corrected commit message (removed "version").

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PR PATCH] [Updated] phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
  2023-07-09 18:46 ` [PR PATCH] [Updated] " MeganerdNL
  2023-07-09 18:49 ` phpMyAdmin: update to 5.2.1 MeganerdNL
@ 2023-07-23 19:22 ` MeganerdNL
  2023-07-29  8:42 ` MeganerdNL
                   ` (24 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-07-23 19:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There is an updated pull request by MeganerdNL against master on the void-packages repository

https://github.com/MeganerdNL/void-packages phpMyAdmin-5.2.1
https://github.com/void-linux/void-packages/pull/44946

phpMyAdmin: update to 5.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/44946.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-phpMyAdmin-5.2.1-44946.patch --]
[-- Type: text/x-diff, Size: 1167 bytes --]

From 763e78743b0e1731c408425f6f94e4a9c7f3211e Mon Sep 17 00:00:00 2001
From: MeganerdNL <meganerd@meganerd.nl>
Date: Sun, 9 Jul 2023 15:49:48 +0200
Subject: [PATCH] phpMyAdmin: update to 5.2.1

---
 srcpkgs/phpMyAdmin/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/phpMyAdmin/template b/srcpkgs/phpMyAdmin/template
index 7f0b5f024df54..7b3f4a183f587 100644
--- a/srcpkgs/phpMyAdmin/template
+++ b/srcpkgs/phpMyAdmin/template
@@ -1,15 +1,15 @@
 # Template file for 'phpMyAdmin'
 pkgname=phpMyAdmin
-version=5.2.0
-revision=2
+version=5.2.1
+revision=1
 conf_files="/etc/webapps/phpMyAdmin/config.inc.php"
-depends="php8.1 mariadb"
+depends="php8.2 mariadb"
 short_desc="Web interface for MySQL and MariaDB"
 maintainer="Joel Beckmeyer <joel@beckmeyer.us>"
 license="GPL-2.0-only"
 homepage="https://www.phpmyadmin.net"
 distfiles="https://files.phpmyadmin.net/phpMyAdmin/${version}/phpMyAdmin-${version}-all-languages.tar.xz"
-checksum=66da31ca295f06182ac3f2e6e96057dc824c459baedf4b29de6ed0d3be039230
+checksum=373f9599dfbd96d6fe75316d5dad189e68c305f297edf42377db9dd6b41b2557
 
 do_install() {
 	vmkdir usr/share/webapps/

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (2 preceding siblings ...)
  2023-07-23 19:22 ` [PR PATCH] [Updated] " MeganerdNL
@ 2023-07-29  8:42 ` MeganerdNL
  2023-08-04 15:02 ` TinfoilSubmarine
                   ` (23 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-07-29  8:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 192 bytes --]

New comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1656626332

Comment:
cc @TinfoilSubmarine: did you see this? Thanks.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (3 preceding siblings ...)
  2023-07-29  8:42 ` MeganerdNL
@ 2023-08-04 15:02 ` TinfoilSubmarine
  2023-08-04 15:52 ` MeganerdNL
                   ` (22 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: TinfoilSubmarine @ 2023-08-04 15:02 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 234 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1665753930

Comment:
Why the change from php8.1 to 8.2? Did the minimum php version requirements change?

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (4 preceding siblings ...)
  2023-08-04 15:02 ` TinfoilSubmarine
@ 2023-08-04 15:52 ` MeganerdNL
  2023-08-04 21:49 ` williamdes
                   ` (21 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-08-04 15:52 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 668 bytes --]

New comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1665838661

Comment:
> Why the change from php8.1 to 8.2? Did the minimum php version requirements change?

No the minimum is **7.1.3** (https://docs.phpmyadmin.net/en/latest/require.html).
But the standard PHP version installed with Void is 8.2 (if you install with **_xbps-install php_** without version - https://voidlinux.org/packages/?arch=x86_64&q=php

Leaving this to 8.1 installs 8.1 _besides_ 8.2 when people installed the default php.
That is imho 1 config file more to maintain.
I'd be happy to change it back if you insist...

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (5 preceding siblings ...)
  2023-08-04 15:52 ` MeganerdNL
@ 2023-08-04 21:49 ` williamdes
  2023-08-07 12:37 ` TinfoilSubmarine
                   ` (20 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: williamdes @ 2023-08-04 21:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 275 bytes --]

New comment by williamdes on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1666212836

Comment:
> Why the change from php8.1 to 8.2? Did the minimum php version requirements change?

8.2 works fine for 5.2.1. No need for 8.1

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (6 preceding siblings ...)
  2023-08-04 21:49 ` williamdes
@ 2023-08-07 12:37 ` TinfoilSubmarine
  2023-08-07 13:12 ` williamdes
                   ` (19 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: TinfoilSubmarine @ 2023-08-07 12:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1332 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1667778612

Comment:
> > Why the change from php8.1 to 8.2? Did the minimum php version requirements change?
> 
> No the minimum is **7.1.3** (https://docs.phpmyadmin.net/en/latest/require.html). But the standard PHP version installed with Void is 8.2 (if you install with **_xbps-install php_** without version - https://voidlinux.org/packages/?arch=x86_64&q=php
> 
> Leaving this to 8.1 installs 8.1 _besides_ 8.2 when people installed the default php. That is imho 1 config file more to maintain. I'd be happy to change it back if you insist...

Just to note: the void-docs [advise against installing the `php` package(s) for non-development purposes](https://docs.voidlinux.org/config/php.html). 

As I'm thinking about it, I don't really understand why we depend on php at all, since the user will have to install the php-fpm, php-apache, or php-cgi for that specific version as well. So all this does is pull in a php that the user may or may not end up using if they installed php8.0 or php8.2 instead. This situation is similar in some ways to postgresql and IIRC is why packages don't generally depend on postgresql and leave it as a task to the user to manually install and configure.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (7 preceding siblings ...)
  2023-08-07 12:37 ` TinfoilSubmarine
@ 2023-08-07 13:12 ` williamdes
  2023-08-07 13:22 ` TinfoilSubmarine
                   ` (18 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: williamdes @ 2023-08-07 13:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 840 bytes --]

New comment by williamdes on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1667833972

Comment:
> This situation is similar in some ways to postgresql and IIRC is why packages don't generally depend on postgresql and leave it as a task to the user to manually install and configure.

Just to clear things up phpMyAdmin is not a database, so I assume you are referring to pgAdmin ?

> As I'm thinking about it, I don't really understand why we depend on php at all, since the user will have to install the php-fpm, php-apache, or php-cgi for that specific version as well. 

At Debian we do `Recommends: libapache2-mod-php | lighttpd | nginx | php-fpm | httpd`
And `Depends: ... php-cli ...`
See: https://salsa.debian.org/phpmyadmin-team/phpmyadmin/-/blob/debian/latest/debian/control

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (8 preceding siblings ...)
  2023-08-07 13:12 ` williamdes
@ 2023-08-07 13:22 ` TinfoilSubmarine
  2023-08-07 13:38 ` williamdes
                   ` (17 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: TinfoilSubmarine @ 2023-08-07 13:22 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1256 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1667849949

Comment:
> > This situation is similar in some ways to postgresql and IIRC is why packages don't generally depend on postgresql and leave it as a task to the user to manually install and configure.
> 
> Just to clear things up phpMyAdmin is not a database, so I assume you are referring to pgAdmin ?

Sorry, this was probably confusing. I was referring to the packaging situation where a package needs to depend on a package like postgresql or php where multiple versions are available in repo. Void/xbps doesn't have a mechanism for depending on a package without caring what version it is.

> 
> > As I'm thinking about it, I don't really understand why we depend on php at all, since the user will have to install the php-fpm, php-apache, or php-cgi for that specific version as well.
> 
> At Debian we do `Recommends: libapache2-mod-php | lighttpd | nginx | php-fpm | httpd` And `Depends: ... php-cli ...` See: https://salsa.debian.org/phpmyadmin-team/phpmyadmin/-/blob/debian/latest/debian/control

This makes sense, but Void/xpbs doesn't have anything like reccomends or optional-dependencies.



^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (9 preceding siblings ...)
  2023-08-07 13:22 ` TinfoilSubmarine
@ 2023-08-07 13:38 ` williamdes
  2023-08-08  2:18 ` TinfoilSubmarine
                   ` (16 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: williamdes @ 2023-08-07 13:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 488 bytes --]

New comment by williamdes on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1667878178

Comment:
> Sorry, this was probably confusing. I was referring to the packaging situation where a package needs to depend on a package like postgresql or php where multiple versions are available in repo. Void/xbps doesn't have a mechanism for depending on a package without caring what version it is.

It's probably right to depend on php8.2 then :)

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (10 preceding siblings ...)
  2023-08-07 13:38 ` williamdes
@ 2023-08-08  2:18 ` TinfoilSubmarine
  2023-08-08  5:53 ` MeganerdNL
                   ` (15 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: TinfoilSubmarine @ 2023-08-08  2:18 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 956 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1668810002

Comment:
Idk, this one is tricky. I'm leaning towards the side of *if we don't know what the user wants, we shouldn't force a specific version on them.* There could be a scenario where someone already has a php8.0 install on their machine for other php apps and would like to use that for phpMyAdmin as well. Obviously, nothing is stopping them from still using it, but it does pull in an unnecessary/unused dependency. The main sticking point is that the dependency on any php is not doing anything for the user since they still have to install additional packages (php-cgi, php-fpm, php-apache, etc.) to complete the configuration.

I think it's going to be confusing either way for the user, so perhaps we should
(1) drop the dependency on php and
(2) document this, either in void-docs or an `INSTALL.msg`.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (11 preceding siblings ...)
  2023-08-08  2:18 ` TinfoilSubmarine
@ 2023-08-08  5:53 ` MeganerdNL
  2023-08-08  5:54 ` MeganerdNL
                   ` (14 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-08-08  5:53 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 444 bytes --]

New comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1668950838

Comment:
Why not:

`depends=">php7.1.3 mariadb"`

or maybe:

`depends="php mariadb"`

When no version is given version is set to >=0 according to the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional_vars) and not to the same as when _installing_ it without version.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (12 preceding siblings ...)
  2023-08-08  5:53 ` MeganerdNL
@ 2023-08-08  5:54 ` MeganerdNL
  2023-08-08  7:30 ` MeganerdNL
                   ` (13 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-08-08  5:54 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1668950838

Comment:
Why not:

`depends=">php7.1.3 mariadb"`

or maybe:

`depends="php mariadb"`

When no version is given version is set to `>=0` according to the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional_vars) and not to the same as when _installing_ it without version.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (13 preceding siblings ...)
  2023-08-08  5:54 ` MeganerdNL
@ 2023-08-08  7:30 ` MeganerdNL
  2023-08-08  8:42 ` williamdes
                   ` (12 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-08-08  7:30 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 445 bytes --]

New comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1668950838

Comment:
Why not:

`depends=">php7.1.3 mariadb"`

or maybe:

`depends="php mariadb"`

When no version is given version is set to `>=0` according to the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional_vars) and _not_ the same as when _installing_ it without version.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (14 preceding siblings ...)
  2023-08-08  7:30 ` MeganerdNL
@ 2023-08-08  8:42 ` williamdes
  2023-08-08  8:42 ` williamdes
                   ` (11 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: williamdes @ 2023-08-08  8:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

New comment by williamdes on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1669181521

Comment:
> Why not:
> 
> `depends=">php7.1.3 mariadb"`
> 
> or maybe:
> 
> `depends="php mariadb"`
> 
> When no version is given version is set to `>=0` according to the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional_vars) and _not_ the same as when _installing_ it without version.

Let me add one more case, you should suggest MariaDB not force to install it. People can often? have remove databases, and having one run for nothing is way worse.

Having depends on php and not forcing any version looks good to me 

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (15 preceding siblings ...)
  2023-08-08  8:42 ` williamdes
@ 2023-08-08  8:42 ` williamdes
  2023-08-08 12:47 ` TinfoilSubmarine
                   ` (10 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: williamdes @ 2023-08-08  8:42 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 701 bytes --]

New comment by williamdes on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1669181521

Comment:
> Why not:
> 
> `depends=">php7.1.3 mariadb"`
> 
> or maybe:
> 
> `depends="php mariadb"`
> 
> When no version is given version is set to `>=0` according to the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional_vars) and _not_ the same as when _installing_ it without version.

Let me add one more case, you should suggest MariaDB not force to install it. People can often? have remote databases, and having one run for nothing is way worse.

Having depends on php and not forcing any version looks good to me 

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (16 preceding siblings ...)
  2023-08-08  8:42 ` williamdes
@ 2023-08-08 12:47 ` TinfoilSubmarine
  2023-08-08 12:49 ` TinfoilSubmarine
                   ` (9 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: TinfoilSubmarine @ 2023-08-08 12:47 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 799 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1669546724

Comment:
> Why not:
> 
> `depends=">php7.1.3 mariadb"`
> 
> or maybe:
> 
> `depends="php mariadb"`
> 
> When no version is given version is set to `>=0` according to the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional_vars) and _not_ the same as when _installing_ it without version.

This doesn't work how you think in this case. The version numbers in "php8.0", "php8.1", and "php8.2" are actually part of the package name.

> Let me add one more case, you should suggest MariaDB not force to install it. People can often? have remote databases, and having one run for nothing is way worse.

I agree :+1: 

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (17 preceding siblings ...)
  2023-08-08 12:47 ` TinfoilSubmarine
@ 2023-08-08 12:49 ` TinfoilSubmarine
  2023-08-08 14:34 ` TinfoilSubmarine
                   ` (8 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: TinfoilSubmarine @ 2023-08-08 12:49 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 916 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1669546724

Comment:
> Why not:
> 
> `depends=">php7.1.3 mariadb"`
> 
> or maybe:
> 
> `depends="php mariadb"`
> 
> When no version is given version is set to `>=0` according to the [manual](https://github.com/void-linux/void-packages/blob/master/Manual.md#optional_vars) and _not_ the same as when _installing_ it without version.

This doesn't work how you think in this case. The version numbers in "php8.0", "php8.1", and "php8.2" are actually part of the package name. The real version of the package comes after the dash ('-'), i.e. the version of php8.0 is 8.0.29: `php8.0-8.0.29_1`.

> Let me add one more case, you should suggest MariaDB not force to install it. People can often? have remote databases, and having one run for nothing is way worse.

I agree :+1: 

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (18 preceding siblings ...)
  2023-08-08 12:49 ` TinfoilSubmarine
@ 2023-08-08 14:34 ` TinfoilSubmarine
  2023-08-08 14:35 ` TinfoilSubmarine
                   ` (7 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: TinfoilSubmarine @ 2023-08-08 14:34 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 432 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1669745767

Comment:
OK y'all, I opened a new PR which introduces a `php-runtime` virtual package which solves this dillema. It's got a slew of updates in it so it might take a bit to get merged, but I did include this update to phpMyAdmin with the new dependency solution and would appreciate testing.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (19 preceding siblings ...)
  2023-08-08 14:34 ` TinfoilSubmarine
@ 2023-08-08 14:35 ` TinfoilSubmarine
  2023-08-08 15:36 ` [PR PATCH] [Updated] " MeganerdNL
                   ` (6 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: TinfoilSubmarine @ 2023-08-08 14:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1669745767

Comment:
OK y'all, I opened a new PR https://github.com/void-linux/void-packages/pull/45493 which introduces a `php-runtime` virtual package which solves this dillema. It's got a slew of updates in it so it might take a bit to get merged, but I did include this update to phpMyAdmin with the new dependency solution and would appreciate testing.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PR PATCH] [Updated] phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (20 preceding siblings ...)
  2023-08-08 14:35 ` TinfoilSubmarine
@ 2023-08-08 15:36 ` MeganerdNL
  2023-08-08 15:41 ` MeganerdNL
                   ` (5 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-08-08 15:36 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There is an updated pull request by MeganerdNL against master on the void-packages repository

https://github.com/MeganerdNL/void-packages phpMyAdmin-5.2.1
https://github.com/void-linux/void-packages/pull/44946

phpMyAdmin: update to 5.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/44946.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-phpMyAdmin-5.2.1-44946.patch --]
[-- Type: text/x-diff, Size: 1159 bytes --]

From d3088bbc67d6c45ba67ca28a3d706585639cb0f2 Mon Sep 17 00:00:00 2001
From: MeganerdNL <meganerd@meganerd.nl>
Date: Sun, 9 Jul 2023 15:49:48 +0200
Subject: [PATCH] phpMyAdmin: update to 5.2.1

---
 srcpkgs/phpMyAdmin/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/phpMyAdmin/template b/srcpkgs/phpMyAdmin/template
index 7f0b5f024df54..7f24ecba88fad 100644
--- a/srcpkgs/phpMyAdmin/template
+++ b/srcpkgs/phpMyAdmin/template
@@ -1,15 +1,15 @@
 # Template file for 'phpMyAdmin'
 pkgname=phpMyAdmin
-version=5.2.0
-revision=2
+version=5.2.1
+revision=1
 conf_files="/etc/webapps/phpMyAdmin/config.inc.php"
-depends="php8.1 mariadb"
+depends="php8.2"
 short_desc="Web interface for MySQL and MariaDB"
 maintainer="Joel Beckmeyer <joel@beckmeyer.us>"
 license="GPL-2.0-only"
 homepage="https://www.phpmyadmin.net"
 distfiles="https://files.phpmyadmin.net/phpMyAdmin/${version}/phpMyAdmin-${version}-all-languages.tar.xz"
-checksum=66da31ca295f06182ac3f2e6e96057dc824c459baedf4b29de6ed0d3be039230
+checksum=373f9599dfbd96d6fe75316d5dad189e68c305f297edf42377db9dd6b41b2557
 
 do_install() {
 	vmkdir usr/share/webapps/

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (21 preceding siblings ...)
  2023-08-08 15:36 ` [PR PATCH] [Updated] " MeganerdNL
@ 2023-08-08 15:41 ` MeganerdNL
  2023-08-11  8:59 ` [PR PATCH] [Updated] " MeganerdNL
                   ` (4 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-08-08 15:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 446 bytes --]

New comment by MeganerdNL on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1669859470

Comment:
Thank you @TinfoilSubmarine, sounds good. 
I updated this PR and removed `mariadb` as depends for now and left `php8.2`. 
If your #45493 gets merged, this PR here is obsolete, otherwise we could still use this.

I will try to test your PR tomorrow, but I cannot guarantee because of time shortage.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PR PATCH] [Updated] phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (22 preceding siblings ...)
  2023-08-08 15:41 ` MeganerdNL
@ 2023-08-11  8:59 ` MeganerdNL
  2023-09-15 10:15 ` MeganerdNL
                   ` (3 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-08-11  8:59 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There is an updated pull request by MeganerdNL against master on the void-packages repository

https://github.com/MeganerdNL/void-packages phpMyAdmin-5.2.1
https://github.com/void-linux/void-packages/pull/44946

phpMyAdmin: update to 5.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/44946.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-phpMyAdmin-5.2.1-44946.patch --]
[-- Type: text/x-diff, Size: 1159 bytes --]

From cd96df92993a445cf75ce87994dfc71c8e6e2a5a Mon Sep 17 00:00:00 2001
From: MeganerdNL <meganerd@meganerd.nl>
Date: Sun, 9 Jul 2023 15:49:48 +0200
Subject: [PATCH] phpMyAdmin: update to 5.2.1

---
 srcpkgs/phpMyAdmin/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/phpMyAdmin/template b/srcpkgs/phpMyAdmin/template
index 7f0b5f024df54..7f24ecba88fad 100644
--- a/srcpkgs/phpMyAdmin/template
+++ b/srcpkgs/phpMyAdmin/template
@@ -1,15 +1,15 @@
 # Template file for 'phpMyAdmin'
 pkgname=phpMyAdmin
-version=5.2.0
-revision=2
+version=5.2.1
+revision=1
 conf_files="/etc/webapps/phpMyAdmin/config.inc.php"
-depends="php8.1 mariadb"
+depends="php8.2"
 short_desc="Web interface for MySQL and MariaDB"
 maintainer="Joel Beckmeyer <joel@beckmeyer.us>"
 license="GPL-2.0-only"
 homepage="https://www.phpmyadmin.net"
 distfiles="https://files.phpmyadmin.net/phpMyAdmin/${version}/phpMyAdmin-${version}-all-languages.tar.xz"
-checksum=66da31ca295f06182ac3f2e6e96057dc824c459baedf4b29de6ed0d3be039230
+checksum=373f9599dfbd96d6fe75316d5dad189e68c305f297edf42377db9dd6b41b2557
 
 do_install() {
 	vmkdir usr/share/webapps/

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PR PATCH] [Updated] phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (23 preceding siblings ...)
  2023-08-11  8:59 ` [PR PATCH] [Updated] " MeganerdNL
@ 2023-09-15 10:15 ` MeganerdNL
  2023-12-15  1:46 ` github-actions
                   ` (2 subsequent siblings)
  27 siblings, 0 replies; 29+ messages in thread
From: MeganerdNL @ 2023-09-15 10:15 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 498 bytes --]

There is an updated pull request by MeganerdNL against master on the void-packages repository

https://github.com/MeganerdNL/void-packages phpMyAdmin-5.2.1
https://github.com/void-linux/void-packages/pull/44946

phpMyAdmin: update to 5.2.1
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

A patch file from https://github.com/void-linux/void-packages/pull/44946.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-phpMyAdmin-5.2.1-44946.patch --]
[-- Type: text/x-diff, Size: 1159 bytes --]

From 4ef714f7e6dc5c2b92c272e6e3a524eed3c5f78d Mon Sep 17 00:00:00 2001
From: MeganerdNL <meganerd@meganerd.nl>
Date: Sun, 9 Jul 2023 15:49:48 +0200
Subject: [PATCH] phpMyAdmin: update to 5.2.1

---
 srcpkgs/phpMyAdmin/template | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/phpMyAdmin/template b/srcpkgs/phpMyAdmin/template
index 7f0b5f024df54..7f24ecba88fad 100644
--- a/srcpkgs/phpMyAdmin/template
+++ b/srcpkgs/phpMyAdmin/template
@@ -1,15 +1,15 @@
 # Template file for 'phpMyAdmin'
 pkgname=phpMyAdmin
-version=5.2.0
-revision=2
+version=5.2.1
+revision=1
 conf_files="/etc/webapps/phpMyAdmin/config.inc.php"
-depends="php8.1 mariadb"
+depends="php8.2"
 short_desc="Web interface for MySQL and MariaDB"
 maintainer="Joel Beckmeyer <joel@beckmeyer.us>"
 license="GPL-2.0-only"
 homepage="https://www.phpmyadmin.net"
 distfiles="https://files.phpmyadmin.net/phpMyAdmin/${version}/phpMyAdmin-${version}-all-languages.tar.xz"
-checksum=66da31ca295f06182ac3f2e6e96057dc824c459baedf4b29de6ed0d3be039230
+checksum=373f9599dfbd96d6fe75316d5dad189e68c305f297edf42377db9dd6b41b2557
 
 do_install() {
 	vmkdir usr/share/webapps/

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (24 preceding siblings ...)
  2023-09-15 10:15 ` MeganerdNL
@ 2023-12-15  1:46 ` github-actions
  2023-12-30  1:45 ` [PR PATCH] [Closed]: " github-actions
  2023-12-30 11:11 ` williamdes
  27 siblings, 0 replies; 29+ messages in thread
From: github-actions @ 2023-12-15  1:46 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1857140251

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: [PR PATCH] [Closed]: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (25 preceding siblings ...)
  2023-12-15  1:46 ` github-actions
@ 2023-12-30  1:45 ` github-actions
  2023-12-30 11:11 ` williamdes
  27 siblings, 0 replies; 29+ messages in thread
From: github-actions @ 2023-12-30  1:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

There's a closed pull request on the void-packages repository

phpMyAdmin: update to 5.2.1
https://github.com/void-linux/void-packages/pull/44946

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

^ permalink raw reply	[flat|nested] 29+ messages in thread

* Re: phpMyAdmin: update to 5.2.1
  2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
                   ` (26 preceding siblings ...)
  2023-12-30  1:45 ` [PR PATCH] [Closed]: " github-actions
@ 2023-12-30 11:11 ` williamdes
  27 siblings, 0 replies; 29+ messages in thread
From: williamdes @ 2023-12-30 11:11 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 158 bytes --]

New comment by williamdes on void-packages repository

https://github.com/void-linux/void-packages/pull/44946#issuecomment-1872506866

Comment:
What a shame 

^ permalink raw reply	[flat|nested] 29+ messages in thread

end of thread, other threads:[~2023-12-30 11:11 UTC | newest]

Thread overview: 29+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-09 13:55 [PR PATCH] phpMyAdmin: update to version 5.2.1 MeganerdNL
2023-07-09 18:46 ` [PR PATCH] [Updated] " MeganerdNL
2023-07-09 18:49 ` phpMyAdmin: update to 5.2.1 MeganerdNL
2023-07-23 19:22 ` [PR PATCH] [Updated] " MeganerdNL
2023-07-29  8:42 ` MeganerdNL
2023-08-04 15:02 ` TinfoilSubmarine
2023-08-04 15:52 ` MeganerdNL
2023-08-04 21:49 ` williamdes
2023-08-07 12:37 ` TinfoilSubmarine
2023-08-07 13:12 ` williamdes
2023-08-07 13:22 ` TinfoilSubmarine
2023-08-07 13:38 ` williamdes
2023-08-08  2:18 ` TinfoilSubmarine
2023-08-08  5:53 ` MeganerdNL
2023-08-08  5:54 ` MeganerdNL
2023-08-08  7:30 ` MeganerdNL
2023-08-08  8:42 ` williamdes
2023-08-08  8:42 ` williamdes
2023-08-08 12:47 ` TinfoilSubmarine
2023-08-08 12:49 ` TinfoilSubmarine
2023-08-08 14:34 ` TinfoilSubmarine
2023-08-08 14:35 ` TinfoilSubmarine
2023-08-08 15:36 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-08 15:41 ` MeganerdNL
2023-08-11  8:59 ` [PR PATCH] [Updated] " MeganerdNL
2023-09-15 10:15 ` MeganerdNL
2023-12-15  1:46 ` github-actions
2023-12-30  1:45 ` [PR PATCH] [Closed]: " github-actions
2023-12-30 11:11 ` williamdes

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).