[PR PATCH] nss: ship libfreeblpriv3.so

[PR PATCH] nss: ship libfreeblpriv3.so

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1352 bytes --]

There is a new pull request by sgn against master on the void-packages repository

https://github.com/sgn/void-packages nss-freebl-private
https://github.com/void-linux/void-packages/pull/44940

nss: ship libfreeblpriv3.so
ClearKey plugins need to dlopen(2) this shared object. ClearKey will run into crash if it's not found.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44940.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nss-freebl-private-44940.patch --]
[-- Type: text/x-diff, Size: 1444 bytes --]

From 8fee6e573880ba2995c56410df588d35563a30b2 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
 <congdanhqx@gmail.com>
Date: Sun, 9 Jul 2023 16:59:30 +0700
Subject: [PATCH] nss: ship libfreeblpriv3.so

ClearKey plugins need to dlopen(2) this shared object.
ClearKey will run into crash if it's not found.
---
 srcpkgs/nss/template | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/srcpkgs/nss/template b/srcpkgs/nss/template
index ff2fa52f4059..2ea0386742f0 100644
--- a/srcpkgs/nss/template
+++ b/srcpkgs/nss/template
@@ -4,7 +4,7 @@ _nsprver=4.35
 
 pkgname=nss
 version=3.91
-revision=1
+revision=2
 hostmakedepends="perl which"
 makedepends="nspr-devel sqlite-devel zlib-devel"
 depends="nspr>=${_nsprver}"
@@ -21,7 +21,6 @@ export BUILD_OPT=1
 export NSS_USE_SYSTEM_SQLITE=1
 export NSS_ENABLE_WERROR=0
 export NSS_ENABLE_ECC=1
-export FREEBL_NO_DEPEND=1
 export NSPR_INCLUDE_DIR=${XBPS_CROSS_BASE}/usr/include/nspr
 export NSPR_LIB_DIR=${XBPS_CROSS_BASE}/usr/lib
 
@@ -109,7 +108,7 @@ do_install() {
 		> ${DESTDIR}/usr/bin/nss-config
 	chmod 755 ${DESTDIR}/usr/bin/nss-config
 
-	for f in libsoftokn3.so libfreebl3.so libnss3.so libnssutil3.so \
+	for f in libsoftokn3.so libfreebl3.so libfreeblpriv3.so libnss3.so libnssutil3.so \
 		libssl3.so libsmime3.so libnssckbi.so libnssdbm3.so libnsssysinit.so; do
 		install -m755 dist/*.OBJ/lib/${f} ${DESTDIR}/usr/lib
 	done

Re: nss: ship libfreeblpriv3.so

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/44940#issuecomment-1627733876

Comment:
This works for me, but I'm wondering what the right approach is here, it seems like its firefox which hardcodes this library to be preloaded and fails. I've had a hard time to find out why there is this private library, fedora seems to also not have it.

Re: nss: ship libfreeblpriv3.so

[sgn]

[-- Attachment #1: Type: text/plain, Size: 259 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/44940#issuecomment-1628059459

Comment:
Fedora ships the private libs too. https://packages.fedoraproject.org/pkgs/nss/nss-softokn-freebl/fedora-rawhide.html

Re: [PR PATCH] [Merged]: nss: ship libfreeblpriv3.so

[sgn]

[-- Attachment #1: Type: text/plain, Size: 1198 bytes --]

There's a merged pull request on the void-packages repository

nss: ship libfreeblpriv3.so
https://github.com/void-linux/void-packages/pull/44940

Description:
ClearKey plugins need to dlopen(2) this shared object. ClearKey will run into crash if it's not found.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->