Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] gitoxide: update to 0.27.0.
@ 2023-07-09  9:05 jcgruenhage
  2023-07-10  9:17 ` [PR PATCH] [Merged]: " classabbyamp
  2023-09-16 15:23 ` jalil-salame
  0 siblings, 2 replies; 3+ messages in thread
From: jcgruenhage @ 2023-07-09  9:05 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1672 bytes --]

There is a new pull request by jcgruenhage against master on the void-packages repository

https://github.com/jcgruenhage/void-packages gitoxide-0.27.0_1
https://github.com/void-linux/void-packages/pull/44936

gitoxide: update to 0.27.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

This PR disables cargo-auditable for gitoxide temporarily, as it fails to build when cargo-auditable is used. This is reproducible both within void-packages, as well as when using rustup and building it out of tree.

Reported upstream at https://github.com/rust-secure-code/cargo-auditable/issues/124, although I'm not sure whether it belongs there or with gitoxide. As it's cargo-auditable that's panic'ing, I've opened the issue there.
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/44936.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gitoxide-0.27.0_1-44936.patch --]
[-- Type: text/x-diff, Size: 1347 bytes --]

From edad9c32ddf787128b2ebe4cee9a21562558f12a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jan=20Christian=20Gr=C3=BCnhage?=
 <jan.christian@gruenhage.xyz>
Date: Sun, 9 Jul 2023 11:02:27 +0200
Subject: [PATCH] gitoxide: update to 0.27.0.

---
 srcpkgs/gitoxide/template | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/gitoxide/template b/srcpkgs/gitoxide/template
index 2be41ba5ea98..8b386d8eb4d1 100644
--- a/srcpkgs/gitoxide/template
+++ b/srcpkgs/gitoxide/template
@@ -1,8 +1,11 @@
 # Template file for 'gitoxide'
 pkgname=gitoxide
-version=0.23.0
+version=0.27.0
 revision=1
 build_style=cargo
+# Disabling cargo-auditable for now due to
+# https://github.com/rust-secure-code/cargo-auditable/issues/124
+make_cmd=cargo
 hostmakedepends="pkg-config cmake"
 makedepends="zlib-devel openssl-devel"
 short_desc="Idiomatic, lean, fast and safe pure Rust implementation of Git"
@@ -11,7 +14,7 @@ license="MIT, Apache-2.0"
 homepage="https://github.com/Byron/gitoxide"
 changelog="https://github.com/Byron/gitoxide/raw/main/CHANGELOG.md"
 distfiles="https://github.com/Byron/gitoxide/archive/refs/tags/v${version}.tar.gz"
-checksum=45b4fc2fc6f5f1ed9fb019cbae8633b6a3129f349182774b5b8c601bbb3e17db
+checksum=5055074b1dca11bb6ed5ca0b04c87393cf955ca6a536071ea702127cc7907d39
 
 post_install() {
 	vlicense LICENSE-APACHE

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: gitoxide: update to 0.27.0.
  2023-07-09  9:05 [PR PATCH] gitoxide: update to 0.27.0 jcgruenhage
@ 2023-07-10  9:17 ` classabbyamp
  2023-09-16 15:23 ` jalil-salame
  1 sibling, 0 replies; 3+ messages in thread
From: classabbyamp @ 2023-07-10  9:17 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1503 bytes --]

There's a merged pull request on the void-packages repository

gitoxide: update to 0.27.0.
https://github.com/void-linux/void-packages/pull/44936

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

This PR disables cargo-auditable for gitoxide temporarily, as it fails to build when cargo-auditable is used. This is reproducible both within void-packages, as well as when using rustup and building it out of tree.

Reported upstream at https://github.com/rust-secure-code/cargo-auditable/issues/124, although I'm not sure whether it belongs there or with gitoxide. As it's cargo-auditable that's panic'ing, I've opened the issue there.
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: gitoxide: update to 0.27.0.
  2023-07-09  9:05 [PR PATCH] gitoxide: update to 0.27.0 jcgruenhage
  2023-07-10  9:17 ` [PR PATCH] [Merged]: " classabbyamp
@ 2023-09-16 15:23 ` jalil-salame
  1 sibling, 0 replies; 3+ messages in thread
From: jalil-salame @ 2023-09-16 15:23 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 726 bytes --]

New comment by jalil-salame on void-packages repository

https://github.com/void-linux/void-packages/pull/44936#issuecomment-1722252659

Comment:
We ran into this issue in [nixpkgs](https://github.com/NixOS/nixpkgs/pull/254087), so I patched gitoxide and it has been upstreamed to the main branch: https://github.com/Byron/gitoxide/pull/1024

I am not a void user, but if someone wants to re-enable cargo-auditable you can probably do the same thing we did and pull the patch from the PR (it is only tested in version v0.29.0 though).

If it doesn't apply to v0.27.0 and you don't want to update, I did leave the reasoning about how the patch was made in the linked issues in the gitoxide PR if someone wants to replicate it.

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-09-16 15:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-09  9:05 [PR PATCH] gitoxide: update to 0.27.0 jcgruenhage
2023-07-10  9:17 ` [PR PATCH] [Merged]: " classabbyamp
2023-09-16 15:23 ` jalil-salame

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).