* Re: [PR REVIEW] New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
@ 2023-07-05 18:03 ` classabbyamp
2023-07-05 18:04 ` classabbyamp
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2023-07-05 18:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 171 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/44855#discussion_r1253455768
Comment:
```suggestion
```
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
2023-07-05 18:03 ` [PR REVIEW] " classabbyamp
@ 2023-07-05 18:04 ` classabbyamp
2023-07-05 18:05 ` classabbyamp
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2023-07-05 18:04 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 177 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/44855#discussion_r1253456477
Comment:
indent this with a space
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
2023-07-05 18:03 ` [PR REVIEW] " classabbyamp
2023-07-05 18:04 ` classabbyamp
@ 2023-07-05 18:05 ` classabbyamp
2023-07-06 7:44 ` [PR PATCH] [Updated] " Eloitor
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2023-07-05 18:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/44855#discussion_r1253457328
Comment:
you don't need to vmkdir the parent and the child, it does mkdir -p internally
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
` (2 preceding siblings ...)
2023-07-05 18:05 ` classabbyamp
@ 2023-07-06 7:44 ` Eloitor
2023-07-06 7:55 ` Eloitor
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eloitor @ 2023-07-06 7:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages autofirma
https://github.com/void-linux/void-packages/pull/44855
New package: autofirma-1.8.2
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
Closes https://github.com/void-linux/void-packages/issues/36872
A patch file from https://github.com/void-linux/void-packages/pull/44855.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-44855.patch --]
[-- Type: text/x-diff, Size: 2236 bytes --]
From e79276a40ed25ada7242bf17308fcea84650b09b Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Thu, 22 Dec 2022 14:04:57 +0100
Subject: [PATCH] New package: autofirma-1.7.2
---
srcpkgs/autofirma/files/autofirma | 2 ++
srcpkgs/autofirma/template | 41 +++++++++++++++++++++++++++++++
2 files changed, 43 insertions(+)
create mode 100644 srcpkgs/autofirma/files/autofirma
create mode 100644 srcpkgs/autofirma/template
diff --git a/srcpkgs/autofirma/files/autofirma b/srcpkgs/autofirma/files/autofirma
new file mode 100644
index 000000000000..173e8ac46fd6
--- /dev/null
+++ b/srcpkgs/autofirma/files/autofirma
@@ -0,0 +1,2 @@
+#! /bin/sh
+java -jar /usr/share/java/autofirma/AutoFirma.jar
diff --git a/srcpkgs/autofirma/template b/srcpkgs/autofirma/template
new file mode 100644
index 000000000000..52844fce9842
--- /dev/null
+++ b/srcpkgs/autofirma/template
@@ -0,0 +1,41 @@
+# Template file for 'autofirma'
+pkgname=autofirma
+version=1.7.2
+revision=1
+_jmulticard_version=1.7
+
+hostmakedepends="apache-maven openjdk11"
+depends="virtual?java-environment"
+short_desc="Cliente de firma electrónica ofrecido por la Administración Pública"
+maintainer="Eloi Torrents <eloitor@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://firmaelectronica.gob.es/"
+distfiles="https://github.com/ctt-gob-es/clienteafirma/archive/v${version}.tar.gz
+ https://github.com/ctt-gob-es/jmulticard/archive/refs/tags/v${_jmulticard_version}.tar.gz"
+checksum="f3d135f80c5e18e204110f9077f6be708280866600a68e71d9e13af09a1963d5
+eedc93e36ae79b2c36f276ad575bca0d84d3883487439e3f71622cfd4a4b58ac"
+
+# maven-surefire-plugin needed
+make_check=no
+
+do_build() {
+ export JAVA_HOME=/usr/lib/jvm/openjdk11
+ cd "jmulticard-${_jmulticard_version}"
+ mvn clean install -Dmaven.test.skip=true
+ cd "../clienteafirma-${version}"
+ mvn clean install -Denv=install -Dmaven.test.skip=true
+}
+
+do_check() {
+ cd "jmulticard-${_jmulticard_version}"
+ mvn test
+ cd "../clienteafirma-${version}"
+ mvn test
+}
+
+do_install() {
+ vmkdir usr/share/java
+ vmkdir usr/share/java/${pkgname}
+ vinstall clienteafirma-${version}/afirma-simple/target/AutoFirma.jar 644 usr/share/java/autofirma
+ vbin "${FILESDIR}/autofirma"
+}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
` (3 preceding siblings ...)
2023-07-06 7:44 ` [PR PATCH] [Updated] " Eloitor
@ 2023-07-06 7:55 ` Eloitor
2023-07-06 8:03 ` Eloitor
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eloitor @ 2023-07-06 7:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages autofirma
https://github.com/void-linux/void-packages/pull/44855
New package: autofirma-1.8.2
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
Closes https://github.com/void-linux/void-packages/issues/36872
A patch file from https://github.com/void-linux/void-packages/pull/44855.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-44855.patch --]
[-- Type: text/x-diff, Size: 2211 bytes --]
From d1d05e67fd35e7b0cf309e892a4e3d098ba12499 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Thu, 22 Dec 2022 14:04:57 +0100
Subject: [PATCH] New package: autofirma-1.8.2
---
srcpkgs/autofirma/files/autofirma | 2 ++
srcpkgs/autofirma/template | 39 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
create mode 100644 srcpkgs/autofirma/files/autofirma
create mode 100644 srcpkgs/autofirma/template
diff --git a/srcpkgs/autofirma/files/autofirma b/srcpkgs/autofirma/files/autofirma
new file mode 100644
index 000000000000..173e8ac46fd6
--- /dev/null
+++ b/srcpkgs/autofirma/files/autofirma
@@ -0,0 +1,2 @@
+#! /bin/sh
+java -jar /usr/share/java/autofirma/AutoFirma.jar
diff --git a/srcpkgs/autofirma/template b/srcpkgs/autofirma/template
new file mode 100644
index 000000000000..0c87574caa50
--- /dev/null
+++ b/srcpkgs/autofirma/template
@@ -0,0 +1,39 @@
+# Template file for 'autofirma'
+pkgname=autofirma
+version=1.8.2
+revision=1
+_jmulticard_version=1.8
+hostmakedepends="apache-maven openjdk11"
+depends="virtual?java-environment"
+short_desc="Cliente de firma electrónica ofrecido por la Administración Pública"
+maintainer="Eloi Torrents <eloitor@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://firmaelectronica.gob.es/"
+distfiles="https://github.com/ctt-gob-es/clienteafirma/archive/v${version}.tar.gz
+ https://github.com/ctt-gob-es/jmulticard/archive/refs/tags/v${_jmulticard_version}.tar.gz"
+checksum="40ebcd1200129ca08c21176a5fbd64c04ce0ac6bd932c4b213d4b7213f851a0d
+ f79df2e53bb2c89f7c603019fc3d92482756d071947669f798dd76b109a375aa"
+
+# maven-surefire-plugin needed
+make_check=no
+
+do_build() {
+ export JAVA_HOME=/usr/lib/jvm/openjdk11
+ cd "jmulticard-${_jmulticard_version}"
+ mvn clean install -Dmaven.test.skip=true
+ cd "../clienteafirma-${version}"
+ mvn clean install -Denv=install -Dmaven.test.skip=true
+}
+
+do_check() {
+ cd "jmulticard-${_jmulticard_version}"
+ mvn test
+ cd "../clienteafirma-${version}"
+ mvn test
+}
+
+do_install() {
+ vmkdir usr/share/java/${pkgname}
+ vinstall clienteafirma-${version}/afirma-simple/target/AutoFirma.jar 644 usr/share/java/autofirma
+ vbin "${FILESDIR}/autofirma"
+}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
` (4 preceding siblings ...)
2023-07-06 7:55 ` Eloitor
@ 2023-07-06 8:03 ` Eloitor
2023-07-06 8:05 ` Eloitor
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Eloitor @ 2023-07-06 8:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages autofirma
https://github.com/void-linux/void-packages/pull/44855
New package: autofirma-1.8.2
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
Closes https://github.com/void-linux/void-packages/issues/36872
A patch file from https://github.com/void-linux/void-packages/pull/44855.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-44855.patch --]
[-- Type: text/x-diff, Size: 2215 bytes --]
From 0e87c54487a189a4e7e837a6105354083a267455 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Thu, 22 Dec 2022 14:04:57 +0100
Subject: [PATCH] New package: autofirma-1.8.2
---
srcpkgs/autofirma/files/autofirma | 2 ++
srcpkgs/autofirma/template | 39 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
create mode 100644 srcpkgs/autofirma/files/autofirma
create mode 100644 srcpkgs/autofirma/template
diff --git a/srcpkgs/autofirma/files/autofirma b/srcpkgs/autofirma/files/autofirma
new file mode 100644
index 000000000000..173e8ac46fd6
--- /dev/null
+++ b/srcpkgs/autofirma/files/autofirma
@@ -0,0 +1,2 @@
+#! /bin/sh
+java -jar /usr/share/java/autofirma/AutoFirma.jar
diff --git a/srcpkgs/autofirma/template b/srcpkgs/autofirma/template
new file mode 100644
index 000000000000..44682746ec8c
--- /dev/null
+++ b/srcpkgs/autofirma/template
@@ -0,0 +1,39 @@
+# Template file for 'autofirma'
+pkgname=autofirma
+version=1.8.2
+revision=1
+_jmulticard_version=1.8
+hostmakedepends="apache-maven openjdk11"
+depends="virtual?java-environment"
+short_desc = "Electronic signature client offered by the Spanish Public Administration"
+maintainer="Eloi Torrents <eloitor@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://firmaelectronica.gob.es/"
+distfiles="https://github.com/ctt-gob-es/clienteafirma/archive/v${version}.tar.gz
+ https://github.com/ctt-gob-es/jmulticard/archive/refs/tags/v${_jmulticard_version}.tar.gz"
+checksum="40ebcd1200129ca08c21176a5fbd64c04ce0ac6bd932c4b213d4b7213f851a0d
+ f79df2e53bb2c89f7c603019fc3d92482756d071947669f798dd76b109a375aa"
+
+# maven-surefire-plugin needed
+make_check=no
+
+do_build() {
+ export JAVA_HOME=/usr/lib/jvm/openjdk11
+ cd "jmulticard-${_jmulticard_version}"
+ mvn clean install -Dmaven.test.skip=true
+ cd "../clienteafirma-${version}"
+ mvn clean install -Denv=install -Dmaven.test.skip=true
+}
+
+do_check() {
+ cd "jmulticard-${_jmulticard_version}"
+ mvn test
+ cd "../clienteafirma-${version}"
+ mvn test
+}
+
+do_install() {
+ vmkdir usr/share/java/${pkgname}
+ vinstall clienteafirma-${version}/afirma-simple/target/AutoFirma.jar 644 usr/share/java/autofirma
+ vbin "${FILESDIR}/autofirma"
+}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
` (5 preceding siblings ...)
2023-07-06 8:03 ` Eloitor
@ 2023-07-06 8:05 ` Eloitor
2023-07-06 8:10 ` Eloitor
2023-07-10 9:52 ` [PR PATCH] [Merged]: " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: Eloitor @ 2023-07-06 8:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 734 bytes --]
There is an updated pull request by Eloitor against master on the void-packages repository
https://github.com/Eloitor/void-packages autofirma
https://github.com/void-linux/void-packages/pull/44855
New package: autofirma-1.8.2
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
Closes https://github.com/void-linux/void-packages/issues/36872
A patch file from https://github.com/void-linux/void-packages/pull/44855.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-autofirma-44855.patch --]
[-- Type: text/x-diff, Size: 2207 bytes --]
From 83c306e4e51faca4d85d40ff1f112edc7dae47e9 Mon Sep 17 00:00:00 2001
From: Eloi Torrents <eloitor@disroot.org>
Date: Thu, 22 Dec 2022 14:04:57 +0100
Subject: [PATCH] New package: autofirma-1.8.2
---
srcpkgs/autofirma/files/autofirma | 2 ++
srcpkgs/autofirma/template | 39 +++++++++++++++++++++++++++++++
2 files changed, 41 insertions(+)
create mode 100644 srcpkgs/autofirma/files/autofirma
create mode 100644 srcpkgs/autofirma/template
diff --git a/srcpkgs/autofirma/files/autofirma b/srcpkgs/autofirma/files/autofirma
new file mode 100644
index 000000000000..173e8ac46fd6
--- /dev/null
+++ b/srcpkgs/autofirma/files/autofirma
@@ -0,0 +1,2 @@
+#! /bin/sh
+java -jar /usr/share/java/autofirma/AutoFirma.jar
diff --git a/srcpkgs/autofirma/template b/srcpkgs/autofirma/template
new file mode 100644
index 000000000000..fa0aed46a669
--- /dev/null
+++ b/srcpkgs/autofirma/template
@@ -0,0 +1,39 @@
+# Template file for 'autofirma'
+pkgname=autofirma
+version=1.8.2
+revision=1
+_jmulticard_version=1.8
+hostmakedepends="apache-maven openjdk11"
+depends="virtual?java-environment"
+short_desc="Electronic signature client from the Spanish Public Administration"
+maintainer="Eloi Torrents <eloitor@disroot.org>"
+license="GPL-3.0-or-later"
+homepage="https://firmaelectronica.gob.es/"
+distfiles="https://github.com/ctt-gob-es/clienteafirma/archive/v${version}.tar.gz
+ https://github.com/ctt-gob-es/jmulticard/archive/refs/tags/v${_jmulticard_version}.tar.gz"
+checksum="40ebcd1200129ca08c21176a5fbd64c04ce0ac6bd932c4b213d4b7213f851a0d
+ f79df2e53bb2c89f7c603019fc3d92482756d071947669f798dd76b109a375aa"
+
+# maven-surefire-plugin needed
+make_check=no
+
+do_build() {
+ export JAVA_HOME=/usr/lib/jvm/openjdk11
+ cd "jmulticard-${_jmulticard_version}"
+ mvn clean install -Dmaven.test.skip=true
+ cd "../clienteafirma-${version}"
+ mvn clean install -Denv=install -Dmaven.test.skip=true
+}
+
+do_check() {
+ cd "jmulticard-${_jmulticard_version}"
+ mvn test
+ cd "../clienteafirma-${version}"
+ mvn test
+}
+
+do_install() {
+ vmkdir usr/share/java/${pkgname}
+ vinstall clienteafirma-${version}/afirma-simple/target/AutoFirma.jar 644 usr/share/java/autofirma
+ vbin "${FILESDIR}/autofirma"
+}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
` (6 preceding siblings ...)
2023-07-06 8:05 ` Eloitor
@ 2023-07-06 8:10 ` Eloitor
2023-07-10 9:52 ` [PR PATCH] [Merged]: " classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: Eloitor @ 2023-07-06 8:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 187 bytes --]
New comment by Eloitor on void-packages repository
https://github.com/void-linux/void-packages/pull/44855#issuecomment-1623189247
Comment:
Fixed. I also translated the description.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Merged]: New package: autofirma-1.8.2
2023-07-05 9:37 [PR PATCH] New package: autofirma-1.8.2 Eloitor
` (7 preceding siblings ...)
2023-07-06 8:10 ` Eloitor
@ 2023-07-10 9:52 ` classabbyamp
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2023-07-10 9:52 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 576 bytes --]
There's a merged pull request on the void-packages repository
New package: autofirma-1.8.2
https://github.com/void-linux/void-packages/pull/44855
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-musl)
Closes https://github.com/void-linux/void-packages/issues/36872
^ permalink raw reply [flat|nested] 10+ messages in thread