* [PR PATCH] lemoa: update to 0.3.0.
@ 2023-07-13 15:17 Bnyro
2023-07-13 16:03 ` icp1994
` (4 more replies)
0 siblings, 5 replies; 6+ messages in thread
From: Bnyro @ 2023-07-13 15:17 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1093 bytes --]
There is a new pull request by Bnyro against master on the void-packages repository
https://github.com/Bnyro/void-packages lemoa
https://github.com/void-linux/void-packages/pull/45015
lemoa: update to 0.3.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/45015.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lemoa-45015.patch --]
[-- Type: text/x-diff, Size: 1106 bytes --]
From 76f00ca0d271bf096d7749aa127e50e6962e96ae Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Thu, 13 Jul 2023 17:17:01 +0200
Subject: [PATCH] lemoa: update to 0.3.0.
---
srcpkgs/lemoa/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/lemoa/template b/srcpkgs/lemoa/template
index c4e1b2597548..8948ba01910e 100644
--- a/srcpkgs/lemoa/template
+++ b/srcpkgs/lemoa/template
@@ -1,6 +1,6 @@
# Template file for 'lemoa'
pkgname=lemoa
-version=0.2.0
+version=0.3.0
revision=1
build_style=meson
build_helper=rust
@@ -11,9 +11,9 @@ maintainer="Bnyro <bnyro@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/lemmygtk/lemoa"
distfiles="https://github.com/lemmygtk/lemoa/releases/download/v${version}/lemoa-${version}.tar.xz"
-checksum=602974f62557f2476e0b7d081d9c727fec748e833d8c6e4cc112e9208c09a7c2
+checksum=cc3665dd42faf90d1b394fc4c7b67ae0baff5b6379d6082c61bdf3c868fd84cd
-pre_build() {
+post_patch() {
if [ "$CROSS_BUILD" ]; then
vsed -i src/meson.build \
-e "s%rust_target /%'${RUST_TARGET}' / rust_target /%"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: lemoa: update to 0.3.0.
2023-07-13 15:17 [PR PATCH] lemoa: update to 0.3.0 Bnyro
@ 2023-07-13 16:03 ` icp1994
2023-07-13 16:10 ` icp1994
` (3 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: icp1994 @ 2023-07-13 16:03 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 497 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/45015#issuecomment-1634509327
Comment:
While installing I get
> Refreshing GSettings database from usr/share/glib-2.0/schemas... usr/share/glib-2.0/schemas/io.github.lemmygtk.lemoa.gschema.xml:4:1 Error on line 4 char 1: A path, if given, must begin and end with a slash. This entire file has been ignored.
which isn't the end of the world, but better to add it upstream for next release.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: lemoa: update to 0.3.0.
2023-07-13 15:17 [PR PATCH] lemoa: update to 0.3.0 Bnyro
2023-07-13 16:03 ` icp1994
@ 2023-07-13 16:10 ` icp1994
2023-07-13 16:19 ` Bnyro
` (2 subsequent siblings)
4 siblings, 0 replies; 6+ messages in thread
From: icp1994 @ 2023-07-13 16:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1155 bytes --]
New comment by icp1994 on void-packages repository
https://github.com/void-linux/void-packages/pull/45015#issuecomment-1634518687
Comment:
Since GH won't let me review unedited code, this is what I would change.
```patch
diff --git a/srcpkgs/lemoa/template b/srcpkgs/lemoa/template
index 8948ba019..0a425097c 100644
--- a/srcpkgs/lemoa/template
+++ b/srcpkgs/lemoa/template
@@ -4,12 +4,13 @@ version=0.3.0
revision=1
build_style=meson
build_helper=rust
-hostmakedepends="pkg-config rust cargo desktop-file-utils glib-devel gtk-update-icon-cache"
-makedepends="rust-std gtk4-devel libadwaita-devel"
+hostmakedepends="pkg-config cargo desktop-file-utils gtk4-update-icon-cache"
+makedepends="rust-std gtk4-devel libglib-devel libadwaita-devel"
short_desc="Gtk client for Lemmy"
maintainer="Bnyro <bnyro@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/lemmygtk/lemoa"
+changelog="https://github.com/lemmygtk/lemoa/releases"
distfiles="https://github.com/lemmygtk/lemoa/releases/download/v${version}/lemoa-${version}.tar.xz"
checksum=cc3665dd42faf90d1b394fc4c7b67ae0baff5b6379d6082c61bdf3c868fd84cd
```
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: lemoa: update to 0.3.0.
2023-07-13 15:17 [PR PATCH] lemoa: update to 0.3.0 Bnyro
2023-07-13 16:03 ` icp1994
2023-07-13 16:10 ` icp1994
@ 2023-07-13 16:19 ` Bnyro
2023-07-13 16:20 ` [PR PATCH] [Updated] " Bnyro
2023-07-14 17:22 ` [PR PATCH] [Merged]: " Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: Bnyro @ 2023-07-13 16:19 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 415 bytes --]
New comment by Bnyro on void-packages repository
https://github.com/void-linux/void-packages/pull/45015#issuecomment-1634531195
Comment:
> which isn't the end of the world, but better to add it upstream for next release.
>
Oh okay, thanks for the hint! I'm not yet that familiar with gschema so I just added one for it to exist, but it doesn't contain any logic yet.
And thank you for the suggested patch!
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Updated] lemoa: update to 0.3.0.
2023-07-13 15:17 [PR PATCH] lemoa: update to 0.3.0 Bnyro
` (2 preceding siblings ...)
2023-07-13 16:19 ` Bnyro
@ 2023-07-13 16:20 ` Bnyro
2023-07-14 17:22 ` [PR PATCH] [Merged]: " Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: Bnyro @ 2023-07-13 16:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 1098 bytes --]
There is an updated pull request by Bnyro against master on the void-packages repository
https://github.com/Bnyro/void-packages lemoa
https://github.com/void-linux/void-packages/pull/45015
lemoa: update to 0.3.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/45015.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-lemoa-45015.patch --]
[-- Type: text/x-diff, Size: 1487 bytes --]
From 92e864cafe8b4e9900fdc2b1ef737fb0df06f383 Mon Sep 17 00:00:00 2001
From: Bnyro <bnyro@tutanota.com>
Date: Thu, 13 Jul 2023 18:21:06 +0200
Subject: [PATCH] lemoa: update to 0.3.0.
---
srcpkgs/lemoa/template | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/srcpkgs/lemoa/template b/srcpkgs/lemoa/template
index c4e1b2597548..1a826647d4f5 100644
--- a/srcpkgs/lemoa/template
+++ b/srcpkgs/lemoa/template
@@ -1,19 +1,20 @@
# Template file for 'lemoa'
pkgname=lemoa
-version=0.2.0
+version=0.3.0
revision=1
build_style=meson
build_helper=rust
-hostmakedepends="pkg-config rust cargo desktop-file-utils glib-devel gtk-update-icon-cache"
-makedepends="rust-std gtk4-devel libadwaita-devel"
+hostmakedepends="pkg-config cargo desktop-file-utils glib-devel gtk-update-icon-cache"
+makedepends="rust-std gtk4-devel libglib-devel libadwaita-devel"
short_desc="Gtk client for Lemmy"
maintainer="Bnyro <bnyro@tutanota.com>"
license="GPL-3.0-or-later"
homepage="https://github.com/lemmygtk/lemoa"
+changelog="https://github.com/lemmygtk/lemoa/releases"
distfiles="https://github.com/lemmygtk/lemoa/releases/download/v${version}/lemoa-${version}.tar.xz"
-checksum=602974f62557f2476e0b7d081d9c727fec748e833d8c6e4cc112e9208c09a7c2
+checksum=cc3665dd42faf90d1b394fc4c7b67ae0baff5b6379d6082c61bdf3c868fd84cd
-pre_build() {
+post_patch() {
if [ "$CROSS_BUILD" ]; then
vsed -i src/meson.build \
-e "s%rust_target /%'${RUST_TARGET}' / rust_target /%"
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PR PATCH] [Merged]: lemoa: update to 0.3.0.
2023-07-13 15:17 [PR PATCH] lemoa: update to 0.3.0 Bnyro
` (3 preceding siblings ...)
2023-07-13 16:20 ` [PR PATCH] [Updated] " Bnyro
@ 2023-07-14 17:22 ` Duncaen
4 siblings, 0 replies; 6+ messages in thread
From: Duncaen @ 2023-07-14 17:22 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
There's a merged pull request on the void-packages repository
lemoa: update to 0.3.0.
https://github.com/void-linux/void-packages/pull/45015
Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->
#### Testing the changes
- I tested the changes in this PR: **YES**
<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->
<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2023-07-14 17:22 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-13 15:17 [PR PATCH] lemoa: update to 0.3.0 Bnyro
2023-07-13 16:03 ` icp1994
2023-07-13 16:10 ` icp1994
2023-07-13 16:19 ` Bnyro
2023-07-13 16:20 ` [PR PATCH] [Updated] " Bnyro
2023-07-14 17:22 ` [PR PATCH] [Merged]: " Duncaen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).