[PR PATCH] New package: netatalk-3.1.15

[PR PATCH] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 1081 bytes --]

There is a new pull request by bsdelf against master on the void-packages repository

https://github.com/bsdelf/void-packages netatalk
https://github.com/void-linux/void-packages/pull/45011

New package: netatalk-3.1.15
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-netatalk-45011.patch --]
[-- Type: text/x-diff, Size: 1730 bytes --]

From 807a41ffd5bd1dcd269c320776a32e9fce414f00 Mon Sep 17 00:00:00 2001
From: Yanhui Shen <shen.elf@gmail.com>
Date: Thu, 13 Jul 2023 15:30:27 +0800
Subject: [PATCH] New package: netatalk-3.1.15

---
 srcpkgs/netatalk/files/netatalk/run |  3 +++
 srcpkgs/netatalk/template           | 25 +++++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100755 srcpkgs/netatalk/files/netatalk/run
 create mode 100644 srcpkgs/netatalk/template

diff --git a/srcpkgs/netatalk/files/netatalk/run b/srcpkgs/netatalk/files/netatalk/run
new file mode 100755
index 000000000000..dee5dcfa309d
--- /dev/null
+++ b/srcpkgs/netatalk/files/netatalk/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec netatalk
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
new file mode 100644
index 000000000000..b05617ace0a4
--- /dev/null
+++ b/srcpkgs/netatalk/template
@@ -0,0 +1,25 @@
+# Template file for 'netatalk'
+pkgname=netatalk
+version=3.1.15
+revision=1
+archs='x86_64'
+build_style=gnu-configure
+conf_files="
+	/etc/dbus-1/system.d/netatalk-dbus.conf
+	/etc/extmap.conf
+	/etc/afp.conf
+	/etc/dbus-session.conf"
+hostmakedepends="autoconf automake pkg-config tar"
+makedepends="libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
+depends="python3"
+short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
+maintainer="Yanhui Shen <shen.elf@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Netatalk/netatalk"
+distfiles="${homepage}/releases/download/${pkgname}-${version//./-}/netatalk-${version}.tar.bz2"
+checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
+python_version=3
+
+post_install() {
+	vsv netatalk
+}

Re: [PR REVIEW] New package: netatalk-3.1.15

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 212 bytes --]

New review comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#discussion_r1262606411

Comment:
This should probably not be restricted to only one architecture.

Re: [PR REVIEW] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 2516 bytes --]

New review comment by bsdelf on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#discussion_r1263343973

Comment:
I've tried `-a aarch64` and `-a armv6l-musl`, both of them failed at the configure stage

```
checking for SSL... no
checking for Berkeley DB headers in /usr/local/include/... no
checking for Berkeley DB headers in /usr/local/include/db6.1... no
checking for Berkeley DB headers in /usr/local/include/db6... no
checking for Berkeley DB headers in /usr/local/include/db5... no
checking for Berkeley DB headers in /usr/local/include/db5.3... no
checking for Berkeley DB headers in /usr/local/include/db5.2... no
checking for Berkeley DB headers in /usr/local/include/db5.1... no
checking for Berkeley DB headers in /usr/local/include/db51... no
checking for Berkeley DB headers in /usr/local/include/db5.0... no
checking for Berkeley DB headers in /usr/local/include/db50... no
checking for Berkeley DB headers in /usr/local/include/db4.8... no
checking for Berkeley DB headers in /usr/local/include/db48... no
checking for Berkeley DB headers in /usr/local/include/db4.7... no
checking for Berkeley DB headers in /usr/local/include/db47... no
checking for Berkeley DB headers in /usr/local/include/db4.6... no
checking for Berkeley DB headers in /usr/local/include/db46... no
checking for Berkeley DB headers in /usr/local/include/db4... no
checking for Berkeley DB headers in /usr/include/... no
checking for Berkeley DB headers in /usr/include/db6.1... no
checking for Berkeley DB headers in /usr/include/db6... no
checking for Berkeley DB headers in /usr/include/db5... no
checking for Berkeley DB headers in /usr/include/db5.3... no
checking for Berkeley DB headers in /usr/include/db5.2... no
checking for Berkeley DB headers in /usr/include/db5.1... no
checking for Berkeley DB headers in /usr/include/db51... no
checking for Berkeley DB headers in /usr/include/db5.0... no
checking for Berkeley DB headers in /usr/include/db50... no
checking for Berkeley DB headers in /usr/include/db4.8... no
checking for Berkeley DB headers in /usr/include/db48... no
checking for Berkeley DB headers in /usr/include/db4.7... no
checking for Berkeley DB headers in /usr/include/db47... no
checking for Berkeley DB headers in /usr/include/db4.6... no
checking for Berkeley DB headers in /usr/include/db46... no
checking for Berkeley DB headers in /usr/include/db4... no
configure: error: Berkeley DB library required but not found!
```

Re: [PR REVIEW] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 15781 bytes --]

New review comment by bsdelf on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#discussion_r1263343973

Comment:
I've tried `-a aarch64` and `-a armv6l-musl`, both of them failed at the configure stage

```
% ./xbps-src -a aarch64 pkg netatalk
=> xbps-src: updating repositories for host (x86_64)...
[*] Updating repository `https://repo-default.voidlinux.org/current/bootstrap/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/nonfree/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/debug/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/bootstrap/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/x86_64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/multilib/nonfree/x86_64-repodata' ...
=> xbps-src: updating repositories for target (aarch64)...
[*] Updating repository `https://repo-default.voidlinux.org/current/aarch64/bootstrap/aarch64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/aarch64/aarch64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/aarch64/nonfree/aarch64-repodata' ...
[*] Updating repository `https://repo-default.voidlinux.org/current/aarch64/debug/aarch64-repodata' ...
=> xbps-src: updating software in / masterdir...
=> xbps-src: cleaning up / masterdir...
=> netatalk-3.1.15_1: removing autodeps, please wait...
=> netatalk-3.1.15_1: removing autocrossdeps, please wait...
=> netatalk-3.1.15_1: building with [gnu-configure] for aarch64...
   [host] autoconf-2.71_1: found (/host/binpkgs)
   [host] automake-1.16.5_1: found (/host/binpkgs)
   [host] pkg-config-0.29.2_3: found (/host/binpkgs)
   [host] tar-1.34_3: found (/host/binpkgs)
   [target] libgcrypt-devel-1.10.2_1: found (https://repo-default.voidlinux.org/current/aarch64)
   [target] db-devel-5.3.28_8: found (https://repo-default.voidlinux.org/current/aarch64)
   [target] libevent-devel-2.1.12_2: found (https://repo-default.voidlinux.org/current/aarch64)
   [target] avahi-libs-devel-0.8_2: found (https://repo-default.voidlinux.org/current/aarch64)
   [target] openssl-devel-1.1.1t_1: found (https://repo-default.voidlinux.org/current/aarch64)
   [target] dbus-glib-devel-0.112_1: found (https://repo-default.voidlinux.org/current/aarch64)
   [runtime] python3-3.11.4_1: found (https://repo-default.voidlinux.org/current/aarch64)
=> netatalk-3.1.15_1: installing host dependencies: autoconf-2.71_1 automake-1.16.5_1 pkg-config-0.29.2_3 tar-1.34_3 ...
=> netatalk-3.1.15_1: installing target dependencies: libgcrypt-devel-1.10.2_1 db-devel-5.3.28_8 libevent-devel-2.1.12_2 avahi-libs-devel-0.8_2 openssl-devel-1.1.1t_1 dbus-glib-devel-0.112_1 ...
=> xbps-src: installing cross compiler: cross-aarch64-linux-gnu ...
=> netatalk-3.1.15_1: running do-fetch hook: 00-distfiles ...
=> netatalk-3.1.15_1: running do-extract hook: 00-distfiles ...
=> netatalk-3.1.15_1: extracting distfile(s), please wait...
=> netatalk-3.1.15_1: running do-patch hook: 00-patches ...
=> netatalk-3.1.15_1: running pre-configure hook: 00-gnu-configure-asneeded ...
=> netatalk-3.1.15_1: running pre-configure hook: 01-override-config ...
=> netatalk-3.1.15_1: running pre-configure hook: 02-script-wrapper ...
=> netatalk-3.1.15_1: running do_configure ...
configure: WARNING: unrecognized options: --with-libtool-sysroot
checking build system type... x86_64-unknown-linux-gnu
checking host system type... aarch64-unknown-linux-gnu
checking for a BSD-compatible install... /builddir/.xbps-netatalk/wrappers/install -c
checking whether build environment is sane... yes
checking for aarch64-linux-gnu-strip... aarch64-linux-gnu-strip
checking for a race-free mkdir -p... /usr/bin/mkdir -p
checking for gawk... gawk
checking whether make sets $(MAKE)... yes
checking whether make supports nested variables... yes
checking whether to enable maintainer-specific portions of Makefiles... yes
checking for gawk... (cached) gawk
checking for aarch64-linux-gnu-gcc... aarch64-linux-gnu-gcc
checking whether the C compiler works... yes
checking for C compiler default output file name... a.out
checking for suffix of executables... 
checking whether we are cross compiling... yes
checking for suffix of object files... o
checking whether the compiler supports GNU C... yes
checking whether aarch64-linux-gnu-gcc accepts -g... yes
checking for aarch64-linux-gnu-gcc option to enable C11 features... none needed
checking whether aarch64-linux-gnu-gcc understands -c and -o together... yes
checking whether make supports the include directive... yes (GNU style)
checking dependency style of aarch64-linux-gnu-gcc... gcc3
checking whether ln -s works... yes
checking whether make sets $(MAKE)... (cached) yes
checking how to print strings... printf
checking for a sed that does not truncate output... /usr/bin/sed
checking for grep... /usr/bin/grep
checking for egrep... /usr/bin/grep -E
checking for fgrep... /usr/bin/grep -F
checking for ld used by aarch64-linux-gnu-gcc... aarch64-linux-gnu-ld
checking if the linker (aarch64-linux-gnu-ld) is GNU ld... yes
checking for BSD- or MS-compatible name lister (nm)... aarch64-linux-gnu-nm
checking the name lister (aarch64-linux-gnu-nm) interface... BSD nm
checking the maximum length of command line arguments... 1572864
checking how to convert x86_64-unknown-linux-gnu file names to aarch64-unknown-linux-gnu format... func_convert_file_noop
checking how to convert x86_64-unknown-linux-gnu file names to toolchain format... func_convert_file_noop
checking for aarch64-linux-gnu-ld option to reload object files... -r
checking for aarch64-linux-gnu-file... no
checking for file... file
configure: WARNING: using cross tools not prefixed with host triplet
checking for aarch64-linux-gnu-objdump... aarch64-linux-gnu-objdump
checking how to recognize dependent libraries... pass_all
checking for aarch64-linux-gnu-dlltool... no
checking for dlltool... no
checking how to associate runtime and link libraries... printf %s\n
checking for aarch64-linux-gnu-ar... aarch64-linux-gnu-ar
checking for archiver @FILE support... @
checking for aarch64-linux-gnu-strip... (cached) aarch64-linux-gnu-strip
checking for aarch64-linux-gnu-ranlib... aarch64-linux-gnu-ranlib
checking command to parse aarch64-linux-gnu-nm output from aarch64-linux-gnu-gcc object... ok
checking for sysroot... /usr/aarch64-linux-gnu
checking for a working dd... /usr/bin/dd
checking how to truncate binary pipes... /usr/bin/dd bs=4096 count=1
checking for aarch64-linux-gnu-mt... no
checking for mt... no
checking if : is a manifest tool... no
checking for stdio.h... yes
checking for stdlib.h... yes
checking for string.h... yes
checking for inttypes.h... yes
checking for stdint.h... yes
checking for strings.h... yes
checking for sys/stat.h... yes
checking for sys/types.h... yes
checking for unistd.h... yes
checking for dlfcn.h... yes
checking for objdir... .libs
checking if aarch64-linux-gnu-gcc supports -fno-rtti -fno-exceptions... no
checking for aarch64-linux-gnu-gcc option to produce PIC... -fPIC -DPIC
checking if aarch64-linux-gnu-gcc PIC flag -fPIC -DPIC works... yes
checking if aarch64-linux-gnu-gcc static flag -static works... yes
checking if aarch64-linux-gnu-gcc supports -c -o file.o... yes
checking if aarch64-linux-gnu-gcc supports -c -o file.o... (cached) yes
checking whether the aarch64-linux-gnu-gcc linker (aarch64-linux-gnu-ld) supports shared libraries... yes
checking whether -lc should be explicitly linked in... no
checking dynamic linker characteristics... GNU/Linux ld.so
checking how to hardcode library paths into programs... immediate
checking for shl_load... no
checking for shl_load in -ldld... no
checking for dlopen... yes
checking whether a program can dlopen itself... cross
checking whether stripping libraries is possible... yes
checking if libtool supports shared libraries... yes
checking whether to build shared libraries... yes
checking whether to build static libraries... yes
checking for perl... /usr/bin/perl
checking for perl... (cached) /usr/bin/grep
checking for ps... ps
checking whether byte ordering is bigendian... (cached) no
checking for inline... inline
checking for flex... no
checking for lex... no
checking for bison... no
checking for byacc... no
checking to see if we can add '__attribute__((unused))' to CFLAGS... yes
checking for mntent.h... yes
checking for unistd.h... (cached) yes
checking for termios.h... yes
checking for ufs/quota.h... no
checking for netdb.h... yes
checking for sgtty.h... yes
checking for statfs.h... no
checking for dlfcn.h... (cached) yes
checking for langinfo.h... yes
checking for locale.h... yes
checking for sys/param.h... yes
checking for sys/fcntl.h... yes
checking for sys/termios.h... yes
checking for sys/mnttab.h... no
checking for sys/statvfs.h... yes
checking for sys/stat.h... (cached) yes
checking for sys/vfs.h... yes
checking for sys/mount.h... yes
checking for fshare_t... no
checking for _FILE_OFFSET_BITS value needed for large files... 64
checking for 64 bit off_t... cross
checking if large file support is available... yes
checking for aarch64-linux-gnu-gcc options needed to detect all undeclared functions... none needed
checking for library containing dlopen... none required
checking for dlerror... yes
checking for shl_load... (cached) no
checking for shl_load in -ldld... (cached) no
checking for dld_link in -ldld... no
checking for dlopen... (cached) yes
checking for dlsym... yes
checking for dlclose... yes
checking for _ prefix in compiled symbols... no
checking what extension is used for runtime loadable modules... .so
checking for openat... yes
checking for renameat... yes
checking for fstatat... yes
checking for unlinkat... yes
checking for struct tm.tm_gmtoff... yes
checking for backtrace_symbols... yes
checking for dirfd... yes
checking for getusershell... yes
checking for pread... (cached) yes
checking for pwrite... (cached) yes
checking for pselect... yes
checking for setlinebuf... yes
checking for strlcat... no
checking for strlcpy... no
checking for strnlen... yes
checking for mempcpy... yes
checking for vasprintf... yes
checking for asprintf... yes
checking for mmap... yes
checking for utime... yes
checking for getpagesize... (cached) yes
checking for library containing gethostbyname... none required
checking for library containing connect... none required
checking for getifaddrs... yes
checking how to run the C preprocessor... aarch64-linux-gnu-cpp
checking whether aarch64-linux-gnu-gcc is Clang... no
checking whether pthreads work with "-pthread" and "-lpthread"... yes
checking for joinable pthread attribute... PTHREAD_CREATE_JOINABLE
checking whether more special flags are required for pthreads... no
checking for PTHREAD_PRIO_INHERIT... yes
checking whether to check for 64bit libraries... no
 * Linux specific configuration
checking for linux/dqblk_xfs.h... yes
checking for ldconfig... /builddir/.xbps-netatalk/wrappers/ldconfig
NETA_LDCONFIG = /builddir/.xbps-netatalk/wrappers/ldconfig
no
checking whether to enable AFS support... no
checking for cracklib support... no
checking whether to enable verbose debug code... no
checking whether to enable debugging with debuggers... no
checking for libiconv... no
checking for working iconv... cross
checking whether or not to use Database Daemon CNID backend... yes
checking whether or not to use BDB Concurrent Data Store... no
checking whether or not to use LAST DID scheme... yes
checking whether or not to use TDB DID scheme... yes
checking MySQL library and headers... checking for mysql_config... no
checking default DID scheme... dbd
checking whether default CNID scheme has been activated... yes
checking for main in -lrpcsvc... no
checking for rpc/rpc.h... no
checking for rpc/pmap_prot.h... no
checking for rpcsvc/rquota.h... no
checking for getfsquota in -lquota... no
checking pkg-config is at least version 0.9.0... yes
checking for avahi-client/client.h... yes
checking for avahi_client_new in -lavahi-client... yes
checking for  avahi-client >= 0.6 ... yes
checking for  avahi-client >= 0.6.4 ... yes
checking whether to enable Zeroconf support... yes
checking whether to enable the TCP wrappers... no
checking for PAM installation directory... no
checking for security/pam_appl.h... no
checking for pam/pam_appl.h... no
checking for includable common PAM config... no (using defaut pam_unix.so)
checking whether to enable PAM support... no
checking for shadow.h... yes
checking whether shadow support should be enabled... yes
checking whether checking for a valid shell should be enabled... yes
disabling init-style support
checking for libgcrypt-config... /builddir/.xbps-netatalk/wrappers/libgcrypt-config
checking for LIBGCRYPT - version >= 1.2.3... yes (1.10.2)
checking libgcrypt API version... okay
checking libgcrypt hast CAST5 API... yes
configure: Enabling DHX2 UAM
checking for SSL... no
checking for Berkeley DB headers in /usr/local/include/... no
checking for Berkeley DB headers in /usr/local/include/db6.1... no
checking for Berkeley DB headers in /usr/local/include/db6... no
checking for Berkeley DB headers in /usr/local/include/db5... no
checking for Berkeley DB headers in /usr/local/include/db5.3... no
checking for Berkeley DB headers in /usr/local/include/db5.2... no
checking for Berkeley DB headers in /usr/local/include/db5.1... no
checking for Berkeley DB headers in /usr/local/include/db51... no
checking for Berkeley DB headers in /usr/local/include/db5.0... no
checking for Berkeley DB headers in /usr/local/include/db50... no
checking for Berkeley DB headers in /usr/local/include/db4.8... no
checking for Berkeley DB headers in /usr/local/include/db48... no
checking for Berkeley DB headers in /usr/local/include/db4.7... no
checking for Berkeley DB headers in /usr/local/include/db47... no
checking for Berkeley DB headers in /usr/local/include/db4.6... no
checking for Berkeley DB headers in /usr/local/include/db46... no
checking for Berkeley DB headers in /usr/local/include/db4... no
checking for Berkeley DB headers in /usr/include/... no
checking for Berkeley DB headers in /usr/include/db6.1... no
checking for Berkeley DB headers in /usr/include/db6... no
checking for Berkeley DB headers in /usr/include/db5... no
checking for Berkeley DB headers in /usr/include/db5.3... no
checking for Berkeley DB headers in /usr/include/db5.2... no
checking for Berkeley DB headers in /usr/include/db5.1... no
checking for Berkeley DB headers in /usr/include/db51... no
checking for Berkeley DB headers in /usr/include/db5.0... no
checking for Berkeley DB headers in /usr/include/db50... no
checking for Berkeley DB headers in /usr/include/db4.8... no
checking for Berkeley DB headers in /usr/include/db48... no
checking for Berkeley DB headers in /usr/include/db4.7... no
checking for Berkeley DB headers in /usr/include/db47... no
checking for Berkeley DB headers in /usr/include/db4.6... no
checking for Berkeley DB headers in /usr/include/db46... no
checking for Berkeley DB headers in /usr/include/db4... no
configure: error: Berkeley DB library required but not found!
=> ERROR: netatalk-3.1.15_1: do_configure: '${configure_script} ${configure_args}' exited with 1
=> ERROR:   in do_configure() at common/build-style/gnu-configure.sh:8

```

Re: New package: netatalk-3.1.15

[Duncaen]

[-- Attachment #1: Type: text/plain, Size: 1595 bytes --]

New comment by Duncaen on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1636184668

Comment:
```diff
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
index b05617ace0..82d3688a5c 100644
--- a/srcpkgs/netatalk/template
+++ b/srcpkgs/netatalk/template
@@ -2,24 +2,28 @@
 pkgname=netatalk
 version=3.1.15
 revision=1
-archs='x86_64'
 build_style=gnu-configure
-conf_files="
-       /etc/dbus-1/system.d/netatalk-dbus.conf
-       /etc/extmap.conf
-       /etc/afp.conf
-       /etc/dbus-session.conf"
-hostmakedepends="autoconf automake pkg-config tar"
+hostmakedepends="automake pkg-config"
 makedepends="libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
 depends="python3"
 short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
 maintainer="Yanhui Shen <shen.elf@gmail.com>"
 license="GPL-2.0-only"
 homepage="https://github.com/Netatalk/netatalk"
-distfiles="${homepage}/releases/download/${pkgname}-${version//./-}/netatalk-${version}.tar.bz2"
+distfiles="https://github.com/Netatalk/netatalk/releases/download/netatalk-${version//./-}/netatalk-${version}.tar.bz2"
 checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
 python_version=3

+conf_files="
+ /etc/dbus-1/system.d/netatalk-dbus.conf
+ /etc/extmap.conf
+ /etc/afp.conf
+ /etc/dbus-session.conf"
+
+if [ "$CROSS_BUILD" ]; then
+       configure_args+=" --with-bdb=${XBPS_CROSS_BASE}"
+fi
+
 post_install() {
        vsv netatalk
 }

```

Re: [PR REVIEW] New package: netatalk-3.1.15

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#discussion_r1264000575

Comment:
Taking over such generic file by random package look like bad idea, especially as current xbps will overwrite if it existed. Maybe install it in /usr/share/examples?

Re: [PR REVIEW] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 884 bytes --]

New review comment by bsdelf on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#discussion_r1264306004

Comment:
The "dbus-session.conf" can be relocated, other files should be fine. FreeBSD add suffix ".sample" to avoid the file conflict:

```
# pkg info -lx netatalk | grep -e etc -e share
        /usr/local/etc/afp.conf.sample
        /usr/local/etc/extmap.conf.sample
        /usr/local/etc/pam.d/netatalk.sample
        /usr/local/etc/rc.d/netatalk
        /usr/local/share/aclocal/netatalk.m4
        /usr/local/share/licenses/netatalk3-3.1.15,1/GPLv2
        /usr/local/share/licenses/netatalk3-3.1.15,1/LICENSE
        /usr/local/share/licenses/netatalk3-3.1.15,1/catalog.mk
```

> especially as current xbps will overwrite if it existed

I edited the afp.conf and then reinstalled the package, the afp.conf is not overwrote.

Re: [PR PATCH] [Updated] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by bsdelf against master on the void-packages repository

https://github.com/bsdelf/void-packages netatalk
https://github.com/void-linux/void-packages/pull/45011

New package: netatalk-3.1.15
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-netatalk-45011.patch --]
[-- Type: text/x-diff, Size: 1842 bytes --]

From 9f3e0810e621a8428917d185ee988369cfab4ce5 Mon Sep 17 00:00:00 2001
From: Yanhui Shen <shen.elf@gmail.com>
Date: Thu, 13 Jul 2023 15:30:27 +0800
Subject: [PATCH] New package: netatalk-3.1.15

---
 srcpkgs/netatalk/files/netatalk/run |  3 +++
 srcpkgs/netatalk/template           | 29 +++++++++++++++++++++++++++++
 2 files changed, 32 insertions(+)
 create mode 100755 srcpkgs/netatalk/files/netatalk/run
 create mode 100644 srcpkgs/netatalk/template

diff --git a/srcpkgs/netatalk/files/netatalk/run b/srcpkgs/netatalk/files/netatalk/run
new file mode 100755
index 000000000000..dee5dcfa309d
--- /dev/null
+++ b/srcpkgs/netatalk/files/netatalk/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec netatalk
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
new file mode 100644
index 000000000000..37d2cca5ae06
--- /dev/null
+++ b/srcpkgs/netatalk/template
@@ -0,0 +1,29 @@
+# Template file for 'netatalk'
+pkgname=netatalk
+version=3.1.15
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config"
+makedepends="acl-devel pam-devel libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
+depends="python3"
+short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
+maintainer="Yanhui Shen <shen.elf@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Netatalk/netatalk"
+distfiles="https://github.com/Netatalk/netatalk/releases/download/netatalk-${version//./-}/netatalk-${version}.tar.bz2"
+checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
+python_version=3
+
+conf_files="
+ /etc/dbus-1/system.d/netatalk-dbus.conf
+ /etc/extmap.conf
+ /etc/afp.conf
+ /etc/dbus-session.conf"
+
+if [ "$CROSS_BUILD" ]; then
+       configure_args+=" --with-bdb=${XBPS_CROSS_BASE}"
+fi
+
+post_install() {
+	vsv netatalk
+}

Re: [PR PATCH] [Updated] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by bsdelf against master on the void-packages repository

https://github.com/bsdelf/void-packages netatalk
https://github.com/void-linux/void-packages/pull/45011

New package: netatalk-3.1.15
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-netatalk-45011.patch --]
[-- Type: text/x-diff, Size: 1876 bytes --]

From a65183693294358ed20e7cb555eb97fce96a90d3 Mon Sep 17 00:00:00 2001
From: Yanhui Shen <shen.elf@gmail.com>
Date: Thu, 13 Jul 2023 15:30:27 +0800
Subject: [PATCH] New package: netatalk-3.1.15

---
 srcpkgs/netatalk/files/netatalk/run |  3 +++
 srcpkgs/netatalk/template           | 30 +++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)
 create mode 100755 srcpkgs/netatalk/files/netatalk/run
 create mode 100644 srcpkgs/netatalk/template

diff --git a/srcpkgs/netatalk/files/netatalk/run b/srcpkgs/netatalk/files/netatalk/run
new file mode 100755
index 000000000000..dee5dcfa309d
--- /dev/null
+++ b/srcpkgs/netatalk/files/netatalk/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec netatalk
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
new file mode 100644
index 000000000000..f9ede934f224
--- /dev/null
+++ b/srcpkgs/netatalk/template
@@ -0,0 +1,30 @@
+# Template file for 'netatalk'
+pkgname=netatalk
+version=3.1.15
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config"
+makedepends="acl-devel pam-devel libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
+depends="python3"
+short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
+maintainer="Yanhui Shen <shen.elf@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Netatalk/netatalk"
+distfiles="https://github.com/Netatalk/netatalk/releases/download/netatalk-${version//./-}/netatalk-${version}.tar.bz2"
+checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
+python_version=3
+
+conf_files="
+ /etc/dbus-1/system.d/netatalk-dbus.conf
+ /etc/extmap.conf
+ /etc/afp.conf
+ /etc/dbus-session.conf"
+
+if [ "$CROSS_BUILD" ]; then
+       configure_args+=" --with-bdb=${XBPS_CROSS_BASE}"
+fi
+
+post_install() {
+	vsconf config/dbus-session.conf
+	vsv netatalk
+}

Re: [PR PATCH] [Updated] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by bsdelf against master on the void-packages repository

https://github.com/bsdelf/void-packages netatalk
https://github.com/void-linux/void-packages/pull/45011

New package: netatalk-3.1.15
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-netatalk-45011.patch --]
[-- Type: text/x-diff, Size: 1897 bytes --]

From 30d764c5cdc48a86fe539170df2488738e4bdc5a Mon Sep 17 00:00:00 2001
From: Yanhui Shen <shen.elf@gmail.com>
Date: Thu, 13 Jul 2023 15:30:27 +0800
Subject: [PATCH] New package: netatalk-3.1.15

---
 srcpkgs/netatalk/files/netatalk/run |  3 +++
 srcpkgs/netatalk/template           | 30 +++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)
 create mode 100755 srcpkgs/netatalk/files/netatalk/run
 create mode 100644 srcpkgs/netatalk/template

diff --git a/srcpkgs/netatalk/files/netatalk/run b/srcpkgs/netatalk/files/netatalk/run
new file mode 100755
index 000000000000..dee5dcfa309d
--- /dev/null
+++ b/srcpkgs/netatalk/files/netatalk/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec netatalk
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
new file mode 100644
index 000000000000..edcb851fd1e4
--- /dev/null
+++ b/srcpkgs/netatalk/template
@@ -0,0 +1,30 @@
+# Template file for 'netatalk'
+pkgname=netatalk
+version=3.1.15
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config"
+makedepends="acl-devel pam-devel libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
+depends="python3"
+short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
+maintainer="Yanhui Shen <shen.elf@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Netatalk/netatalk"
+distfiles="https://github.com/Netatalk/netatalk/releases/download/netatalk-${version//./-}/netatalk-${version}.tar.bz2"
+checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
+python_version=3
+
+conf_files="
+ /etc/dbus-1/system.d/netatalk-dbus.conf
+ /etc/extmap.conf
+ /etc/afp.conf"
+
+if [ "$CROSS_BUILD" ]; then
+       configure_args+=" --with-bdb=${XBPS_CROSS_BASE}"
+fi
+
+post_install() {
+	vsv netatalk
+	vsconf ${DESTDIR}/etc/dbus-session.conf
+	rm ${DESTDIR}/etc/dbus-session.conf
+}

Re: [PR REVIEW] New package: netatalk-3.1.15

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New review comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#discussion_r1264362794

Comment:
> afp.conf is not overwrote

OK, sorry, new installs are fine and overwrite happens in slightly different conditions.

Re: New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 565 bytes --]

New comment by bsdelf on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1636715255

Comment:
Should I fix the lint?  Why is space not preferred by the way?

```
Error: please indent with tabs
```


> ```diff
> -conf_files="
> -       /etc/dbus-1/system.d/netatalk-dbus.conf
> -       /etc/extmap.conf
> -       /etc/afp.conf
> -       /etc/dbus-session.conf"
> 
> +conf_files="
> + /etc/dbus-1/system.d/netatalk-dbus.conf
> + /etc/extmap.conf
> + /etc/afp.conf
> + /etc/dbus-session.conf"
> ```

Re: New package: netatalk-3.1.15

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 299 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1636716474

Comment:
Preferred style is single space for variable continuation and tab in code blocks and functions. conf_files is fine, lint points at if block. Please adjust.

Re: [PR PATCH] [Updated] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by bsdelf against master on the void-packages repository

https://github.com/bsdelf/void-packages netatalk
https://github.com/void-linux/void-packages/pull/45011

New package: netatalk-3.1.15
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-netatalk-45011.patch --]
[-- Type: text/x-diff, Size: 1891 bytes --]

From 9fbc78bf4451fd37b51200e3121aea9b50c14ce2 Mon Sep 17 00:00:00 2001
From: Yanhui Shen <shen.elf@gmail.com>
Date: Thu, 13 Jul 2023 15:30:27 +0800
Subject: [PATCH] New package: netatalk-3.1.15

---
 srcpkgs/netatalk/files/netatalk/run |  3 +++
 srcpkgs/netatalk/template           | 30 +++++++++++++++++++++++++++++
 2 files changed, 33 insertions(+)
 create mode 100755 srcpkgs/netatalk/files/netatalk/run
 create mode 100644 srcpkgs/netatalk/template

diff --git a/srcpkgs/netatalk/files/netatalk/run b/srcpkgs/netatalk/files/netatalk/run
new file mode 100755
index 000000000000..dee5dcfa309d
--- /dev/null
+++ b/srcpkgs/netatalk/files/netatalk/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec netatalk
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
new file mode 100644
index 000000000000..6935ca7ab600
--- /dev/null
+++ b/srcpkgs/netatalk/template
@@ -0,0 +1,30 @@
+# Template file for 'netatalk'
+pkgname=netatalk
+version=3.1.15
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config"
+makedepends="acl-devel pam-devel libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
+depends="python3"
+short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
+maintainer="Yanhui Shen <shen.elf@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Netatalk/netatalk"
+distfiles="https://github.com/Netatalk/netatalk/releases/download/netatalk-${version//./-}/netatalk-${version}.tar.bz2"
+checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
+python_version=3
+
+conf_files="
+ /etc/dbus-1/system.d/netatalk-dbus.conf
+ /etc/extmap.conf
+ /etc/afp.conf"
+
+if [ "$CROSS_BUILD" ]; then
+	configure_args+=" --with-bdb=${XBPS_CROSS_BASE}"
+fi
+
+post_install() {
+	vsv netatalk
+	vsconf ${DESTDIR}/etc/dbus-session.conf
+	rm ${DESTDIR}/etc/dbus-session.conf
+}

Re: New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 195 bytes --]

New comment by bsdelf on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1636719190

Comment:
Updated and checked with xlint. Now it should be good.

Re: [PR PATCH] [Updated] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by bsdelf against master on the void-packages repository

https://github.com/bsdelf/void-packages netatalk
https://github.com/void-linux/void-packages/pull/45011

New package: netatalk-3.1.15
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-netatalk-45011.patch --]
[-- Type: text/x-diff, Size: 2550 bytes --]

From f574ace7b1a8421075806a6987cb1d9d91bca976 Mon Sep 17 00:00:00 2001
From: Yanhui Shen <shen.elf@gmail.com>
Date: Thu, 13 Jul 2023 15:30:27 +0800
Subject: [PATCH] New package: netatalk-3.1.15

---
 srcpkgs/netatalk-devel              |  1 +
 srcpkgs/netatalk/files/netatalk/run |  3 ++
 srcpkgs/netatalk/template           | 44 +++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 120000 srcpkgs/netatalk-devel
 create mode 100755 srcpkgs/netatalk/files/netatalk/run
 create mode 100644 srcpkgs/netatalk/template

diff --git a/srcpkgs/netatalk-devel b/srcpkgs/netatalk-devel
new file mode 120000
index 000000000000..83481f371fe7
--- /dev/null
+++ b/srcpkgs/netatalk-devel
@@ -0,0 +1 @@
+netatalk
\ No newline at end of file
diff --git a/srcpkgs/netatalk/files/netatalk/run b/srcpkgs/netatalk/files/netatalk/run
new file mode 100755
index 000000000000..47e1f4cd7d10
--- /dev/null
+++ b/srcpkgs/netatalk/files/netatalk/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -b netatalk pause
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
new file mode 100644
index 000000000000..8b46b8ba0131
--- /dev/null
+++ b/srcpkgs/netatalk/template
@@ -0,0 +1,44 @@
+# Template file for 'netatalk'
+pkgname=netatalk
+version=3.1.15
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config"
+makedepends="acl-devel pam-devel libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
+depends="python3"
+short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
+maintainer="Yanhui Shen <shen.elf@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Netatalk/netatalk"
+distfiles="https://github.com/Netatalk/netatalk/releases/download/netatalk-${version//./-}/netatalk-${version}.tar.bz2"
+checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
+python_version=3
+
+conf_files="
+ /etc/dbus-1/system.d/netatalk-dbus.conf
+ /etc/extmap.conf
+ /etc/afp.conf"
+
+if [ "$CROSS_BUILD" ]; then
+	configure_args+=" --with-bdb=${XBPS_CROSS_BASE}"
+fi
+
+post_install() {
+	vsv netatalk
+	vsconf ${DESTDIR}/etc/dbus-session.conf
+	rm ${DESTDIR}/etc/dbus-session.conf
+}
+
+netatalk-devel_package() {
+	depends="${sourcepkg}>=${version}_${reversion}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/bin/netatalk-config
+		vmove usr/include
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+		vmove "usr/lib/netatalk/*.a"
+		vmove usr/share/aclocal
+		vmove usr/share/man/man1/netatalk-config.1
+	}
+}

Re: New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 309 bytes --]

New comment by bsdelf on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1646787376

Comment:
Updated. The devel files are splitted, except "usr/lib/netatalk/*.so", they are dynamically loaded at runtime based on the configuration. Also I fixed the start script.

Re: New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 419 bytes --]

New comment by bsdelf on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1646792612

Comment:
Oh no, the current start script still has a issue. The afpd process no longer starts with following code: 

```
exec chpst -b netatalk pause
```

The tricky thing is `netatalk` does not support foreground running mode, is there a "standard way" to handle it in void runit?

Re: [PR PATCH] [Updated] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by bsdelf against master on the void-packages repository

https://github.com/bsdelf/void-packages netatalk
https://github.com/void-linux/void-packages/pull/45011

New package: netatalk-3.1.15
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-netatalk-45011.patch --]
[-- Type: text/x-diff, Size: 2544 bytes --]

From baf463b89318513249b9e99878cc7525b8314e91 Mon Sep 17 00:00:00 2001
From: Yanhui Shen <shen.elf@gmail.com>
Date: Thu, 13 Jul 2023 15:30:27 +0800
Subject: [PATCH] New package: netatalk-3.1.15

---
 srcpkgs/netatalk-devel              |  1 +
 srcpkgs/netatalk/files/netatalk/run |  3 ++
 srcpkgs/netatalk/template           | 44 +++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 120000 srcpkgs/netatalk-devel
 create mode 100755 srcpkgs/netatalk/files/netatalk/run
 create mode 100644 srcpkgs/netatalk/template

diff --git a/srcpkgs/netatalk-devel b/srcpkgs/netatalk-devel
new file mode 120000
index 0000000000000..83481f371fe75
--- /dev/null
+++ b/srcpkgs/netatalk-devel
@@ -0,0 +1 @@
+netatalk
\ No newline at end of file
diff --git a/srcpkgs/netatalk/files/netatalk/run b/srcpkgs/netatalk/files/netatalk/run
new file mode 100755
index 0000000000000..77a339c5d896c
--- /dev/null
+++ b/srcpkgs/netatalk/files/netatalk/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec netatalk -d
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
new file mode 100644
index 0000000000000..8b46b8ba01319
--- /dev/null
+++ b/srcpkgs/netatalk/template
@@ -0,0 +1,44 @@
+# Template file for 'netatalk'
+pkgname=netatalk
+version=3.1.15
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config"
+makedepends="acl-devel pam-devel libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
+depends="python3"
+short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
+maintainer="Yanhui Shen <shen.elf@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Netatalk/netatalk"
+distfiles="https://github.com/Netatalk/netatalk/releases/download/netatalk-${version//./-}/netatalk-${version}.tar.bz2"
+checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
+python_version=3
+
+conf_files="
+ /etc/dbus-1/system.d/netatalk-dbus.conf
+ /etc/extmap.conf
+ /etc/afp.conf"
+
+if [ "$CROSS_BUILD" ]; then
+	configure_args+=" --with-bdb=${XBPS_CROSS_BASE}"
+fi
+
+post_install() {
+	vsv netatalk
+	vsconf ${DESTDIR}/etc/dbus-session.conf
+	rm ${DESTDIR}/etc/dbus-session.conf
+}
+
+netatalk-devel_package() {
+	depends="${sourcepkg}>=${version}_${reversion}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/bin/netatalk-config
+		vmove usr/include
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+		vmove "usr/lib/netatalk/*.a"
+		vmove usr/share/aclocal
+		vmove usr/share/man/man1/netatalk-config.1
+	}
+}

Re: New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 608 bytes --]

New comment by bsdelf on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1671056336

Comment:
> The tricky thing is `netatalk` does not support foreground running mode, is there a "standard way" to handle it in void runit?

I fixed this issue by adding `-d` option to `netatalk` command, it's not mentioned in manual or help message, I found it in the source code, it prevents daemonize, which is required by runit.

Now the `sv start` and `sv stop` command is working, and the network location showing & disappering can be observed in macOS immediately. 

Re: New package: netatalk-3.1.15

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1800871167

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Updated] New package: netatalk-3.1.15

[bsdelf]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

There is an updated pull request by bsdelf against master on the void-packages repository

https://github.com/bsdelf/void-packages netatalk
https://github.com/void-linux/void-packages/pull/45011

New package: netatalk-3.1.15
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)



A patch file from https://github.com/void-linux/void-packages/pull/45011.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-netatalk-45011.patch --]
[-- Type: text/x-diff, Size: 2562 bytes --]

From 8a7e037e75e080d5f243ed875f7ac3fc9736daf1 Mon Sep 17 00:00:00 2001
From: Yanhui Shen <shen.elf@gmail.com>
Date: Thu, 13 Jul 2023 15:30:27 +0800
Subject: [PATCH] New package: netatalk-3.1.15

---
 srcpkgs/netatalk-devel              |  1 +
 srcpkgs/netatalk/files/netatalk/run |  3 ++
 srcpkgs/netatalk/template           | 44 +++++++++++++++++++++++++++++
 3 files changed, 48 insertions(+)
 create mode 120000 srcpkgs/netatalk-devel
 create mode 100755 srcpkgs/netatalk/files/netatalk/run
 create mode 100644 srcpkgs/netatalk/template

diff --git a/srcpkgs/netatalk-devel b/srcpkgs/netatalk-devel
new file mode 120000
index 00000000000000..83481f371fe75b
--- /dev/null
+++ b/srcpkgs/netatalk-devel
@@ -0,0 +1 @@
+netatalk
\ No newline at end of file
diff --git a/srcpkgs/netatalk/files/netatalk/run b/srcpkgs/netatalk/files/netatalk/run
new file mode 100755
index 00000000000000..47e1f4cd7d103c
--- /dev/null
+++ b/srcpkgs/netatalk/files/netatalk/run
@@ -0,0 +1,3 @@
+#!/bin/sh
+exec 2>&1
+exec chpst -b netatalk pause
diff --git a/srcpkgs/netatalk/template b/srcpkgs/netatalk/template
new file mode 100644
index 00000000000000..8b46b8ba01319c
--- /dev/null
+++ b/srcpkgs/netatalk/template
@@ -0,0 +1,44 @@
+# Template file for 'netatalk'
+pkgname=netatalk
+version=3.1.15
+revision=1
+build_style=gnu-configure
+hostmakedepends="autoconf pkg-config"
+makedepends="acl-devel pam-devel libgcrypt-devel db-devel libevent-devel avahi-libs-devel openssl-devel dbus-glib-devel"
+depends="python3"
+short_desc="Open Source fileserver that implements the Apple Filing Protocol (AFP)"
+maintainer="Yanhui Shen <shen.elf@gmail.com>"
+license="GPL-2.0-only"
+homepage="https://github.com/Netatalk/netatalk"
+distfiles="https://github.com/Netatalk/netatalk/releases/download/netatalk-${version//./-}/netatalk-${version}.tar.bz2"
+checksum=d8d4a5cc0fd86b0d90e017d64c1f4623e8cdbfbda570fc423ade1151a93d19f5
+python_version=3
+
+conf_files="
+ /etc/dbus-1/system.d/netatalk-dbus.conf
+ /etc/extmap.conf
+ /etc/afp.conf"
+
+if [ "$CROSS_BUILD" ]; then
+	configure_args+=" --with-bdb=${XBPS_CROSS_BASE}"
+fi
+
+post_install() {
+	vsv netatalk
+	vsconf ${DESTDIR}/etc/dbus-session.conf
+	rm ${DESTDIR}/etc/dbus-session.conf
+}
+
+netatalk-devel_package() {
+	depends="${sourcepkg}>=${version}_${reversion}"
+	short_desc+=" - development files"
+	pkg_install() {
+		vmove usr/bin/netatalk-config
+		vmove usr/include
+		vmove "usr/lib/*.a"
+		vmove "usr/lib/*.so"
+		vmove "usr/lib/netatalk/*.a"
+		vmove usr/share/aclocal
+		vmove usr/share/man/man1/netatalk-config.1
+	}
+}

Re: New package: netatalk-3.1.15

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/45011#issuecomment-1950746118

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: New package: netatalk-3.1.15

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 931 bytes --]

There's a closed pull request on the void-packages repository

New package: netatalk-3.1.15
https://github.com/void-linux/void-packages/pull/45011

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**


#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (x86_64)