Re: [ISSUE] [CLOSED] open-iscsi: Add a runit service (iscsid)

[leahneukirchen <leahneukirchen@users.noreply.github.com>]

[-- Attachment #1: Type: text/plain, Size: 1581 bytes --]

Closed issue by thetredev on void-packages repository

https://github.com/void-linux/void-packages/issues/40861

Description:
When the `open-iscsi` package is installed on Arch Linux, a systemd service is created which essentially calls `/usr/bin/iscsid -f` when started:
```shell
$ cat /etc/systemd/system/multi-user.target.wants/iscsid.service
[Unit]
Description=Open-iSCSI
Documentation=man:iscsid(8) man:iscsiuio(8) man:iscsiadm(8)
DefaultDependencies=no
After=network-online.target iscsiuio.service iscsi-init.service
Before=remote-fs-pre.target
Wants=remote-fs-pre.target
Requires=iscsi-init.service

[Service]
Type=notify
NotifyAccess=main
ExecStart=/usr/bin/iscsid -f  <-----
KillMode=mixed
Restart=on-failure

[Install]
WantedBy=multi-user.target
Also=iscsid.socket
```

I wanted to run Void as a server for testing purposes and I need `iscsid` to run on there. I've created the following service file as a first:
```shell
$ cat /etc/sv/iscsid/run 
#!/bin/sh
[ -r conf ] && . ./conf
exec iscsid -f

$ sv status /var/service/iscsid
run: /var/service/iscsid: (pid 825) 311s
```

`iscsiuio` doesn't start for me for some reason, but `iscsid` is happy as far as I can tell. I'm quite sure that `iscsi-init.service` is NOT needed, since that only creates a `/etc/iscsi/initiatorname.iscsi` file which either the XBPS package installation or `iscsid` already does (it was already present after I started `iscsid` manually when testing).

My question/request: Do we need that service? If so, is my `/etc/sv/iscsid/run` enough? :)
Thank you!