Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] singular: update to 4.3.2p3.
@ 2023-07-17 22:58 tornaria
  2023-07-18 13:35 ` dkwo
  2023-07-20 23:00 ` [PR PATCH] [Merged]: " Piraty
  0 siblings, 2 replies; 3+ messages in thread
From: tornaria @ 2023-07-17 22:58 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1577 bytes --]

There is a new pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages singular
https://github.com/void-linux/void-packages/pull/45096

singular: update to 4.3.2p3.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Tested with sagemath long testsuite.

This causes a single test failure in sagemath but in fact the new behaviour is less wrong than before (see: https://github.com/sagemath/sage/issues/35676#issuecomment-1638988622).

I'll fix the test failure in sagemath when we next update it. No need to hold this update.

Cc: @dkwo

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/45096.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-singular-45096.patch --]
[-- Type: text/x-diff, Size: 3497 bytes --]

From 6f510842f40e789b87316c6901df4adb50a508ba Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Mon, 17 Jul 2023 00:08:09 -0300
Subject: [PATCH] singular: update to 4.3.2p3.

---
 ...773d6c9e2f1d2593a28bc68b7eeab54ed529.patch | 39 -------------------
 srcpkgs/singular/template                     |  4 +-
 2 files changed, 2 insertions(+), 41 deletions(-)
 delete mode 100644 srcpkgs/singular/patches/8d54773d6c9e2f1d2593a28bc68b7eeab54ed529.patch

diff --git a/srcpkgs/singular/patches/8d54773d6c9e2f1d2593a28bc68b7eeab54ed529.patch b/srcpkgs/singular/patches/8d54773d6c9e2f1d2593a28bc68b7eeab54ed529.patch
deleted file mode 100644
index 425f2c659a9f..000000000000
--- a/srcpkgs/singular/patches/8d54773d6c9e2f1d2593a28bc68b7eeab54ed529.patch
+++ /dev/null
@@ -1,39 +0,0 @@
-From 8d54773d6c9e2f1d2593a28bc68b7eeab54ed529 Mon Sep 17 00:00:00 2001
-From: Hans Schoenemann <hannes@mathematik.uni-kl.de>
-Date: Mon, 5 Jun 2023 16:40:16 +0200
-Subject: [PATCH] use DESTDIR for "make install"
-
----
- Makefile.am | 16 ++++++++--------
- 1 file changed, 8 insertions(+), 8 deletions(-)
-
-diff --git a/Makefile.am b/Makefile.am
-index 922b21b734..2f1e5a7ec8 100644
---- a/Makefile.am
-+++ b/Makefile.am
-@@ -16,17 +16,17 @@ bin_SCRIPTS = libsingular-config
- 
- install-data-local:
- 	if test -e $(srcdir)/doc/doc.tbz2; then\
--	   test -e $(prefix)$(datadir) || mkdir -p $(prefix)$(datadir);\
--	   test -e $(prefix)$(datadir)/info || mkdir $(prefix)$(datadir)/info;\
--	   test -e $(prefix)$(datadir)/singular || mkdir $(prefix)$(datadir)/singular;\
--	   test -e $(prefix)$(htmldir) || mkdir -p $(prefix)$(htmldir);\
--	   (cat ${top_srcdir}/doc/doc.tbz2| (cd $(prefix)$(htmldir);tar -jx --no-same-owner -f -));\
--	   mv  $(prefix)$(htmldir)/singular.info  $(prefix)$(datadir)/info/.;\
--	   mv  $(prefix)$(htmldir)/singular.idx  $(prefix)$(datadir)/singular/.;\
-+	   test -e $(DESTDIR)$(datadir) || mkdir -p $(DESTDIR)$(datadir);\
-+	   test -e $(DESTDIR)$(datadir)/info || mkdir $(DESTDIR)$(datadir)/info;\
-+	   test -e $(DESTDIR)$(datadir)/singular || mkdir $(DESTDIR)$(datadir)/singular;\
-+	   test -e $(DESTDIR)$(htmldir) || mkdir -p $(DESTDIR)$(htmldir);\
-+	   (cat ${top_srcdir}/doc/doc.tbz2| (cd $(DESTDIR)$(htmldir);tar -jx --no-same-owner -f -));\
-+	   mv  $(DESTDIR)$(htmldir)/singular.info  $(DESTDIR)$(datadir)/info/.;\
-+	   mv  $(DESTDIR)$(htmldir)/singular.idx  $(DESTDIR)$(datadir)/singular/.;\
- 	fi
- 
- uninstall-local:
--	-(cd $(prefix)$(datadir); rm -rf singular info/singular.info)
-+	-(cd $(prefix); rm -rf singular info/singular.info)
- 
- configheaderdir = ${includedir}/singular
- nodist_configheader_HEADERS = singularconfig.h
diff --git a/srcpkgs/singular/template b/srcpkgs/singular/template
index 1beb36297a03..9ca59e4013d1 100644
--- a/srcpkgs/singular/template
+++ b/srcpkgs/singular/template
@@ -1,6 +1,6 @@
 # Template file for 'singular'
 pkgname=singular
-version=4.3.2p2
+version=4.3.2p3
 revision=1
 _majver=${version%p*}
 build_style=gnu-configure
@@ -20,7 +20,7 @@ maintainer="dkwo <npiazza@disroot.org>"
 license="GPL-2.0-or-later"
 homepage="https://www.singular.uni-kl.de"
 distfiles="https://www.singular.uni-kl.de/ftp/pub/Math/Singular/SOURCES/${_majver//./-}/singular-${version}.tar.gz"
-checksum=660ae93ace79db4209203770d93baf16b5b741dc26b6bae06c9b2c98ad188df1
+checksum=9f7cfc838eb16c976369e498845f69551a95c4bc9d6d6cfbb4657836aae5ff3e
 
 if [ -z "$CROSS_BUILD" ]; then
 	makedepends+=" ntl-devel"

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: singular: update to 4.3.2p3.
  2023-07-17 22:58 [PR PATCH] singular: update to 4.3.2p3 tornaria
@ 2023-07-18 13:35 ` dkwo
  2023-07-20 23:00 ` [PR PATCH] [Merged]: " Piraty
  1 sibling, 0 replies; 3+ messages in thread
From: dkwo @ 2023-07-18 13:35 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 157 bytes --]

New comment by dkwo on void-packages repository

https://github.com/void-linux/void-packages/pull/45096#issuecomment-1640241431

Comment:
Looks good to me.


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PR PATCH] [Merged]: singular: update to 4.3.2p3.
  2023-07-17 22:58 [PR PATCH] singular: update to 4.3.2p3 tornaria
  2023-07-18 13:35 ` dkwo
@ 2023-07-20 23:00 ` Piraty
  1 sibling, 0 replies; 3+ messages in thread
From: Piraty @ 2023-07-20 23:00 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1423 bytes --]

There's a merged pull request on the void-packages repository

singular: update to 4.3.2p3.
https://github.com/void-linux/void-packages/pull/45096

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Tested with sagemath long testsuite.

This causes a single test failure in sagemath but in fact the new behaviour is less wrong than before (see: https://github.com/sagemath/sage/issues/35676#issuecomment-1638988622).

I'll fix the test failure in sagemath when we next update it. No need to hold this update.

Cc: @dkwo

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2023-07-20 23:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-17 22:58 [PR PATCH] singular: update to 4.3.2p3 tornaria
2023-07-18 13:35 ` dkwo
2023-07-20 23:00 ` [PR PATCH] [Merged]: " Piraty

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).