[PR PATCH] goreleaser: add completion and README.md

Github messages for voidlinux
 help / color / mirror / Atom feed

* [PR PATCH] goreleaser: add completion and README.md
@ 2023-07-23 14:01 mchlumsky
  2023-07-23 14:04 ` [PR REVIEW] " classabbyamp
                   ` (7 more replies)
  0 siblings, 8 replies; 9+ messages in thread
From: mchlumsky @ 2023-07-23 14:01 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 481 bytes --]

There is a new pull request by mchlumsky against master on the void-packages repository

https://github.com/mchlumsky/void-packages add-readme-completion
https://github.com/void-linux/void-packages/pull/45205

goreleaser: add completion and README.md
#### Testing the changes
- I tested the changes in this PR: **YES**

- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/45205.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-readme-completion-45205.patch --]
[-- Type: text/x-diff, Size: 1151 bytes --]

From 2118cfdcfc9795ab5274e85a8a7df8b0c80b6f1e Mon Sep 17 00:00:00 2001
From: Martin Chlumsky <martin.chlumsky@gmail.com>
Date: Fri, 21 Jul 2023 13:16:26 -0400
Subject: [PATCH] goreleaser: add completion and README.md

---
 srcpkgs/goreleaser/template | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/goreleaser/template b/srcpkgs/goreleaser/template
index e245056d7d15b..c51af9e32ad80 100644
--- a/srcpkgs/goreleaser/template
+++ b/srcpkgs/goreleaser/template
@@ -1,7 +1,7 @@
 # Template file for 'goreleaser'
 pkgname=goreleaser
 version=1.19.2
-revision=1
+revision=2
 build_style=go
 go_import_path=github.com/goreleaser/goreleaser
 go_ldflags="-X main.version=${version}"
@@ -13,5 +13,14 @@ distfiles="https://github.com/goreleaser/goreleaser/archive/refs/tags/v$version.
 checksum=60e94d9371f7106878441deb006814339e3cf3d7f574d25cb22a9a45ec14939b
 
 post_install() {
+	vdoc README.md
+
 	vlicense LICENSE.md
+
+	goreleaser=$(find $GOPATH/bin -name goreleaser)
+
+	for shell in bash fish zsh; do
+		${goreleaser} completion ${shell} > completion.${shell}
+		vcompletion completion.${shell} ${shell}
+	done
 }

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] goreleaser: add completion and README.md
  2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
@ 2023-07-23 14:04 ` classabbyamp
  2023-07-23 14:09 ` [PR PATCH] [Updated] " mchlumsky
                   ` (6 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-07-23 14:04 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45205#discussion_r1271453690

Comment:
don't think this is useful, the only documentation-ish thing in that readme is

![image](https://github.com/void-linux/void-packages/assets/5366828/9a0d81c2-674f-4417-b48d-760fdd63920a)

which users already can see with `xbps-query -p homepage goreleaser`

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] goreleaser: add completion and README.md
  2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
  2023-07-23 14:04 ` [PR REVIEW] " classabbyamp
@ 2023-07-23 14:09 ` mchlumsky
  2023-07-23 14:10 ` [PR REVIEW] goreleaser: add completion mchlumsky
                   ` (5 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mchlumsky @ 2023-07-23 14:09 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 486 bytes --]

There is an updated pull request by mchlumsky against master on the void-packages repository

https://github.com/mchlumsky/void-packages add-readme-completion
https://github.com/void-linux/void-packages/pull/45205

goreleaser: add completion and README.md
#### Testing the changes
- I tested the changes in this PR: **YES**

- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/45205.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-readme-completion-45205.patch --]
[-- Type: text/x-diff, Size: 1032 bytes --]

From d7c3c807d914df013d7bb4744a433ff0b5d7312f Mon Sep 17 00:00:00 2001
From: Martin Chlumsky <martin.chlumsky@gmail.com>
Date: Fri, 21 Jul 2023 13:16:26 -0400
Subject: [PATCH] goreleaser: add completion

---
 srcpkgs/goreleaser/template | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/goreleaser/template b/srcpkgs/goreleaser/template
index e245056d7d15b..296a81900d2ee 100644
--- a/srcpkgs/goreleaser/template
+++ b/srcpkgs/goreleaser/template
@@ -1,7 +1,7 @@
 # Template file for 'goreleaser'
 pkgname=goreleaser
 version=1.19.2
-revision=1
+revision=2
 build_style=go
 go_import_path=github.com/goreleaser/goreleaser
 go_ldflags="-X main.version=${version}"
@@ -14,4 +14,11 @@ checksum=60e94d9371f7106878441deb006814339e3cf3d7f574d25cb22a9a45ec14939b
 
 post_install() {
 	vlicense LICENSE.md
+
+	goreleaser=$(find $GOPATH/bin -name goreleaser)
+
+	for shell in bash fish zsh; do
+		${goreleaser} completion ${shell} > completion.${shell}
+		vcompletion completion.${shell} ${shell}
+	done
 }

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] goreleaser: add completion
  2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
  2023-07-23 14:04 ` [PR REVIEW] " classabbyamp
  2023-07-23 14:09 ` [PR PATCH] [Updated] " mchlumsky
@ 2023-07-23 14:10 ` mchlumsky
  2023-07-23 14:14 ` classabbyamp
                   ` (4 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: mchlumsky @ 2023-07-23 14:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by mchlumsky on void-packages repository

https://github.com/void-linux/void-packages/pull/45205#discussion_r1271454840

Comment:
Understood. I dropped it.

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] goreleaser: add completion
  2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
                   ` (2 preceding siblings ...)
  2023-07-23 14:10 ` [PR REVIEW] goreleaser: add completion mchlumsky
@ 2023-07-23 14:14 ` classabbyamp
  2023-07-23 14:14 ` classabbyamp
                   ` (3 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-07-23 14:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 208 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45205#discussion_r1271455227

Comment:
```suggestion
build_style=go
build_helper="qemu"
```

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] goreleaser: add completion
  2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
                   ` (3 preceding siblings ...)
  2023-07-23 14:14 ` classabbyamp
@ 2023-07-23 14:14 ` classabbyamp
  2023-07-23 22:12 ` [PR PATCH] [Updated] " mchlumsky
                   ` (2 subsequent siblings)
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-07-23 14:14 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 241 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45205#discussion_r1271455280

Comment:
```suggestion
		vtargetrun ${goreleaser} completion ${shell} > completion.${shell}
```

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Updated] goreleaser: add completion
  2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
                   ` (4 preceding siblings ...)
  2023-07-23 14:14 ` classabbyamp
@ 2023-07-23 22:12 ` mchlumsky
  2023-07-23 22:20 ` [PR REVIEW] " mchlumsky
  2023-07-24 13:45 ` [PR PATCH] [Merged]: " classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: mchlumsky @ 2023-07-23 22:12 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

There is an updated pull request by mchlumsky against master on the void-packages repository

https://github.com/mchlumsky/void-packages add-readme-completion
https://github.com/void-linux/void-packages/pull/45205

goreleaser: add completion
#### Testing the changes
- I tested the changes in this PR: **YES**

- I built this PR locally for my native architecture, x86_64-glibc

A patch file from https://github.com/void-linux/void-packages/pull/45205.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-add-readme-completion-45205.patch --]
[-- Type: text/x-diff, Size: 1131 bytes --]

From ebe8c44fa1faee1f0e78dd578ec60a83c40ad7c9 Mon Sep 17 00:00:00 2001
From: Martin Chlumsky <martin.chlumsky@gmail.com>
Date: Fri, 21 Jul 2023 13:16:26 -0400
Subject: [PATCH] goreleaser: add completion

---
 srcpkgs/goreleaser/template | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/goreleaser/template b/srcpkgs/goreleaser/template
index e245056d7d15b..db93f6aa267a8 100644
--- a/srcpkgs/goreleaser/template
+++ b/srcpkgs/goreleaser/template
@@ -1,8 +1,9 @@
 # Template file for 'goreleaser'
 pkgname=goreleaser
 version=1.19.2
-revision=1
+revision=2
 build_style=go
+build_helper="qemu"
 go_import_path=github.com/goreleaser/goreleaser
 go_ldflags="-X main.version=${version}"
 short_desc="Deliver Go binaries as fast and easily as possible"
@@ -14,4 +15,11 @@ checksum=60e94d9371f7106878441deb006814339e3cf3d7f574d25cb22a9a45ec14939b
 
 post_install() {
 	vlicense LICENSE.md
+
+	goreleaser=$(find $GOPATH/bin -name goreleaser)
+
+	for shell in bash fish zsh; do
+		vtargetrun ${goreleaser} completion ${shell} > completion.${shell}
+		vcompletion completion.${shell} ${shell}
+	done
 }

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR REVIEW] goreleaser: add completion
  2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
                   ` (5 preceding siblings ...)
  2023-07-23 22:12 ` [PR PATCH] [Updated] " mchlumsky
@ 2023-07-23 22:20 ` mchlumsky
  2023-07-24 13:45 ` [PR PATCH] [Merged]: " classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: mchlumsky @ 2023-07-23 22:20 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 175 bytes --]

New review comment by mchlumsky on void-packages repository

https://github.com/void-linux/void-packages/pull/45205#discussion_r1271567327

Comment:
That fixed it. Thank you!

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [PR PATCH] [Merged]: goreleaser: add completion
  2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
                   ` (6 preceding siblings ...)
  2023-07-23 22:20 ` [PR REVIEW] " mchlumsky
@ 2023-07-24 13:45 ` classabbyamp
  7 siblings, 0 replies; 9+ messages in thread
From: classabbyamp @ 2023-07-24 13:45 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 298 bytes --]

There's a merged pull request on the void-packages repository

goreleaser: add completion
https://github.com/void-linux/void-packages/pull/45205

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

- I built this PR locally for my native architecture, x86_64-glibc

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2023-07-24 13:45 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-23 14:01 [PR PATCH] goreleaser: add completion and README.md mchlumsky
2023-07-23 14:04 ` [PR REVIEW] " classabbyamp
2023-07-23 14:09 ` [PR PATCH] [Updated] " mchlumsky
2023-07-23 14:10 ` [PR REVIEW] goreleaser: add completion mchlumsky
2023-07-23 14:14 ` classabbyamp
2023-07-23 14:14 ` classabbyamp
2023-07-23 22:12 ` [PR PATCH] [Updated] " mchlumsky
2023-07-23 22:20 ` [PR REVIEW] " mchlumsky
2023-07-24 13:45 ` [PR PATCH] [Merged]: " classabbyamp

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).