[PR PATCH] dbeaver: update to 23.1.0.

[PR PATCH] dbeaver: update to 23.1.0.

[ar-jan]

[-- Attachment #1: Type: text/plain, Size: 473 bytes --]

There is a new pull request by ar-jan against master on the void-packages repository

https://github.com/ar-jan/void-packages dbeaver2310
https://github.com/void-linux/void-packages/pull/44299

dbeaver: update to 23.1.0.
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



A patch file from https://github.com/void-linux/void-packages/pull/44299.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-dbeaver2310-44299.patch --]
[-- Type: text/x-diff, Size: 1487 bytes --]

From a0d255d317ed5bf4ecc62f2e1e74da7cf6eaa846 Mon Sep 17 00:00:00 2001
From: Arjan Mossel <arjanmossel@gmail.com>
Date: Tue, 6 Jun 2023 16:47:01 +0200
Subject: [PATCH] dbeaver: update to 23.1.0.

---
 srcpkgs/dbeaver/files/dbeaver.desktop | 3 +--
 srcpkgs/dbeaver/template              | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/srcpkgs/dbeaver/files/dbeaver.desktop b/srcpkgs/dbeaver/files/dbeaver.desktop
index 1eb3eba5b99d..ecb376d39cbb 100644
--- a/srcpkgs/dbeaver/files/dbeaver.desktop
+++ b/srcpkgs/dbeaver/files/dbeaver.desktop
@@ -1,9 +1,8 @@
 [Desktop Entry]
 Name=DBeaver
 Comment=SQL Integrated Development Environment
-Icon=dbeaver
+Icon=/usr/lib/dbeaver/icon.xpm
 Exec=dbeaver
 Terminal=false
 Type=Application
 Categories=Development
-
diff --git a/srcpkgs/dbeaver/template b/srcpkgs/dbeaver/template
index d207598988d8..de239d96902c 100644
--- a/srcpkgs/dbeaver/template
+++ b/srcpkgs/dbeaver/template
@@ -1,6 +1,6 @@
 # Template file for 'dbeaver'
 pkgname=dbeaver
-version=23.0.5
+version=23.1.0
 revision=1
 # the build downloads binaries linked to glibc
 archs="x86_64 aarch64"
@@ -12,7 +12,7 @@ license="Apache-2.0"
 homepage="https://dbeaver.io"
 changelog="https://dbeaver.io/news/"
 distfiles="https://github.com/dbeaver/dbeaver/archive/${version}.tar.gz"
-checksum=55261bcdf16635347a42f8f8059df4368c88da79bbf4e458f0f648a8ab03e7e1
+checksum=85df98086b9984c4379382077f90bee60231fd04e1ccde120e9422e29a462218
 nopie=true
 
 do_build() {

Re: [PR PATCH] [Merged]: dbeaver: update to 23.1.0.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

There's a merged pull request on the void-packages repository

dbeaver: update to 23.1.0.
https://github.com/void-linux/void-packages/pull/44299

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

Re: [PR REVIEW] dbeaver: update to 23.1.0.

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 289 bytes --]

New review comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/44299#discussion_r1274583231

Comment:
@ar-jan why did you change the icon path?
this will break other icon like `papirus-icons` which already provide default icon from the theme.

Re: [PR REVIEW] dbeaver: update to 23.1.0.

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 547 bytes --]

New review comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/44299#discussion_r1274597851

Comment:
most linux distributions use `Icon=dbeaver`
reference:
- nixos: https://github.com/NixOS/nixpkgs/blob/b80a9abe3f9bb1fd059b007bd16ee11f6adf1663/pkgs/applications/misc/dbeaver/default.nix#L63
- archlinux: https://gitlab.archlinux.org/archlinux/packaging/packages/dbeaver/-/blob/main/io.dbeaver.DBeaver.desktop#L11
- solus: https://dev.getsol.us/source/dbeaver/browse/master/files/DBeaver.desktop$6

Re: [PR REVIEW] dbeaver: update to 23.1.0.

[ar-jan]

[-- Attachment #1: Type: text/plain, Size: 316 bytes --]

New review comment by ar-jan on void-packages repository

https://github.com/void-linux/void-packages/pull/44299#discussion_r1274600185

Comment:
`Icon=dbeaver` never worked for me so I had no icon for dbeaver (I use KDE5 Plasma). I wasn't aware this change would break other configs, how does `papirus-icons` work?

Re: [PR REVIEW] dbeaver: update to 23.1.0.

[hervyqa]

[-- Attachment #1: Type: text/plain, Size: 199 bytes --]

New review comment by hervyqa on void-packages repository

https://github.com/void-linux/void-packages/pull/44299#discussion_r1274603875

Comment:
didn't work, `papirus-icon-theme` couldn't read it.