[PR PATCH] cavestory: fix unwritable save

[PR PATCH] cavestory: fix unwritable save

[pbindle]

[-- Attachment #1: Type: text/plain, Size: 1599 bytes --]

There is a new pull request by pbindle against master on the void-packages repository

https://github.com/pbindle/void-packages cavestory
https://github.com/void-linux/void-packages/pull/43690

cavestory: fix unwritable save
The save file is always located in a file called `Profile.dat` next to the executable, but since that is installed, normally, in a root owned directory, when someone tries to play the game it wouldn't save because it couldn't write to the file (although the game provided no error message). This change just adds an empty `Profile.dat` with 666 perms.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43690.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cavestory-43690.patch --]
[-- Type: text/x-diff, Size: 1708 bytes --]

From c2f30995f467f130697b04a81b09a09f9ff72ed2 Mon Sep 17 00:00:00 2001
From: Philoponus Bindle <pbindle@users.noreply.github.com>
Date: Thu, 27 Apr 2023 21:38:21 -0400
Subject: [PATCH] cavestory: fix unwritable save

The save file is always located in a file called "Profile.dat" next
to the executable. When installed normally and someone tries to play
the game, the game wouldn't save because it couldn't write to the
file (but provided no error message).
---
 srcpkgs/cavestory/template | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/cavestory/template b/srcpkgs/cavestory/template
index c7e9ea106d1e..72575d8d3174 100644
--- a/srcpkgs/cavestory/template
+++ b/srcpkgs/cavestory/template
@@ -1,7 +1,7 @@
 # Template file for 'cavestory'
 pkgname=cavestory
 version=1.2
-revision=2
+revision=3
 archs="x86_64 i686"
 create_wrksrc=yes
 short_desc="Japanese side-scrolling platformer game"
@@ -14,6 +14,7 @@ checksum="76466fc1b1901ce25e301a4ec8450aced806c9d499d66707d6f7b38efebc24c1
  a8711393c86cb6a7c6786883b22aed814f0e819cf935f8b273cb9dc5d58cfc6b"
 repository=nonfree
 nopie=yes
+nocheckperms=yes # The save is always placed next to the executable
 
 do_install() {
 	vmkdir usr/libexec/cavestory
@@ -23,6 +24,8 @@ do_install() {
 	vdoc linuxDoukutsu-1.01/doc/configfileformat.txt
 	vinstall linuxDoukutsu-${version}/doukutsu_${XBPS_TARGET_WORDSIZE}bits \
 		755 usr/libexec/cavestory doukutsu.bin
+	touch ${PKGDESTDIR}/usr/libexec/cavestory/Profile.dat
+	chmod 666 ${PKGDESTDIR}/usr/libexec/cavestory/Profile.dat
 	vbin ${FILESDIR}/cavestory
 	vinstall ${FILESDIR}/cavestory.desktop 644 usr/share/applications/
 	vinstall ${FILESDIR}/cavestory.png 644 usr/share/pixmaps/

Re: [PR PATCH] [Updated] cavestory: fix unwritable save

[pbindle]

[-- Attachment #1: Type: text/plain, Size: 1604 bytes --]

There is an updated pull request by pbindle against master on the void-packages repository

https://github.com/pbindle/void-packages cavestory
https://github.com/void-linux/void-packages/pull/43690

cavestory: fix unwritable save
The save file is always located in a file called `Profile.dat` next to the executable, but since that is installed, normally, in a root owned directory, when someone tries to play the game it wouldn't save because it couldn't write to the file (although the game provided no error message). This change just adds an empty `Profile.dat` with 666 perms.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/43690.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-cavestory-43690.patch --]
[-- Type: text/x-diff, Size: 1707 bytes --]

From 96e002f2f064f96f2e836e54ba04fef82cbbccdb Mon Sep 17 00:00:00 2001
From: Philoponus Bindle <philoponus-bindle@protonmail.com>
Date: Mon, 1 May 2023 12:49:09 -0400
Subject: [PATCH] cavestory: fix unwritable save

The save file is always located in a file called "Profile.dat" next
to the executable. When installed normally and someone tries to play
the game, the game wouldn't save because it couldn't write to the
file (but provided no error message).
---
 srcpkgs/cavestory/template | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/srcpkgs/cavestory/template b/srcpkgs/cavestory/template
index c7e9ea106d1e..72575d8d3174 100644
--- a/srcpkgs/cavestory/template
+++ b/srcpkgs/cavestory/template
@@ -1,7 +1,7 @@
 # Template file for 'cavestory'
 pkgname=cavestory
 version=1.2
-revision=2
+revision=3
 archs="x86_64 i686"
 create_wrksrc=yes
 short_desc="Japanese side-scrolling platformer game"
@@ -14,6 +14,7 @@ checksum="76466fc1b1901ce25e301a4ec8450aced806c9d499d66707d6f7b38efebc24c1
  a8711393c86cb6a7c6786883b22aed814f0e819cf935f8b273cb9dc5d58cfc6b"
 repository=nonfree
 nopie=yes
+nocheckperms=yes # The save is always placed next to the executable
 
 do_install() {
 	vmkdir usr/libexec/cavestory
@@ -23,6 +24,8 @@ do_install() {
 	vdoc linuxDoukutsu-1.01/doc/configfileformat.txt
 	vinstall linuxDoukutsu-${version}/doukutsu_${XBPS_TARGET_WORDSIZE}bits \
 		755 usr/libexec/cavestory doukutsu.bin
+	touch ${PKGDESTDIR}/usr/libexec/cavestory/Profile.dat
+	chmod 666 ${PKGDESTDIR}/usr/libexec/cavestory/Profile.dat
 	vbin ${FILESDIR}/cavestory
 	vinstall ${FILESDIR}/cavestory.desktop 644 usr/share/applications/
 	vinstall ${FILESDIR}/cavestory.png 644 usr/share/pixmaps/

Re: cavestory: fix unwritable save

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/pull/43690#issuecomment-1657378142

Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that.  If this pull request is still relevant bump it or assign it.

Re: [PR PATCH] [Closed]: cavestory: fix unwritable save

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1446 bytes --]

There's a closed pull request on the void-packages repository

cavestory: fix unwritable save
https://github.com/void-linux/void-packages/pull/43690

Description:
The save file is always located in a file called `Profile.dat` next to the executable, but since that is installed, normally, in a root owned directory, when someone tries to play the game it wouldn't save because it couldn't write to the file (although the game provided no error message). This change just adds an empty `Profile.dat` with 666 perms.

<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->