Github messages for voidlinux
 help / color / mirror / Atom feed
From: BlindRepublic <BlindRepublic@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: [PR PATCH] [Updated] steam: Create -devices subpackge for device udev rules
Date: Mon, 31 Jul 2023 04:41:58 +0200	[thread overview]
Message-ID: <20230731024158.27AmRVEtD0RIaBzx8tRsEqLrXGgpLKQsg0Cr96Y1d0A@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45338@inbox.vuxu.org>

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

There is an updated pull request by BlindRepublic against master on the void-packages repository

https://github.com/BlindRepublic/void-packages steam_devices
https://github.com/void-linux/void-packages/pull/45338

steam: Create -devices subpackge for device udev rules
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)

#### Note
The purpose of splitting the Udev rules into a separate package is to allow users to install the Steam Flatpak and use controllers without having to manually create the rules themselves. Other distributions such as Fedora do this and launching the Flatpak without these rules prompts a message telling the user to install a `steam-devices` package.


A patch file from https://github.com/void-linux/void-packages/pull/45338.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-steam_devices-45338.patch --]
[-- Type: text/x-diff, Size: 2525 bytes --]

From 8092842d0338ad755fd322aff7858071a6f841f1 Mon Sep 17 00:00:00 2001
From: Elliot <BlindRepublic@mailo.com>
Date: Sun, 30 Jul 2023 22:18:20 -0400
Subject: [PATCH] steam: Create -udev-rules subpackge for device udev rules

---
 srcpkgs/steam-udev-rules |  1 +
 srcpkgs/steam/template   | 27 ++++++++++++++++-----------
 2 files changed, 17 insertions(+), 11 deletions(-)
 create mode 120000 srcpkgs/steam-udev-rules

diff --git a/srcpkgs/steam-udev-rules b/srcpkgs/steam-udev-rules
new file mode 120000
index 0000000000000..9fe3d96896344
--- /dev/null
+++ b/srcpkgs/steam-udev-rules
@@ -0,0 +1 @@
+steam
\ No newline at end of file
diff --git a/srcpkgs/steam/template b/srcpkgs/steam/template
index 80d9aa80e6105..5a4ce377d558e 100644
--- a/srcpkgs/steam/template
+++ b/srcpkgs/steam/template
@@ -1,10 +1,10 @@
 # Template file for 'steam'
 pkgname=steam
 version=1.0.0.78
-revision=1
+revision=2
 archs="i686 x86_64"
 depends="zenity xz curl dbus freetype gdk-pixbuf hicolor-icon-theme desktop-file-utils
- liberation-fonts-ttf file tar bash coreutils lsof"
+ liberation-fonts-ttf file tar bash coreutils lsof steam-udev-rules"
 short_desc="Digital distribution client bootstrap package - Valve's steam client"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom: Proprietary license"
@@ -21,15 +21,20 @@ do_install() {
 	# Ignore steamdeps.
 	ln -sf /bin/true ${DESTDIR}/usr/bin/steamdeps
 
-	# Steam Controller support: need read-write access to
-	# Valve-owned input event device nodes.
-	# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
-	vinstall ${FILESDIR}/99-steam-controller-perms.rules 644 usr/lib/udev/rules.d
-
-	# Device support for Steam-related hardware (e.g. controllers over Steam Link)
-	vinstall ${FILESDIR}/60-steam-input.rules 644 usr/lib/udev/rules.d
-	vinstall ${FILESDIR}/60-steam-vr.rules 644 usr/lib/udev/rules.d
-
 	# Void-specific documentation.
 	vdoc "${FILESDIR}/README.voidlinux"
 }
+
+steam-udev-rules_package() {
+	short_desc+=" - udev rules for hardware"
+	pkg_install() {
+		# Steam Controller support: need read-write access to
+		# Valve-owned input event device nodes.
+		# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
+		vinstall ${FILESDIR}/99-steam-controller-perms.rules 644 usr/lib/udev/rules.d
+
+		# Device support for Steam-related hardware (e.g. controllers over Steam Link)
+		vinstall ${FILESDIR}/60-steam-input.rules 644 usr/lib/udev/rules.d
+		vinstall ${FILESDIR}/60-steam-vr.rules 644 usr/lib/udev/rules.d
+	}
+}

  parent reply	other threads:[~2023-07-31  2:41 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-31  2:26 [PR PATCH] " BlindRepublic
2023-07-31  2:38 ` ahesford
2023-07-31  2:41 ` BlindRepublic [this message]
2023-08-05 20:56 ` [PR REVIEW] steam: Create -udev-rules " classabbyamp
2023-08-06  3:36 ` [PR PATCH] [Updated] " classabbyamp
2023-08-06  3:39 ` [PR PATCH] [Merged]: " classabbyamp

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230731024158.27AmRVEtD0RIaBzx8tRsEqLrXGgpLKQsg0Cr96Y1d0A@z \
    --to=blindrepublic@users.noreply.github.com \
    --cc=ml@inbox.vuxu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).