[PR PATCH] steam: Create -devices subpackge for device udev rules

[PR PATCH] steam: Create -devices subpackge for device udev rules

[BlindRepublic]

[-- Attachment #1: Type: text/plain, Size: 1145 bytes --]

There is a new pull request by BlindRepublic against master on the void-packages repository

https://github.com/BlindRepublic/void-packages steam_devices
https://github.com/void-linux/void-packages/pull/45338

steam: Create -devices subpackge for device udev rules
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)


A patch file from https://github.com/void-linux/void-packages/pull/45338.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-steam_devices-45338.patch --]
[-- Type: text/x-diff, Size: 2500 bytes --]

From 265d1f407e126a1ad97991dfefa8c363d290e2ec Mon Sep 17 00:00:00 2001
From: Elliot <BlindRepublic@mailo.com>
Date: Sun, 30 Jul 2023 22:18:20 -0400
Subject: [PATCH] steam: Create -devices subpackge for device udev rules

---
 srcpkgs/steam-devices  |  1 +
 srcpkgs/steam/template | 27 ++++++++++++++++-----------
 2 files changed, 17 insertions(+), 11 deletions(-)
 create mode 120000 srcpkgs/steam-devices

diff --git a/srcpkgs/steam-devices b/srcpkgs/steam-devices
new file mode 120000
index 0000000000000..9fe3d96896344
--- /dev/null
+++ b/srcpkgs/steam-devices
@@ -0,0 +1 @@
+steam
\ No newline at end of file
diff --git a/srcpkgs/steam/template b/srcpkgs/steam/template
index 80d9aa80e6105..6287913a35101 100644
--- a/srcpkgs/steam/template
+++ b/srcpkgs/steam/template
@@ -1,10 +1,10 @@
 # Template file for 'steam'
 pkgname=steam
 version=1.0.0.78
-revision=1
+revision=2
 archs="i686 x86_64"
 depends="zenity xz curl dbus freetype gdk-pixbuf hicolor-icon-theme desktop-file-utils
- liberation-fonts-ttf file tar bash coreutils lsof"
+ liberation-fonts-ttf file tar bash coreutils lsof steam-devices"
 short_desc="Digital distribution client bootstrap package - Valve's steam client"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom: Proprietary license"
@@ -21,15 +21,20 @@ do_install() {
 	# Ignore steamdeps.
 	ln -sf /bin/true ${DESTDIR}/usr/bin/steamdeps
 
-	# Steam Controller support: need read-write access to
-	# Valve-owned input event device nodes.
-	# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
-	vinstall ${FILESDIR}/99-steam-controller-perms.rules 644 usr/lib/udev/rules.d
-
-	# Device support for Steam-related hardware (e.g. controllers over Steam Link)
-	vinstall ${FILESDIR}/60-steam-input.rules 644 usr/lib/udev/rules.d
-	vinstall ${FILESDIR}/60-steam-vr.rules 644 usr/lib/udev/rules.d
-
 	# Void-specific documentation.
 	vdoc "${FILESDIR}/README.voidlinux"
 }
+
+steam-devices_package() {
+	short_desc+=" - udev rules for hardware"
+	pkg_install() {
+		# Steam Controller support: need read-write access to
+		# Valve-owned input event device nodes.
+		# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
+		vinstall ${FILESDIR}/99-steam-controller-perms.rules 644 usr/lib/udev/rules.d
+
+		# Device support for Steam-related hardware (e.g. controllers over Steam Link)
+		vinstall ${FILESDIR}/60-steam-input.rules 644 usr/lib/udev/rules.d
+		vinstall ${FILESDIR}/60-steam-vr.rules 644 usr/lib/udev/rules.d
+	}
+}

Re: steam: Create -devices subpackge for device udev rules

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 305 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/45338#issuecomment-1657409692

Comment:
For consistency with most of the other packages that split like this, and to be as obvious as possible, the package should probably be called `steam-udev-rules`. 

Re: [PR PATCH] [Updated] steam: Create -devices subpackge for device udev rules

[BlindRepublic]

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

There is an updated pull request by BlindRepublic against master on the void-packages repository

https://github.com/BlindRepublic/void-packages steam_devices
https://github.com/void-linux/void-packages/pull/45338

steam: Create -devices subpackge for device udev rules
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)

#### Note
The purpose of splitting the Udev rules into a separate package is to allow users to install the Steam Flatpak and use controllers without having to manually create the rules themselves. Other distributions such as Fedora do this and launching the Flatpak without these rules prompts a message telling the user to install a `steam-devices` package.


A patch file from https://github.com/void-linux/void-packages/pull/45338.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-steam_devices-45338.patch --]
[-- Type: text/x-diff, Size: 2525 bytes --]

From 8092842d0338ad755fd322aff7858071a6f841f1 Mon Sep 17 00:00:00 2001
From: Elliot <BlindRepublic@mailo.com>
Date: Sun, 30 Jul 2023 22:18:20 -0400
Subject: [PATCH] steam: Create -udev-rules subpackge for device udev rules

---
 srcpkgs/steam-udev-rules |  1 +
 srcpkgs/steam/template   | 27 ++++++++++++++++-----------
 2 files changed, 17 insertions(+), 11 deletions(-)
 create mode 120000 srcpkgs/steam-udev-rules

diff --git a/srcpkgs/steam-udev-rules b/srcpkgs/steam-udev-rules
new file mode 120000
index 0000000000000..9fe3d96896344
--- /dev/null
+++ b/srcpkgs/steam-udev-rules
@@ -0,0 +1 @@
+steam
\ No newline at end of file
diff --git a/srcpkgs/steam/template b/srcpkgs/steam/template
index 80d9aa80e6105..5a4ce377d558e 100644
--- a/srcpkgs/steam/template
+++ b/srcpkgs/steam/template
@@ -1,10 +1,10 @@
 # Template file for 'steam'
 pkgname=steam
 version=1.0.0.78
-revision=1
+revision=2
 archs="i686 x86_64"
 depends="zenity xz curl dbus freetype gdk-pixbuf hicolor-icon-theme desktop-file-utils
- liberation-fonts-ttf file tar bash coreutils lsof"
+ liberation-fonts-ttf file tar bash coreutils lsof steam-udev-rules"
 short_desc="Digital distribution client bootstrap package - Valve's steam client"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom: Proprietary license"
@@ -21,15 +21,20 @@ do_install() {
 	# Ignore steamdeps.
 	ln -sf /bin/true ${DESTDIR}/usr/bin/steamdeps
 
-	# Steam Controller support: need read-write access to
-	# Valve-owned input event device nodes.
-	# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
-	vinstall ${FILESDIR}/99-steam-controller-perms.rules 644 usr/lib/udev/rules.d
-
-	# Device support for Steam-related hardware (e.g. controllers over Steam Link)
-	vinstall ${FILESDIR}/60-steam-input.rules 644 usr/lib/udev/rules.d
-	vinstall ${FILESDIR}/60-steam-vr.rules 644 usr/lib/udev/rules.d
-
 	# Void-specific documentation.
 	vdoc "${FILESDIR}/README.voidlinux"
 }
+
+steam-udev-rules_package() {
+	short_desc+=" - udev rules for hardware"
+	pkg_install() {
+		# Steam Controller support: need read-write access to
+		# Valve-owned input event device nodes.
+		# See https://bugs.launchpad.net/ubuntu/+source/steam/+bug/1498655
+		vinstall ${FILESDIR}/99-steam-controller-perms.rules 644 usr/lib/udev/rules.d
+
+		# Device support for Steam-related hardware (e.g. controllers over Steam Link)
+		vinstall ${FILESDIR}/60-steam-input.rules 644 usr/lib/udev/rules.d
+		vinstall ${FILESDIR}/60-steam-vr.rules 644 usr/lib/udev/rules.d
+	}
+}

Re: [PR REVIEW] steam: Create -udev-rules subpackge for device udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 265 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45338#discussion_r1285122376

Comment:
it's better to `vmove usr/lib/udev/rules.d` in a subpackage definition and leave the `vinstall`s where they were

Re: [PR PATCH] [Updated] steam: Create -udev-rules subpackge for device udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1515 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/BlindRepublic/void-packages steam_devices
https://github.com/void-linux/void-packages/pull/45338

steam: Create -udev-rules subpackge for device udev rules
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)

#### Note
The purpose of splitting the Udev rules into a separate package is to allow users to install the Steam Flatpak and use controllers without having to manually create the rules themselves. Other distributions such as Fedora do this and launching the Flatpak without these rules prompts a message telling the user to install a `steam-devices` package.


A patch file from https://github.com/void-linux/void-packages/pull/45338.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-steam_devices-45338.patch --]
[-- Type: text/x-diff, Size: 1526 bytes --]

From 5a4c78f050d4fbbef7664cf087187d8bf4129d6b Mon Sep 17 00:00:00 2001
From: Elliot <BlindRepublic@mailo.com>
Date: Sun, 30 Jul 2023 22:18:20 -0400
Subject: [PATCH] steam: Create -udev-rules subpackge for device udev rules

---
 srcpkgs/steam-udev-rules |  1 +
 srcpkgs/steam/template   | 11 +++++++++--
 2 files changed, 10 insertions(+), 2 deletions(-)
 create mode 120000 srcpkgs/steam-udev-rules

diff --git a/srcpkgs/steam-udev-rules b/srcpkgs/steam-udev-rules
new file mode 120000
index 0000000000000..9fe3d96896344
--- /dev/null
+++ b/srcpkgs/steam-udev-rules
@@ -0,0 +1 @@
+steam
\ No newline at end of file
diff --git a/srcpkgs/steam/template b/srcpkgs/steam/template
index 80d9aa80e6105..cf74dc3c256a2 100644
--- a/srcpkgs/steam/template
+++ b/srcpkgs/steam/template
@@ -1,10 +1,10 @@
 # Template file for 'steam'
 pkgname=steam
 version=1.0.0.78
-revision=1
+revision=2
 archs="i686 x86_64"
 depends="zenity xz curl dbus freetype gdk-pixbuf hicolor-icon-theme desktop-file-utils
- liberation-fonts-ttf file tar bash coreutils lsof"
+ liberation-fonts-ttf file tar bash coreutils lsof steam-udev-rules"
 short_desc="Digital distribution client bootstrap package - Valve's steam client"
 maintainer="Andrew Benson <abenson+void@gmail.com>"
 license="custom: Proprietary license"
@@ -33,3 +33,10 @@ do_install() {
 	# Void-specific documentation.
 	vdoc "${FILESDIR}/README.voidlinux"
 }
+
+steam-udev-rules_package() {
+	short_desc+=" - udev rules for hardware"
+	pkg_install() {
+		vmove usr/lib/udev/rules.d
+	}
+}

Re: [PR PATCH] [Merged]: steam: Create -udev-rules subpackge for device udev rules

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]

There's a merged pull request on the void-packages repository

steam: Create -udev-rules subpackge for device udev rules
https://github.com/void-linux/void-packages/pull/45338

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->

#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)

#### Note
The purpose of splitting the Udev rules into a separate package is to allow users to install the Steam Flatpak and use controllers without having to manually create the rules themselves. Other distributions such as Fedora do this and launching the Flatpak without these rules prompts a message telling the user to install a `steam-devices` package.