From: MeganerdNL <MeganerdNL@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: New package: encrypted-dns
Date: Fri, 04 Aug 2023 20:57:22 +0200 [thread overview]
Message-ID: <20230804185722.AAYFpe0CNynC0tvZhtxvHkCoJ-mvsCZ5skyMF2kqXik@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-45381@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1412 bytes --]
New comment by MeganerdNL on void-packages repository
https://github.com/void-linux/void-packages/pull/45381#issuecomment-1666047582
Comment:
@classabbyamp
Ready for review again.
- Regarding these lines in _template_:
```
if [ "$XBPS_TARGET_NO_ATOMIC8" ]; then
XBPS_CROSS_RUSTFLAGS+=" -latomic"
makedepends+=" libatomic-devel"
fi
case "$XBPS_TARGET_MACHINE" in
*-musl) makedepends+=" musl-devel libstdc++";;
esac
```
You said it build fine with:
> ./xbps-src -m masterdir-musl -a armv6l-musl pkg encrypted-dns
But I cannot reproduce that on my machine.
Also: I tried to remove both or one of the blocks _each_ and they always fail to compile in **Github on the musl-builds too**. So not only on my machine when cross-compiling. There are several other packages that need these blocks, or one of them. Let me know how to fix it otherwise, because I cannot make it work without these blocks.
- As with the make_dirs remark: you were of course right. I had to change the order of _make_dirs_ and __homedir_ and then the mode (750) was correct after installing.
- Made a files/README.voidlinux file instead of INSTALL.msg, although I think that the creation of a mandatory configfile that has an example is quite important. There are plenty of packages with far less important information in that file, but maybe that's something that slipped in in the past.
Thanks.
next prev parent reply other threads:[~2023-08-04 18:57 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-02 5:14 [PR PATCH] " MeganerdNL
2023-08-02 5:28 ` [PR REVIEW] " classabbyamp
2023-08-02 5:28 ` classabbyamp
2023-08-02 5:28 ` classabbyamp
2023-08-02 5:28 ` classabbyamp
2023-08-02 5:28 ` classabbyamp
2023-08-02 5:28 ` classabbyamp
2023-08-02 5:35 ` MeganerdNL
2023-08-02 12:15 ` MeganerdNL
2023-08-02 12:16 ` MeganerdNL
2023-08-04 7:48 ` MeganerdNL
2023-08-04 9:33 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-04 9:37 ` MeganerdNL
2023-08-04 9:40 ` [PR REVIEW] " MeganerdNL
2023-08-04 9:41 ` MeganerdNL
2023-08-04 9:41 ` MeganerdNL
2023-08-04 9:41 ` MeganerdNL
2023-08-04 9:42 ` MeganerdNL
2023-08-04 9:43 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-04 9:59 ` MeganerdNL
2023-08-04 12:58 ` [PR REVIEW] " classabbyamp
2023-08-04 12:58 ` classabbyamp
2023-08-04 12:58 ` classabbyamp
2023-08-04 12:58 ` classabbyamp
2023-08-04 12:58 ` classabbyamp
2023-08-04 18:08 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-04 18:17 ` MeganerdNL
2023-08-04 18:18 ` MeganerdNL
2023-08-04 18:22 ` MeganerdNL
2023-08-04 18:29 ` MeganerdNL
2023-08-04 18:41 ` MeganerdNL
2023-08-04 18:51 ` [PR REVIEW] " classabbyamp
2023-08-04 18:57 ` MeganerdNL [this message]
2023-08-04 19:01 ` MeganerdNL
2023-08-04 19:01 ` MeganerdNL
2023-08-04 19:20 ` classabbyamp
2023-08-04 20:52 ` MeganerdNL
2023-08-11 8:52 ` [PR PATCH] [Updated] " MeganerdNL
2023-08-11 8:53 ` MeganerdNL
2023-09-02 15:27 ` MeganerdNL
2023-09-02 15:31 ` MeganerdNL
2023-09-02 18:09 ` Duncaen
2023-09-02 19:12 ` MeganerdNL
2023-09-02 19:53 ` Duncaen
2023-09-02 22:11 ` MeganerdNL
2023-09-03 11:26 ` Duncaen
2023-09-03 11:26 ` Duncaen
2023-09-03 20:47 ` [PR PATCH] [Updated] " MeganerdNL
2023-09-03 20:57 ` MeganerdNL
2023-09-03 20:58 ` MeganerdNL
2023-09-15 10:08 ` [PR PATCH] [Updated] " MeganerdNL
2023-12-15 1:46 ` github-actions
2023-12-30 1:45 ` [PR PATCH] [Closed]: " github-actions
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230804185722.AAYFpe0CNynC0tvZhtxvHkCoJ-mvsCZ5skyMF2kqXik@z \
--to=meganerdnl@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).