* Re: [PR PATCH] [Updated] add power-profiles-daemon startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
@ 2023-08-18 17:42 ` Luciogi
2023-08-18 17:53 ` power-profiles-daemon: add " Luciogi
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-08-18 17:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 526 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages patch-power-profiles-daemon
https://github.com/void-linux/void-packages/pull/45660
add power-profiles-daemon startup dependency
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-Glibc)
A patch file from https://github.com/void-linux/void-packages/pull/45660.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-power-profiles-daemon-45660.patch --]
[-- Type: text/x-diff, Size: 760 bytes --]
From f6deb05cab69c3b28cb91cf56b2585405c131966 Mon Sep 17 00:00:00 2001
From: Luciogi <84625092+Luciogi@users.noreply.github.com>
Date: Fri, 18 Aug 2023 16:40:26 +0000
Subject: [PATCH] power-profiles-daemon: add startup dependency
---
srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run | 1 +
1 file changed, 1 insertion(+)
diff --git a/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run b/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
index c5dc3f90c28a4..153f10f31d689 100644
--- a/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
+++ b/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
@@ -1,3 +1,4 @@
#!/bin/sh
+sv start dbus > /dev/null
exec 2>&1
exec /usr/libexec/power-profiles-daemon
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: power-profiles-daemon: add startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
2023-08-18 17:42 ` [PR PATCH] [Updated] " Luciogi
@ 2023-08-18 17:53 ` Luciogi
2023-08-18 18:20 ` [PR REVIEW] " ahesford
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-08-18 17:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 188 bytes --]
New comment by Luciogi on void-packages repository
https://github.com/void-linux/void-packages/pull/45660#issuecomment-1684245498
Comment:
should I bump version or wait for maintainer?
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] power-profiles-daemon: add startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
2023-08-18 17:42 ` [PR PATCH] [Updated] " Luciogi
2023-08-18 17:53 ` power-profiles-daemon: add " Luciogi
@ 2023-08-18 18:20 ` ahesford
2023-08-19 1:20 ` [PR PATCH] [Updated] " Luciogi
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ahesford @ 2023-08-18 18:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/45660#discussion_r1298733119
Comment:
```suggestion
sv check dbus >/dev/null || exit 1
```
Also, move this after `exec 2>&1`.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] power-profiles-daemon: add startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
` (2 preceding siblings ...)
2023-08-18 18:20 ` [PR REVIEW] " ahesford
@ 2023-08-19 1:20 ` Luciogi
2023-08-19 1:21 ` Luciogi
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-08-19 1:20 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages patch-power-profiles-daemon
https://github.com/void-linux/void-packages/pull/45660
power-profiles-daemon: add startup dependency
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-Glibc)
A patch file from https://github.com/void-linux/void-packages/pull/45660.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-power-profiles-daemon-45660.patch --]
[-- Type: text/x-diff, Size: 1337 bytes --]
From 81c4671dd9b214f42032756a2bf71bf2585b5bdc Mon Sep 17 00:00:00 2001
From: Luciogi <84625092+Luciogi@users.noreply.github.com>
Date: Fri, 18 Aug 2023 16:40:26 +0000
Subject: [PATCH] power-profiles-daemon: add startup dependency
---
srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run | 1 +
srcpkgs/power-profiles-daemon/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run b/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
index c5dc3f90c28a4..a3eaf98a90910 100644
--- a/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
+++ b/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
@@ -1,3 +1,4 @@
#!/bin/sh
exec 2>&1
+sv start dbus >/dev/null || exit 1
exec /usr/libexec/power-profiles-daemon
diff --git a/srcpkgs/power-profiles-daemon/template b/srcpkgs/power-profiles-daemon/template
index b4e1ad88cb359..0fdffbd409ab6 100644
--- a/srcpkgs/power-profiles-daemon/template
+++ b/srcpkgs/power-profiles-daemon/template
@@ -1,7 +1,7 @@
# Template file for 'power-profiles-daemon'
pkgname=power-profiles-daemon
version=0.13
-revision=1
+revision=2
build_style=meson
configure_args="-Dsystemdsystemunitdir=/usr/lib/systemd/system/"
hostmakedepends="pkg-config glib-devel"
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: power-profiles-daemon: add startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
` (3 preceding siblings ...)
2023-08-19 1:20 ` [PR PATCH] [Updated] " Luciogi
@ 2023-08-19 1:21 ` Luciogi
2023-08-19 1:23 ` [PR REVIEW] " ahesford
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-08-19 1:21 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 156 bytes --]
New comment by Luciogi on void-packages repository
https://github.com/void-linux/void-packages/pull/45660#issuecomment-1684634640
Comment:
@ahesford done
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] power-profiles-daemon: add startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
` (4 preceding siblings ...)
2023-08-19 1:21 ` Luciogi
@ 2023-08-19 1:23 ` ahesford
2023-08-19 3:13 ` [PR PATCH] [Updated] " Luciogi
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ahesford @ 2023-08-19 1:23 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 199 bytes --]
New review comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/45660#discussion_r1298981823
Comment:
This is supposed to be `sv check`, not `sv start`.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] power-profiles-daemon: add startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
` (5 preceding siblings ...)
2023-08-19 1:23 ` [PR REVIEW] " ahesford
@ 2023-08-19 3:13 ` Luciogi
2023-08-19 3:13 ` Luciogi
2023-08-20 14:32 ` [PR PATCH] [Merged]: " Duncaen
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-08-19 3:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 527 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages patch-power-profiles-daemon
https://github.com/void-linux/void-packages/pull/45660
power-profiles-daemon: add startup dependency
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-Glibc)
A patch file from https://github.com/void-linux/void-packages/pull/45660.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-patch-power-profiles-daemon-45660.patch --]
[-- Type: text/x-diff, Size: 1337 bytes --]
From c10105fe8b99eff5fcd94280cde795254fe1aff0 Mon Sep 17 00:00:00 2001
From: Luciogi <84625092+Luciogi@users.noreply.github.com>
Date: Fri, 18 Aug 2023 16:40:26 +0000
Subject: [PATCH] power-profiles-daemon: add startup dependency
---
srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run | 1 +
srcpkgs/power-profiles-daemon/template | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run b/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
index c5dc3f90c28a4..830cce25afac1 100644
--- a/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
+++ b/srcpkgs/power-profiles-daemon/files/power-profiles-daemon/run
@@ -1,3 +1,4 @@
#!/bin/sh
exec 2>&1
+sv check dbus >/dev/null || exit 1
exec /usr/libexec/power-profiles-daemon
diff --git a/srcpkgs/power-profiles-daemon/template b/srcpkgs/power-profiles-daemon/template
index b4e1ad88cb359..0fdffbd409ab6 100644
--- a/srcpkgs/power-profiles-daemon/template
+++ b/srcpkgs/power-profiles-daemon/template
@@ -1,7 +1,7 @@
# Template file for 'power-profiles-daemon'
pkgname=power-profiles-daemon
version=0.13
-revision=1
+revision=2
build_style=meson
configure_args="-Dsystemdsystemunitdir=/usr/lib/systemd/system/"
hostmakedepends="pkg-config glib-devel"
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: power-profiles-daemon: add startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
` (6 preceding siblings ...)
2023-08-19 3:13 ` [PR PATCH] [Updated] " Luciogi
@ 2023-08-19 3:13 ` Luciogi
2023-08-20 14:32 ` [PR PATCH] [Merged]: " Duncaen
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-08-19 3:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 174 bytes --]
New comment by Luciogi on void-packages repository
https://github.com/void-linux/void-packages/pull/45660#issuecomment-1684724524
Comment:
ah sorry.
Now Fixed
@ahesford
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Merged]: power-profiles-daemon: add startup dependency
2023-08-18 16:47 [PR PATCH] add power-profiles-daemon startup dependency Luciogi
` (7 preceding siblings ...)
2023-08-19 3:13 ` Luciogi
@ 2023-08-20 14:32 ` Duncaen
8 siblings, 0 replies; 10+ messages in thread
From: Duncaen @ 2023-08-20 14:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 351 bytes --]
There's a merged pull request on the void-packages repository
power-profiles-daemon: add startup dependency
https://github.com/void-linux/void-packages/pull/45660
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-Glibc)
^ permalink raw reply [flat|nested] 10+ messages in thread