Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] fix neochat dependencies
@ 2023-08-19 20:51 TGRush
  2023-08-20  1:31 ` abenson
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: TGRush @ 2023-08-19 20:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1411 bytes --]

There is a new pull request by TGRush against master on the void-packages repository

https://github.com/TGRush/void-packages master
https://github.com/void-linux/void-packages/pull/45677

fix neochat dependencies
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

The package didn't automatically pull in kirigami2 and kirigami-addons as a dependency. This PR fixes that. Testing was done locally with existing packages and a fresh build.


A patch file from https://github.com/void-linux/void-packages/pull/45677.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-master-45677.patch --]
[-- Type: text/x-diff, Size: 1002 bytes --]

From 32e97a73a8d4a83cd62e5d5b974ba088cb3e6f9a Mon Sep 17 00:00:00 2001
From: Rush <58338843+TGRush@users.noreply.github.com>
Date: Sat, 19 Aug 2023 22:49:26 +0200
Subject: [PATCH] fix neochat dependencies

---
 srcpkgs/neochat/template | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srcpkgs/neochat/template b/srcpkgs/neochat/template
index c6c4e699eca58..db4205fb96884 100644
--- a/srcpkgs/neochat/template
+++ b/srcpkgs/neochat/template
@@ -10,7 +10,7 @@ makedepends="kquickimageeditor-devel libQuotient-devel qtkeychain-qt5-devel
  knotifications-devel kconfig-devel kcoreaddons-devel qqc2-desktop-style-devel
  sonnet-devel kitemmodels-devel kirigami-addons kconfigwidgets-devel kio-devel
  qcoro-qt5-devel"
-depends="kquickimageeditor kitemmodels"
+depends="kquickimageeditor kitemmodels kirigami2 kirigami-addons"
 short_desc="Client for matrix from KDE"
 maintainer="Orphaned <orphan@voidlinux.org>"
 license="GPL-3.0-only, GPL-3.0-or-later, GPL-2.0-or-later, BSD-2-Clause"

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fix neochat dependencies
  2023-08-19 20:51 [PR PATCH] fix neochat dependencies TGRush
@ 2023-08-20  1:31 ` abenson
  2023-08-20  1:32 ` abenson
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: abenson @ 2023-08-20  1:31 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 260 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/45677#issuecomment-1685148543

Comment:
You need to fix the commit message. See CONTRIBUTING.md for guidelines, edit the commit and force push to this branch 

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fix neochat dependencies
  2023-08-19 20:51 [PR PATCH] fix neochat dependencies TGRush
  2023-08-20  1:31 ` abenson
@ 2023-08-20  1:32 ` abenson
  2023-08-23 19:13 ` TGRush
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: abenson @ 2023-08-20  1:32 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 164 bytes --]

New comment by abenson on void-packages repository

https://github.com/void-linux/void-packages/pull/45677#issuecomment-1685148667

Comment:
Also, set `revision=2`

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fix neochat dependencies
  2023-08-19 20:51 [PR PATCH] fix neochat dependencies TGRush
  2023-08-20  1:31 ` abenson
  2023-08-20  1:32 ` abenson
@ 2023-08-23 19:13 ` TGRush
  2023-11-14 15:51 ` TinfoilSubmarine
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: TGRush @ 2023-08-23 19:13 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 294 bytes --]

New comment by TGRush on void-packages repository

https://github.com/void-linux/void-packages/pull/45677#issuecomment-1690504517

Comment:
> You need to fix the commit message. See CONTRIBUTING.md for guidelines, edit the commit and force push to this branch 

My bad, thanks for the heads up

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fix neochat dependencies
  2023-08-19 20:51 [PR PATCH] fix neochat dependencies TGRush
                   ` (2 preceding siblings ...)
  2023-08-23 19:13 ` TGRush
@ 2023-11-14 15:51 ` TinfoilSubmarine
  2023-11-28 12:37 ` TGRush
  2023-11-28 12:37 ` [PR PATCH] [Closed]: " TGRush
  5 siblings, 0 replies; 7+ messages in thread
From: TinfoilSubmarine @ 2023-11-14 15:51 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 188 bytes --]

New comment by TinfoilSubmarine on void-packages repository

https://github.com/void-linux/void-packages/pull/45677#issuecomment-1810501753

Comment:
I don't think this is needed anymore.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: fix neochat dependencies
  2023-08-19 20:51 [PR PATCH] fix neochat dependencies TGRush
                   ` (3 preceding siblings ...)
  2023-11-14 15:51 ` TinfoilSubmarine
@ 2023-11-28 12:37 ` TGRush
  2023-11-28 12:37 ` [PR PATCH] [Closed]: " TGRush
  5 siblings, 0 replies; 7+ messages in thread
From: TGRush @ 2023-11-28 12:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 193 bytes --]

New comment by TGRush on void-packages repository

https://github.com/void-linux/void-packages/pull/45677#issuecomment-1829760093

Comment:
> I don't think this is needed anymore.

Good point.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Closed]: fix neochat dependencies
  2023-08-19 20:51 [PR PATCH] fix neochat dependencies TGRush
                   ` (4 preceding siblings ...)
  2023-11-28 12:37 ` TGRush
@ 2023-11-28 12:37 ` TGRush
  5 siblings, 0 replies; 7+ messages in thread
From: TGRush @ 2023-11-28 12:37 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 1263 bytes --]

There's a closed pull request on the void-packages repository

fix neochat dependencies
https://github.com/void-linux/void-packages/pull/45677

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **YES**

<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->

The package didn't automatically pull in kirigami2 and kirigami-addons as a dependency. This PR fixes that. Testing was done locally with existing packages and a fresh build.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-11-28 12:37 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-08-19 20:51 [PR PATCH] fix neochat dependencies TGRush
2023-08-20  1:31 ` abenson
2023-08-20  1:32 ` abenson
2023-08-23 19:13 ` TGRush
2023-11-14 15:51 ` TinfoilSubmarine
2023-11-28 12:37 ` TGRush
2023-11-28 12:37 ` [PR PATCH] [Closed]: " TGRush

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).