[ISSUE] [RFC] enable `XBPS_STRICT` by default

[ISSUE] [RFC] enable `XBPS_STRICT` by default

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 1083 bytes --]

New issue by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/45507

Description:
<!--
  if you are creating a bug report or package request, please fill out one of the forms here:
  https://github.com/void-linux/void-packages/issues/new/choose

  Don't request an update of a package, We have a script for that:
  https://repo-default.voidlinux.org/void-updates/void-updates.txt
  However, a quality pull request may help.
-->

When a `vsed` doesn't apply, they currently print a warning by default, and the build goes on. This can hide potential issues. `xbps-src` does have an `-s` flag, which in that case causes the build to stop at the failing vsed. This flag _is_ passed in the CI, but large PRs skip CI and so authors of those PRs may never notice the now-outdated `vsed`s (see e.g. https://github.com/void-linux/void-packages/issues/42441). Therefore, I propose enabling the "strict" `vsed` behavior by default, and would even go so far as to suggest removing the non-strict behavior, because I honestly don't see its point.

Re: [RFC] enable `XBPS_STRICT` by default

[Chocimier]

[-- Attachment #1: Type: text/plain, Size: 255 bytes --]

New comment by Chocimier on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1671757635

Comment:
When `-s` was added many vsed were targetted at cross, and no-op in native build. How many of them  remained?

Re: [RFC] enable `XBPS_STRICT` by default

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 495 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1671764179

Comment:
I don't know, we might have to do a world rebuild to find out. For what it's worth though, https://github.com/void-linux/void-packages/issues/42441 documented templates with "useless" vseds and most of them were fixed (the checklist is outdated, I believe out of the templates in that issue only qt5 and pulseaudio still have vseds that don't apply).

Re: [RFC] enable `XBPS_STRICT` by default

[sgn]

[-- Attachment #1: Type: text/plain, Size: 154 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1672403027

Comment:
No, please no!

Re: [RFC] enable `XBPS_STRICT` by default

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1671764179

Comment:
I don't know, we might have to do a world build to find out. For what it's worth though, https://github.com/void-linux/void-packages/issues/42441 documented templates with "useless" vseds and most of them were fixed (the checklist is outdated, I believe out of the templates in that issue only qt5 and pulseaudio still have vseds that don't apply).

Re: [RFC] enable `XBPS_STRICT` by default

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 153 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1673419584

Comment:
Why not?

Re: [RFC] enable `XBPS_STRICT` by default

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 222 bytes --]

New comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1682857653

Comment:
This seems too heavy handed. Catching these failures in CI is helpful enough.

Re: [RFC] enable `XBPS_STRICT` by default

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 541 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1682910248

Comment:
Why do you think it's heavy-handed? 

> Catching these failures in CI is helpful enough.

If they're going to be triggered in the CI anyway, I personally would rather have them caught when building locally rather than getting CI failures later on. Also, like I already mentioned, those failures won't be caught if the CI is skipped (unless you use `-s` locally or check build logs manually). 

Re: [RFC] enable `XBPS_STRICT` by default

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 207 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1682920564

Comment:
i think `echo XBPS_STRICT=yes >> etc/conf` would work too?

Re: [RFC] enable `XBPS_STRICT` by default

[mhmdanas]

[-- Attachment #1: Type: text/plain, Size: 249 bytes --]

New comment by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1683062964

Comment:
Yes, but I don't think it's documented (I actually only stumbled on it while reading `xbps-src`'s code).

Re: [RFC] enable `XBPS_STRICT` by default

[sgn]

[-- Attachment #1: Type: text/plain, Size: 439 bytes --]

New comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1692836368

Comment:
> Why do you think it's heavy-handed?

You vsed something, it changes, good.
Your other steps run into failure, thus you need to patch.
You patch the software, you run the build again.
BUMPPP, `vsed` reports that it doesn't change anything, and blocks you from doing anything.

No, please no!

Re: [RFC] enable `XBPS_STRICT` by default

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 293 bytes --]

New comment by github-actions[bot] on void-packages repository

https://github.com/void-linux/void-packages/issues/45507#issuecomment-1825053067

Comment:
Issues become stale 90 days after last activity and are closed 14 days after that.  If this issue is still relevant bump it or assign it.

Re: [ISSUE] [CLOSED] [RFC] enable `XBPS_STRICT` by default

[github-actions]

[-- Attachment #1: Type: text/plain, Size: 1086 bytes --]

Closed issue by mhmdanas on void-packages repository

https://github.com/void-linux/void-packages/issues/45507

Description:
<!--
  if you are creating a bug report or package request, please fill out one of the forms here:
  https://github.com/void-linux/void-packages/issues/new/choose

  Don't request an update of a package, We have a script for that:
  https://repo-default.voidlinux.org/void-updates/void-updates.txt
  However, a quality pull request may help.
-->

When a `vsed` doesn't apply, they currently print a warning by default, and the build goes on. This can hide potential issues. `xbps-src` does have an `-s` flag, which in that case causes the build to stop at the failing vsed. This flag _is_ passed in the CI, but large PRs skip CI and so authors of those PRs may never notice the now-outdated `vsed`s (see e.g. https://github.com/void-linux/void-packages/issues/42441). Therefore, I propose enabling the "strict" `vsed` behavior by default, and would even go so far as to suggest removing the non-strict behavior, because I honestly don't see its point.