[PR PATCH] common/xbps-src/shutils/update_check.sh: eary return for disabled checks

[PR PATCH] common/xbps-src/shutils/update_check.sh: eary return for disabled checks

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 482 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages return-on-disabled-update-check
https://github.com/void-linux/void-packages/pull/45983

common/xbps-src/shutils/update_check.sh: eary return for disabled checks
I'm not fully aware of possible side-effects but this seemed reasonable to me.

@classabbyamp wdyt?

A patch file from https://github.com/void-linux/void-packages/pull/45983.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-return-on-disabled-update-check-45983.patch --]
[-- Type: text/x-diff, Size: 831 bytes --]

From ee6dc11722d3ad588aaaf9002b4f43915bf694c9 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 9 Sep 2023 01:39:14 +0530
Subject: [PATCH] common/xbps-src/shutils/update_check.sh: eary return for
 disabled checks

---
 common/xbps-src/shutils/update_check.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index 8827641005777..f38f384bd2bff 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -15,6 +15,7 @@ update_check() {
         fi
         if [ -n "$disabled" ]; then
             echo "update-check DISABLED for $original_pkgname: $disabled" 1>&2
+            return 0
         fi
     elif [ -z "$distfiles" ]; then
         if [ "$XBPS_UPDATE_CHECK_VERBOSE" ]; then

Re: [PR PATCH] [Updated] common/xbps-src/shutils/update_check.sh: eary return for disabled checks

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 487 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages return-on-disabled-update-check
https://github.com/void-linux/void-packages/pull/45983

common/xbps-src/shutils/update_check.sh: eary return for disabled checks
I'm not fully aware of possible side-effects but this seemed reasonable to me.

@classabbyamp wdyt?

A patch file from https://github.com/void-linux/void-packages/pull/45983.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-return-on-disabled-update-check-45983.patch --]
[-- Type: text/x-diff, Size: 839 bytes --]

From ee8e5ab6b059b8701f365cf288e27eb15eeed5bc Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Sat, 9 Sep 2023 01:39:14 +0530
Subject: [PATCH] common/xbps-src/shutils/update_check.sh: early return for
 disabled update checks

---
 common/xbps-src/shutils/update_check.sh | 1 +
 1 file changed, 1 insertion(+)

diff --git a/common/xbps-src/shutils/update_check.sh b/common/xbps-src/shutils/update_check.sh
index 8827641005777..f38f384bd2bff 100644
--- a/common/xbps-src/shutils/update_check.sh
+++ b/common/xbps-src/shutils/update_check.sh
@@ -15,6 +15,7 @@ update_check() {
         fi
         if [ -n "$disabled" ]; then
             echo "update-check DISABLED for $original_pkgname: $disabled" 1>&2
+            return 0
         fi
     elif [ -z "$distfiles" ]; then
         if [ "$XBPS_UPDATE_CHECK_VERBOSE" ]; then

Re: common/xbps-src/shutils/update_check.sh: early return for disabled update checks

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 206 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/45983#issuecomment-1712303106

Comment:
yeah makes sense, NO DISTFILES just below it also does this

Re: [PR PATCH] [Merged]: common/xbps-src/shutils/update_check.sh: early return for disabled update checks

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 315 bytes --]

There's a merged pull request on the void-packages repository

common/xbps-src/shutils/update_check.sh: early return for disabled update checks
https://github.com/void-linux/void-packages/pull/45983

Description:
I'm not fully aware of possible side-effects but this seemed reasonable to me.

@classabbyamp wdyt?