* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
@ 2023-09-09 20:40 ` yoshiyoshyosh
2023-09-09 20:42 ` yoshiyoshyosh
` (12 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-09 20:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712596943
Comment:
musl builds are failing cuz of `mhash`, looking into it
not sure about why i686 is failing
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
2023-09-09 20:40 ` yoshiyoshyosh
@ 2023-09-09 20:42 ` yoshiyoshyosh
2023-09-09 20:45 ` yoshiyoshyosh
` (11 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-09 20:42 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 325 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712596943
Comment:
musl builds are failing cuz of `mhash`, looking into it. [seems to be something not specific to this program](https://bugs.gentoo.org/830434)
not sure about why i686 is failing
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
2023-09-09 20:40 ` yoshiyoshyosh
2023-09-09 20:42 ` yoshiyoshyosh
@ 2023-09-09 20:45 ` yoshiyoshyosh
2023-09-09 20:47 ` yoshiyoshyosh
` (10 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-09 20:45 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 407 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712596943
Comment:
musl builds are failing cuz of `mhash`, looking into it. [seems to be something not specific to this program](https://bugs.gentoo.org/830434) and [related to this possibly?](https://www.openwall.com/lists/musl/2017/08/01/1)
not sure about why i686 is failing
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (2 preceding siblings ...)
2023-09-09 20:45 ` yoshiyoshyosh
@ 2023-09-09 20:47 ` yoshiyoshyosh
2023-09-09 20:47 ` yoshiyoshyosh
` (9 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-09 20:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 411 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712596943
Comment:
musl builds are failing cuz of `mhash`, looking into it. [seems to be something not specific to this program](https://bugs.gentoo.org/830434) and [related to this possibly?](https://www.openwall.com/lists/musl/2017/08/01/1)
not sure why *exactly* i686 is failing
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (3 preceding siblings ...)
2023-09-09 20:47 ` yoshiyoshyosh
@ 2023-09-09 20:47 ` yoshiyoshyosh
2023-09-09 21:12 ` yoshiyoshyosh
` (8 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-09 20:47 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 421 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712596943
Comment:
musl builds are failing cuz of `mhash`, looking into it. [seems to be something not specific to this program](https://bugs.gentoo.org/830434) and [related to this possibly?](https://www.openwall.com/lists/musl/2017/08/01/1)
not sure why *exactly* 32 bit builds are failing
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (4 preceding siblings ...)
2023-09-09 20:47 ` yoshiyoshyosh
@ 2023-09-09 21:12 ` yoshiyoshyosh
2023-09-09 21:13 ` yoshiyoshyosh
` (7 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-09 21:12 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712596943
Comment:
musl builds are failing cuz of `mhash`, looking into it. [seems to be something not specific to this program](https://bugs.gentoo.org/830434) and [related to this possibly?](https://www.openwall.com/lists/musl/2017/08/01/1). I doubt this could be patched around in any way
32 bit builds are failing cuz it tries to cap an `unsigned long` by comparing it with incompatible `1L`. this can probably be fixed with a vsed or patch. should I try to?
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (5 preceding siblings ...)
2023-09-09 21:12 ` yoshiyoshyosh
@ 2023-09-09 21:13 ` yoshiyoshyosh
2023-09-10 15:57 ` yoshiyoshyosh
` (6 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-09 21:13 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 602 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712596943
Comment:
musl builds are failing cuz of `mhash`, looking into it. [seems to be something not specific to this program](https://bugs.gentoo.org/830434) and [related to this possibly?](https://www.openwall.com/lists/musl/2017/08/01/1). I doubt this could be patched around in any way
32 bit builds are failing cuz it tries to cap an `unsigned long` by comparing it with incompatible `1L` (I think). this can probably be fixed with a vsed or patch. should I try to?
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (6 preceding siblings ...)
2023-09-09 21:13 ` yoshiyoshyosh
@ 2023-09-10 15:57 ` yoshiyoshyosh
2023-09-10 18:16 ` yoshiyoshyosh
` (5 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-10 15:57 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 498 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712849424
Comment:
fixed the 32bit builds by incorporating [this commit](https://github.com/RickdeJager/stegseek/commit/ff677b9401f8fb0383debaf663096eb273151e24) as a patch, but the musl builds will still fail without a patch to `mhash`. this is only a problem for C++ code that includes `mhash` and uses anything with its `_Bool`s, which seems to be only this program.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (7 preceding siblings ...)
2023-09-10 15:57 ` yoshiyoshyosh
@ 2023-09-10 18:16 ` yoshiyoshyosh
2023-09-10 20:26 ` [PR PATCH] [Updated] " yoshiyoshyosh
` (4 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-10 18:16 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 235 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1712903430
Comment:
I'll update this PR and un-draft it when #46005 lands. should fix all the build issues.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: [PR PATCH] [Updated] New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (8 preceding siblings ...)
2023-09-10 18:16 ` yoshiyoshyosh
@ 2023-09-10 20:26 ` yoshiyoshyosh
2023-12-10 1:48 ` github-actions
` (3 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-09-10 20:26 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 707 bytes --]
There is an updated pull request by yoshiyoshyosh against master on the void-packages repository
https://github.com/yoshiyoshyosh/void-packages stegseek
https://github.com/void-linux/void-packages/pull/45998
New package: stegseek-0.6
#### Testing the changes
- I tested the changes in this PR: **YES**
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**
#### Local build testing
- I built this PR locally for my native architecture, (`x86_64-glibc`)
- `x86_64-musl`
- `i686`
A patch file from https://github.com/void-linux/void-packages/pull/45998.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-stegseek-45998.patch --]
[-- Type: text/x-diff, Size: 4329 bytes --]
From ce8da4ed7e3f1db1b77e1e083f283312f814e95e Mon Sep 17 00:00:00 2001
From: yosh <yosh-git@riseup.net>
Date: Sat, 9 Sep 2023 16:25:38 -0400
Subject: [PATCH] New package: stegseek-0.6
---
srcpkgs/stegseek/patches/portable-types.patch | 74 +++++++++++++++++++
srcpkgs/stegseek/template | 12 +++
2 files changed, 86 insertions(+)
create mode 100644 srcpkgs/stegseek/patches/portable-types.patch
create mode 100644 srcpkgs/stegseek/template
diff --git a/srcpkgs/stegseek/patches/portable-types.patch b/srcpkgs/stegseek/patches/portable-types.patch
new file mode 100644
index 0000000000000..b68c7480b2f8c
--- /dev/null
+++ b/srcpkgs/stegseek/patches/portable-types.patch
@@ -0,0 +1,74 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 4a404f8..9bb968f 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -2,6 +2,11 @@ cmake_minimum_required(VERSION 3.5)
+
+ project(stegseek VERSION 0.6)
+
++if(CMAKE_COMPILER_IS_GNUCC OR CMAKE_COMPILER_IS_GNUCXX)
++ # Update if necessary
++ set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wall -Wno-long-long")
++endif()
++
+ add_subdirectory("src")
+
+ # Testing only available if this is the main app
+diff --git a/src/Cracker.cc b/src/Cracker.cc
+index 8c5a646..88a2b09 100644
+--- a/src/Cracker.cc
++++ b/src/Cracker.cc
+@@ -189,7 +189,7 @@ bool Cracker::verifyMagic(UWORD32 seed) {
+ short currentBit = (ev >> k) & 1;
+ int bitsSeen = i * bitsPerEmbValue + k;
+ // Add an extra check to make sure we don't touch bit 26, even if bitsPerEmbValue > 1
+- if (currentBit != ((magic >> bitsSeen) & 1) && bitsSeen < 25) {
++ if (currentBit != (short)((magic >> bitsSeen) & 1) && bitsSeen < 25) {
+ return false;
+ }
+ }
+diff --git a/src/PasswordCracker.cc b/src/PasswordCracker.cc
+index 58fc3a8..e91ef1a 100644
+--- a/src/PasswordCracker.cc
++++ b/src/PasswordCracker.cc
+@@ -58,7 +58,11 @@ void PasswordCracker::crack() {
+ // Add n worker threads
+ // A part must have at least len 1, otherwise no words will be read when
+ // threads > size
+- unsigned long part = std::max(wordlistStats.st_size / threads, 1L);
++ unsigned long part = ((unsigned long)wordlistStats.st_size) / threads;
++ if (part <= 0) {
++ part = 1;
++ }
++
+ for (unsigned int i = 0; i < threads; i++) {
+ ThreadPool.push_back(std::thread([this, i, part, metricsEnabled] {
+ consume(i * part, (i + 1) * part, metricsEnabled);
+@@ -138,8 +142,13 @@ void PasswordCracker::consume(unsigned long i, unsigned long stop, bool metricsE
+ batchProgess = 0;
+ }
+
++ // Get out current position in the wordlist, make sure it is non-negative, so
++ // we are safe to cast it to unsigned in the next compare.
++ long pos = ftell(pWordList);
++ myassert(pos >= 0);
++
+ // If we've overshot the end of our section (by one word), we can stop
+- if (ftell(pWordList) > stop) {
++ if ((unsigned long)ftell(pWordList) > stop) {
+ break;
+ }
+ }
+diff --git a/src/SeedCracker.cc b/src/SeedCracker.cc
+index 3308753..36f3c1a 100644
+--- a/src/SeedCracker.cc
++++ b/src/SeedCracker.cc
+@@ -128,7 +128,7 @@ Result SeedCracker::trySeed(UWORD32 seed) {
+ int bitsSeen = i * bitsPerEmbValue + k;
+ // Check magic
+ if (bitsSeen < 25) {
+- if (((magic >> bitsSeen) & 1) != currentBit) {
++ if ((short)((magic >> bitsSeen) & 1) != currentBit) {
+ return Result{};
+ }
+ }
diff --git a/srcpkgs/stegseek/template b/srcpkgs/stegseek/template
new file mode 100644
index 0000000000000..fd78008a08d3a
--- /dev/null
+++ b/srcpkgs/stegseek/template
@@ -0,0 +1,12 @@
+# Template file for 'stegseek'
+pkgname=stegseek
+version=0.6
+revision=1
+build_style=cmake
+makedepends="mhash-devel libmcrypt-devel libjpeg-turbo-devel zlib-devel"
+short_desc="Worlds fastest steghide cracker"
+maintainer="yosh <yosh-git@riseup.net>"
+license="GPL-2.0-or-later"
+homepage="https://github.com/RickdeJager/stegseek"
+distfiles="https://github.com/RickdeJager/stegseek/archive/refs/tags/v${version}.tar.gz"
+checksum=66cdd8e4e4b815d7fe368843e7df2f0416af0304df35e4f22db9f16c7ae6c771
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (9 preceding siblings ...)
2023-09-10 20:26 ` [PR PATCH] [Updated] " yoshiyoshyosh
@ 2023-12-10 1:48 ` github-actions
2023-12-10 1:53 ` yoshiyoshyosh
` (2 subsequent siblings)
13 siblings, 0 replies; 15+ messages in thread
From: github-actions @ 2023-12-10 1:48 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1848829172
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (10 preceding siblings ...)
2023-12-10 1:48 ` github-actions
@ 2023-12-10 1:53 ` yoshiyoshyosh
2024-03-11 1:44 ` github-actions
2024-03-12 6:25 ` yoshiyoshyosh
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2023-12-10 1:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 162 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1848831412
Comment:
still relevant
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (11 preceding siblings ...)
2023-12-10 1:53 ` yoshiyoshyosh
@ 2024-03-11 1:44 ` github-actions
2024-03-12 6:25 ` yoshiyoshyosh
13 siblings, 0 replies; 15+ messages in thread
From: github-actions @ 2024-03-11 1:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 305 bytes --]
New comment by github-actions[bot] on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1987483911
Comment:
Pull Requests become stale 90 days after last activity and are closed 14 days after that. If this pull request is still relevant bump it or assign it.
^ permalink raw reply [flat|nested] 15+ messages in thread* Re: New package: stegseek-0.6
2023-09-09 20:28 [PR PATCH] New package: stegseek-0.6 yoshiyoshyosh
` (12 preceding siblings ...)
2024-03-11 1:44 ` github-actions
@ 2024-03-12 6:25 ` yoshiyoshyosh
13 siblings, 0 replies; 15+ messages in thread
From: yoshiyoshyosh @ 2024-03-12 6:25 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 168 bytes --]
New comment by yoshiyoshyosh on void-packages repository
https://github.com/void-linux/void-packages/pull/45998#issuecomment-1990826855
Comment:
stiiiiil relevant :v
^ permalink raw reply [flat|nested] 15+ messages in thread