* Re: [PR PATCH] [Updated] godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
@ 2023-09-08 17:44 ` Luciogi
2023-09-08 17:58 ` Luciogi
` (7 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-09-08 17:44 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages godot
https://github.com/void-linux/void-packages/pull/45975
godot: add man page and mime file
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/45975.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-45975.patch --]
[-- Type: text/x-diff, Size: 1447 bytes --]
From 9748d2bb34a150fd363dfdbfe5476bc6b8030b97 Mon Sep 17 00:00:00 2001
From: Luciogi <84625092+Luciogi@users.noreply.github.com>
Date: Fri, 8 Sep 2023 22:36:28 +0500
Subject: [PATCH] godot: add man page and mime file
---
srcpkgs/godot/template | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index d75049c368521..d010da6455e1e 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,7 +1,7 @@
# Template file for 'godot'
pkgname=godot
version=4.1.1
-revision=4
+revision=5
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
# Build currently fails with embree-4.X
@@ -49,12 +49,15 @@ pre_build() {
export CXXFLAGS=" $CXXFLAGS "
}
+pre_install() {
+ sed -i 's/name="x/name="application-x/g' misc/dist/linux/org.godotengine.Godot.xml
+}
+
do_install() {
vlicense LICENSE.txt
vinstall ${FILESDIR}/godot.desktop 644 /usr/share/applications/
vinstall ${wrksrc}/icon.png 644 /usr/share/pixmaps/ godot.png
-
case "$XBPS_TARGET_MACHINE" in
x86_64*) vbin bin/godot.linuxbsd.editor.x86_64 godot;;
i686*) vbin bin/godot.linuxbsd.editor.x86_32 godot;;
@@ -62,4 +65,7 @@ do_install() {
armv7*) vbin bin/godot.linuxbsd.editor.arm32 godot;;
ppc64*) vbin bin/godot.linuxbsd.editor.ppc64 godot;;
esac
+
+ vinstall misc/dist/linux/org.godotengine.Godot.xml 644 /usr/share/mime/packages/
+ vman misc/dist/linux/godot.6
}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
2023-09-08 17:44 ` [PR PATCH] [Updated] " Luciogi
@ 2023-09-08 17:58 ` Luciogi
2023-09-08 18:05 ` Luciogi
` (6 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-09-08 17:58 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages godot
https://github.com/void-linux/void-packages/pull/45975
godot: add man page and mime file
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/45975.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-45975.patch --]
[-- Type: text/x-diff, Size: 1447 bytes --]
From 5cfbae9d46bffd0e277f4c8ddcd2e64f191f7713 Mon Sep 17 00:00:00 2001
From: Luciogi <84625092+Luciogi@users.noreply.github.com>
Date: Fri, 8 Sep 2023 22:36:28 +0500
Subject: [PATCH] godot: add man page and mime file
---
srcpkgs/godot/template | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index d75049c368521..d010da6455e1e 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,7 +1,7 @@
# Template file for 'godot'
pkgname=godot
version=4.1.1
-revision=4
+revision=5
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
# Build currently fails with embree-4.X
@@ -49,12 +49,15 @@ pre_build() {
export CXXFLAGS=" $CXXFLAGS "
}
+pre_install() {
+ sed -i 's/name="x/name="application-x/g' misc/dist/linux/org.godotengine.Godot.xml
+}
+
do_install() {
vlicense LICENSE.txt
vinstall ${FILESDIR}/godot.desktop 644 /usr/share/applications/
vinstall ${wrksrc}/icon.png 644 /usr/share/pixmaps/ godot.png
-
case "$XBPS_TARGET_MACHINE" in
x86_64*) vbin bin/godot.linuxbsd.editor.x86_64 godot;;
i686*) vbin bin/godot.linuxbsd.editor.x86_32 godot;;
@@ -62,4 +65,7 @@ do_install() {
armv7*) vbin bin/godot.linuxbsd.editor.arm32 godot;;
ppc64*) vbin bin/godot.linuxbsd.editor.ppc64 godot;;
esac
+
+ vinstall misc/dist/linux/org.godotengine.Godot.xml 644 /usr/share/mime/packages/
+ vman misc/dist/linux/godot.6
}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
2023-09-08 17:44 ` [PR PATCH] [Updated] " Luciogi
2023-09-08 17:58 ` Luciogi
@ 2023-09-08 18:05 ` Luciogi
2023-09-11 14:07 ` Luciogi
` (5 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-09-08 18:05 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 491 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages godot
https://github.com/void-linux/void-packages/pull/45975
godot: add man page and mime file
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
A patch file from https://github.com/void-linux/void-packages/pull/45975.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-45975.patch --]
[-- Type: text/x-diff, Size: 1432 bytes --]
From 1b49593f61139c1e23f9b702515ca358437ffa4e Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Fri, 8 Sep 2023 22:36:28 +0500
Subject: [PATCH] godot: add man page and mime file
---
srcpkgs/godot/template | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index d75049c368521..d010da6455e1e 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,7 +1,7 @@
# Template file for 'godot'
pkgname=godot
version=4.1.1
-revision=4
+revision=5
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
# Build currently fails with embree-4.X
@@ -49,12 +49,15 @@ pre_build() {
export CXXFLAGS=" $CXXFLAGS "
}
+pre_install() {
+ sed -i 's/name="x/name="application-x/g' misc/dist/linux/org.godotengine.Godot.xml
+}
+
do_install() {
vlicense LICENSE.txt
vinstall ${FILESDIR}/godot.desktop 644 /usr/share/applications/
vinstall ${wrksrc}/icon.png 644 /usr/share/pixmaps/ godot.png
-
case "$XBPS_TARGET_MACHINE" in
x86_64*) vbin bin/godot.linuxbsd.editor.x86_64 godot;;
i686*) vbin bin/godot.linuxbsd.editor.x86_32 godot;;
@@ -62,4 +65,7 @@ do_install() {
armv7*) vbin bin/godot.linuxbsd.editor.arm32 godot;;
ppc64*) vbin bin/godot.linuxbsd.editor.ppc64 godot;;
esac
+
+ vinstall misc/dist/linux/org.godotengine.Godot.xml 644 /usr/share/mime/packages/
+ vman misc/dist/linux/godot.6
}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
` (2 preceding siblings ...)
2023-09-08 18:05 ` Luciogi
@ 2023-09-11 14:07 ` Luciogi
2023-09-11 14:10 ` ahesford
` (4 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-09-11 14:07 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 167 bytes --]
New comment by Luciogi on void-packages repository
https://github.com/void-linux/void-packages/pull/45975#issuecomment-1713964796
Comment:
@ahesford ping for merge
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
` (3 preceding siblings ...)
2023-09-11 14:07 ` Luciogi
@ 2023-09-11 14:10 ` ahesford
2023-09-12 5:38 ` [PR REVIEW] " classabbyamp
` (3 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: ahesford @ 2023-09-11 14:10 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 186 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/45975#issuecomment-1713969055
Comment:
Don't ping team members randomly about PRs.
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
` (4 preceding siblings ...)
2023-09-11 14:10 ` ahesford
@ 2023-09-12 5:38 ` classabbyamp
2023-09-12 12:37 ` [PR PATCH] [Updated] " Luciogi
` (2 subsequent siblings)
8 siblings, 0 replies; 10+ messages in thread
From: classabbyamp @ 2023-09-12 5:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 191 bytes --]
New review comment by classabbyamp on void-packages repository
https://github.com/void-linux/void-packages/pull/45975#discussion_r1322412908
Comment:
use vsed, and put this in post_patch()
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Updated] godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
` (5 preceding siblings ...)
2023-09-12 5:38 ` [PR REVIEW] " classabbyamp
@ 2023-09-12 12:37 ` Luciogi
2023-09-12 13:43 ` [PR REVIEW] " Luciogi
2023-09-19 4:55 ` [PR PATCH] [Merged]: " the-maldridge
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-09-12 12:37 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 506 bytes --]
There is an updated pull request by Luciogi against master on the void-packages repository
https://github.com/Luciogi/void-packages godot
https://github.com/void-linux/void-packages/pull/45975
godot: add man page and mime file
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
fixes #45917
A patch file from https://github.com/void-linux/void-packages/pull/45975.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-godot-45975.patch --]
[-- Type: text/x-diff, Size: 1435 bytes --]
From 7f48f6ff017a3c2a9d4973cca452ffc5073180ba Mon Sep 17 00:00:00 2001
From: Luciogi <lucigithubcommit@skiff.com>
Date: Fri, 8 Sep 2023 22:36:28 +0500
Subject: [PATCH] godot: add man page and mime file
---
srcpkgs/godot/template | 10 ++++++++--
1 file changed, 8 insertions(+), 2 deletions(-)
diff --git a/srcpkgs/godot/template b/srcpkgs/godot/template
index d75049c368521..f487838e20b51 100644
--- a/srcpkgs/godot/template
+++ b/srcpkgs/godot/template
@@ -1,7 +1,7 @@
# Template file for 'godot'
pkgname=godot
version=4.1.1
-revision=4
+revision=5
archs="x86_64* i686* aarch64* armv7* ppc64*"
build_style=scons
# Build currently fails with embree-4.X
@@ -49,12 +49,15 @@ pre_build() {
export CXXFLAGS=" $CXXFLAGS "
}
+post_patch() {
+ vsed -i misc/dist/linux/org.godotengine.Godot.xml -e 's/name="x/name="application-x/g'
+}
+
do_install() {
vlicense LICENSE.txt
vinstall ${FILESDIR}/godot.desktop 644 /usr/share/applications/
vinstall ${wrksrc}/icon.png 644 /usr/share/pixmaps/ godot.png
-
case "$XBPS_TARGET_MACHINE" in
x86_64*) vbin bin/godot.linuxbsd.editor.x86_64 godot;;
i686*) vbin bin/godot.linuxbsd.editor.x86_32 godot;;
@@ -62,4 +65,7 @@ do_install() {
armv7*) vbin bin/godot.linuxbsd.editor.arm32 godot;;
ppc64*) vbin bin/godot.linuxbsd.editor.ppc64 godot;;
esac
+
+ vinstall misc/dist/linux/org.godotengine.Godot.xml 644 /usr/share/mime/packages/
+ vman misc/dist/linux/godot.6
}
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR REVIEW] godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
` (6 preceding siblings ...)
2023-09-12 12:37 ` [PR PATCH] [Updated] " Luciogi
@ 2023-09-12 13:43 ` Luciogi
2023-09-19 4:55 ` [PR PATCH] [Merged]: " the-maldridge
8 siblings, 0 replies; 10+ messages in thread
From: Luciogi @ 2023-09-12 13:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 152 bytes --]
New review comment by Luciogi on void-packages repository
https://github.com/void-linux/void-packages/pull/45975#discussion_r1323068434
Comment:
done
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PR PATCH] [Merged]: godot: add man page and mime file
2023-09-08 17:40 [PR PATCH] godot: add man page and mime file Luciogi
` (7 preceding siblings ...)
2023-09-12 13:43 ` [PR REVIEW] " Luciogi
@ 2023-09-19 4:55 ` the-maldridge
8 siblings, 0 replies; 10+ messages in thread
From: the-maldridge @ 2023-09-19 4:55 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 352 bytes --]
There's a merged pull request on the void-packages repository
godot: add man page and mime file
https://github.com/void-linux/void-packages/pull/45975
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)
fixes #45917
^ permalink raw reply [flat|nested] 10+ messages in thread