From: ahesford <ahesford@users.noreply.github.com>
To: ml@inbox.vuxu.org
Subject: Re: python3-matplotlib: update to 3.8.0, also update deps
Date: Wed, 20 Sep 2023 17:07:18 +0200 [thread overview]
Message-ID: <20230920150718.b-mHLx8bG5Xi32U6CssXylDxasTVayBk5DkWs0-jmHU@z> (raw)
In-Reply-To: <gh-mailinglist-notifications-41a7ca26-5023-4802-975b-f1789d68868e-void-packages-46109@inbox.vuxu.org>
[-- Attachment #1: Type: text/plain, Size: 1386 bytes --]
New comment by ahesford on void-packages repository
https://github.com/void-linux/void-packages/pull/46109#issuecomment-1727917244
Comment:
I think the hook brings too much magic. Setting `$meson_crossfile` and having the file magically appear is not really intuitive, and hooks are also somewhat less discoverable than build styles and build helpers. It also makes it more difficult for users to write a custom `$meson_crossfile`, because the hook will clobber it. If there is an argument for putting this behavior in a hook rather than a build style, I think that
1. It ought to write somewhere like `$XBPS_WRAPPERDIR`, which is a good place for "automatic" XBPS stuff.
2. It ought to be controlled by an indepedent variable (which is my major argument for using the helper; you opt in by adding the meson helper, but you can fine-tune `$meson_crossfile` as desired).
I seem to have https://github.com/void-linux/void-packages/pull/46117 working as expected but will do a more thorough test, and I've moved `python3-scipy` to this new mechanism over there (the dependencies for scipy complicate things quite a bit and don't really provide an advantage for `python3-pep517+meson` over `meson+python3`, but the helper should make your `contourpy` update no more complicated than it is with your hook approach.
Comments on the merits of the competing approach are appreciated.
next prev parent reply other threads:[~2023-09-20 15:07 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-17 23:39 [PR PATCH] " tornaria
2023-09-17 23:41 ` tornaria
2023-09-17 23:43 ` tornaria
2023-09-18 0:09 ` tornaria
2023-09-20 3:03 ` [PR PATCH] [Updated] " tornaria
2023-09-20 3:09 ` tornaria
2023-09-20 3:11 ` tornaria
2023-09-20 3:34 ` [PR PATCH] [Updated] " tornaria
2023-09-20 4:22 ` tornaria
2023-09-20 4:40 ` [PR PATCH] [Updated] " tornaria
2023-09-20 4:42 ` tornaria
2023-09-20 15:07 ` ahesford [this message]
2023-09-20 15:14 ` ahesford
2023-09-20 23:47 ` [PR PATCH] [Updated] " tornaria
2023-09-20 23:49 ` tornaria
2023-09-23 11:59 ` [PR PATCH] [Updated] " tornaria
2023-09-23 12:01 ` tornaria
2023-09-23 17:00 ` ahesford
2023-09-23 17:26 ` tornaria
2023-09-23 17:29 ` [PR PATCH] [Updated] " tornaria
2023-09-23 17:30 ` tornaria
2023-09-23 17:32 ` tornaria
2023-09-23 17:33 ` ahesford
2023-09-23 17:37 ` tornaria
2023-09-23 17:47 ` ahesford
2023-09-23 17:54 ` tornaria
2023-09-23 17:54 ` ahesford
2023-09-23 17:55 ` [PR PATCH] [Merged]: " ahesford
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230920150718.b-mHLx8bG5Xi32U6CssXylDxasTVayBk5DkWs0-jmHU@z \
--to=ahesford@users.noreply.github.com \
--cc=ml@inbox.vuxu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).