[PR PATCH] liburing: update to 2.4.

[PR PATCH] liburing: update to 2.4.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 472 bytes --]

There is a new pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages liburing
https://github.com/void-linux/void-packages/pull/46255

liburing: update to 2.4.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/46255.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liburing-46255.patch --]
[-- Type: text/x-diff, Size: 1073 bytes --]

From 869e9109df8f272e04c409762ce28d11dc0bf565 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 5 Sep 2023 00:00:51 +0530
Subject: [PATCH] liburing: update to 2.4.

---
 srcpkgs/liburing/template | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/liburing/template b/srcpkgs/liburing/template
index 897f2ca2fdbd1..6aea139d9b583 100644
--- a/srcpkgs/liburing/template
+++ b/srcpkgs/liburing/template
@@ -1,6 +1,6 @@
 # Template file for 'liburing'
 pkgname=liburing
-version=2.3
+version=2.4
 revision=1
 build_style=configure
 configure_args="--mandir=/usr/share/man"
@@ -11,7 +11,7 @@ license="LGPL-2.1-only"
 homepage="https://git.kernel.dk/cgit/liburing"
 changelog="https://git.kernel.dk/cgit/liburing/plain/CHANGELOG"
 distfiles="https://git.kernel.dk/cgit/liburing/snapshot/liburing-${version}.tar.gz"
-checksum=a65a6adbe80425c1c4d0740532ba42c3d4fd9dadd17a0e0bfd31c29e1c14dba8
+checksum=b5fbb1f6d65d88a8b37cbf3f5d4a7fa38d1d9e928a83df79c6469ed816bbcacc
 
 liburing-devel_package() {
 	short_desc+=" - development files"

Re: [PR PATCH] [Updated] liburing: update to 2.4.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 477 bytes --]

There is an updated pull request by icp1994 against master on the void-packages repository

https://github.com/icp1994/void-packages liburing
https://github.com/void-linux/void-packages/pull/46255

liburing: update to 2.4.
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**

A patch file from https://github.com/void-linux/void-packages/pull/46255.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-liburing-46255.patch --]
[-- Type: text/x-diff, Size: 2788 bytes --]

From 255ba588cac9a2f936fbd220a0e16c13d23f68f0 Mon Sep 17 00:00:00 2001
From: icp <pangolin@vivaldi.net>
Date: Tue, 5 Sep 2023 00:00:51 +0530
Subject: [PATCH] liburing: update to 2.4.

---
 .../liburing/patches/no-stack-protector.patch | 36 +++++++++++++++++++
 srcpkgs/liburing/template                     |  8 +++--
 2 files changed, 42 insertions(+), 2 deletions(-)
 create mode 100644 srcpkgs/liburing/patches/no-stack-protector.patch

diff --git a/srcpkgs/liburing/patches/no-stack-protector.patch b/srcpkgs/liburing/patches/no-stack-protector.patch
new file mode 100644
index 0000000000000..04ba4eb0340d2
--- /dev/null
+++ b/srcpkgs/liburing/patches/no-stack-protector.patch
@@ -0,0 +1,36 @@
+From 319f4be8bd049055c333185928758d0fb445fc43 Mon Sep 17 00:00:00 2001
+From: Guillem Jover <guillem@hadrons.org>
+Date: Tue, 13 Jun 2023 00:36:21 +0200
+Subject: build: Disable stack protector unconditionally
+
+At least when building with nolibc, we cannot use the stack protector
+as we will end up with undefined references to __stack_chk_fail which
+is provided by the libc. We need to add the -fno-stack-protector
+unconditionally to the CFLAGS append override.
+
+This seems to have been the intent behind the introduction of this
+change in commit 2de98320d5b02951936fc0ab677dd01e4fb2a7a7.
+
+Signed-off-by: Guillem Jover <guillem@hadrons.org>
+---
+ src/Makefile | 3 ++-
+ 1 file changed, 2 insertions(+), 1 deletion(-)
+
+diff --git a/src/Makefile b/src/Makefile
+index cba4d27..f57348b 100644
+--- a/src/Makefile
++++ b/src/Makefile
+@@ -10,8 +10,9 @@ CPPFLAGS ?=
+ override CPPFLAGS += -D_GNU_SOURCE \
+ 	-Iinclude/ -include ../config-host.h \
+ 	-D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64
+-CFLAGS ?= -g -O3 -Wall -Wextra -fno-stack-protector
++CFLAGS ?= -g -O3 -Wall -Wextra
+ override CFLAGS += -Wno-unused-parameter \
++	-fno-stack-protector \
+ 	-DLIBURING_INTERNAL \
+ 	$(LIBURING_CFLAGS)
+ SO_CFLAGS=-fPIC $(CFLAGS)
+-- 
+cgit v1.2.3
+
diff --git a/srcpkgs/liburing/template b/srcpkgs/liburing/template
index 897f2ca2fdbd1..8ff6e2bf83f7d 100644
--- a/srcpkgs/liburing/template
+++ b/srcpkgs/liburing/template
@@ -1,6 +1,6 @@
 # Template file for 'liburing'
 pkgname=liburing
-version=2.3
+version=2.4
 revision=1
 build_style=configure
 configure_args="--mandir=/usr/share/man"
@@ -11,7 +11,11 @@ license="LGPL-2.1-only"
 homepage="https://git.kernel.dk/cgit/liburing"
 changelog="https://git.kernel.dk/cgit/liburing/plain/CHANGELOG"
 distfiles="https://git.kernel.dk/cgit/liburing/snapshot/liburing-${version}.tar.gz"
-checksum=a65a6adbe80425c1c4d0740532ba42c3d4fd9dadd17a0e0bfd31c29e1c14dba8
+checksum=b5fbb1f6d65d88a8b37cbf3f5d4a7fa38d1d9e928a83df79c6469ed816bbcacc
+
+do_check() {
+	make -C test
+}
 
 liburing-devel_package() {
 	short_desc+=" - development files"

Re: [PR REVIEW] liburing: update to 2.4.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 218 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46255#discussion_r1342296508

Comment:
could this be done with `make_check_args` or `make_check_target`?

Re: [PR REVIEW] liburing: update to 2.4.

[icp1994]

[-- Attachment #1: Type: text/plain, Size: 236 bytes --]

New review comment by icp1994 on void-packages repository

https://github.com/void-linux/void-packages/pull/46255#discussion_r1342303848

Comment:
yeah but it's two lines though
```
make_check_args="-C"
make_check_target="test"
```

Re: [PR PATCH] [Merged]: liburing: update to 2.4.

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 320 bytes --]

There's a merged pull request on the void-packages repository

liburing: update to 2.4.
https://github.com/void-linux/void-packages/pull/46255

Description:
#### Testing the changes
- I tested the changes in this PR: **YES**

#### Local build testing
- I built this PR locally for my native architecture: **x86_64**