Re: [PR PATCH] [Updated] python3-ipyparallel: enable check

Re: [PR PATCH] [Updated] python3-ipyparallel: enable check

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages ipyparallel
https://github.com/void-linux/void-packages/pull/46209

python3-ipyparallel: enable check
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46209.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ipyparallel-46209.patch --]
[-- Type: text/x-diff, Size: 1550 bytes --]

From e7ad652437b148d50f88bf4bd96b71b24f30a6e0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 23 May 2023 23:14:55 -0300
Subject: [PATCH] python3-ipyparallel: enable check

---
 srcpkgs/python3-ipyparallel/template | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-ipyparallel/template b/srcpkgs/python3-ipyparallel/template
index 9c86bba760a04..41aa22548b809 100644
--- a/srcpkgs/python3-ipyparallel/template
+++ b/srcpkgs/python3-ipyparallel/template
@@ -7,6 +7,9 @@ hostmakedepends="hatchling"
 depends="python3-entrypoints python3-decorator python3-pyzmq python3-traitlets
  python3-ipython python3-jupyter_client python3-ipython_ipykernel
  python3-tornado python3-psutil python3-dateutil python3-tqdm"
+checkdepends="$depends python3-pytest python3-pytest-asyncio
+ python3-testpath python3-matplotlib python3-joblib python3-numpy
+ python3-pandas"
 short_desc="Interactive parallel computing in Python"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="BSD-3-Clause"
@@ -14,8 +17,11 @@ homepage="https://ipyparallel.readthedocs.io/"
 changelog="https://ipyparallel.readthedocs.io/en/latest/changelog.html"
 distfiles="${PYPI_SITE}/i/ipyparallel/ipyparallel-${version}.tar.gz"
 checksum=a39aa5ef9560170bf0e9afedca9ff045e1b9c1832c49303377edcc91cea9fb77
-# Too many tests fail with a "local" cluster type
-make_check=no
+
+pre_check() {
+	# having HOME=/tmp confuses a few tests
+	HOME=/home
+}
 
 post_install() {
 	vlicense COPYING.md

Re: [PR PATCH] [Updated] python3-ipyparallel: enable check

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages ipyparallel
https://github.com/void-linux/void-packages/pull/46209

python3-ipyparallel: enable check
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46209.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ipyparallel-46209.patch --]
[-- Type: text/x-diff, Size: 1711 bytes --]

From 2775c18861c90dae2a6f3b6056a74fb705fc5461 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 23 May 2023 23:14:55 -0300
Subject: [PATCH] python3-ipyparallel: enable check

---
 srcpkgs/python3-ipyparallel/template | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-ipyparallel/template b/srcpkgs/python3-ipyparallel/template
index 9c86bba760a04..286d38be7a5c9 100644
--- a/srcpkgs/python3-ipyparallel/template
+++ b/srcpkgs/python3-ipyparallel/template
@@ -7,6 +7,9 @@ hostmakedepends="hatchling"
 depends="python3-entrypoints python3-decorator python3-pyzmq python3-traitlets
  python3-ipython python3-jupyter_client python3-ipython_ipykernel
  python3-tornado python3-psutil python3-dateutil python3-tqdm"
+checkdepends="$depends python3-pytest python3-pytest-asyncio
+ python3-testpath python3-matplotlib python3-joblib python3-numpy
+ python3-pandas"
 short_desc="Interactive parallel computing in Python"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="BSD-3-Clause"
@@ -14,8 +17,16 @@ homepage="https://ipyparallel.readthedocs.io/"
 changelog="https://ipyparallel.readthedocs.io/en/latest/changelog.html"
 distfiles="${PYPI_SITE}/i/ipyparallel/ipyparallel-${version}.tar.gz"
 checksum=a39aa5ef9560170bf0e9afedca9ff045e1b9c1832c49303377edcc91cea9fb77
-# Too many tests fail with a "local" cluster type
-make_check=no
+
+if [[ "$XBPS_TARGET_MACHINE" = *-musl ]]; then
+	# this test fails in musl, locally and on ci
+	make_check_args="-k not(test_ipcluster_start_stop)"
+fi
+
+pre_check() {
+	# having HOME=/tmp confuses a few tests
+	HOME=/home
+}
 
 post_install() {
 	vlicense COPYING.md

Re: [PR PATCH] [Updated] python3-ipyparallel: enable check

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages ipyparallel
https://github.com/void-linux/void-packages/pull/46209

python3-ipyparallel: enable check
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46209.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ipyparallel-46209.patch --]
[-- Type: text/x-diff, Size: 1636 bytes --]

From 0d58a25b86e00ccce95acdececb39bc537849cd6 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 23 May 2023 23:14:55 -0300
Subject: [PATCH] python3-ipyparallel: enable check

---
 srcpkgs/python3-ipyparallel/template | 13 +++++++++++--
 1 file changed, 11 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-ipyparallel/template b/srcpkgs/python3-ipyparallel/template
index 9c86bba760a04..53d51b3ba26b2 100644
--- a/srcpkgs/python3-ipyparallel/template
+++ b/srcpkgs/python3-ipyparallel/template
@@ -7,6 +7,9 @@ hostmakedepends="hatchling"
 depends="python3-entrypoints python3-decorator python3-pyzmq python3-traitlets
  python3-ipython python3-jupyter_client python3-ipython_ipykernel
  python3-tornado python3-psutil python3-dateutil python3-tqdm"
+checkdepends="$depends python3-pytest python3-pytest-asyncio
+ python3-testpath python3-matplotlib python3-joblib python3-numpy
+ python3-pandas"
 short_desc="Interactive parallel computing in Python"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="BSD-3-Clause"
@@ -14,8 +17,14 @@ homepage="https://ipyparallel.readthedocs.io/"
 changelog="https://ipyparallel.readthedocs.io/en/latest/changelog.html"
 distfiles="${PYPI_SITE}/i/ipyparallel/ipyparallel-${version}.tar.gz"
 checksum=a39aa5ef9560170bf0e9afedca9ff045e1b9c1832c49303377edcc91cea9fb77
-# Too many tests fail with a "local" cluster type
-make_check=no
+
+# Seems broken in musl
+[[ "$XBPS_TARGET_MACHINE" = *-musl ]] && make_check=no
+
+pre_check() {
+	# having HOME=/tmp confuses a few tests
+	HOME=/home
+}
 
 post_install() {
 	vlicense COPYING.md

Re: python3-ipyparallel: enable check

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 737 bytes --]

New comment by tornaria on void-packages repository

https://github.com/void-linux/void-packages/pull/46209#issuecomment-1732777518

Comment:
@ahesford I had to disable check on musl since it's broken, both in CI and locally. The cluster just gets stuck (it seems a python process dies but the parent doesn't realize).

The checks pass just fine in x86_64 and i686 (both locally and in all my pushes to gh), so this is better than what was there before.

I'm not looking into it anymore. As a starting point, `ipyparallel/tests/test_apps.py::test_ipcluster_start_stop` always fails. But then other files sometimes result in all errors (not failures), sometimes they don't (test_asyncresult.py, test_client.py, test_cluster.py, ...).

Re: [PR REVIEW] python3-ipyparallel: enable check

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 311 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/46209#discussion_r1335306890

Comment:
This should just be `make_check_pre="env HOME=/home"`, both because it is simpler and will avoid setting `$HOME` in a way that could influence later build stages.

Re: [PR REVIEW] python3-ipyparallel: enable check

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 269 bytes --]

New review comment by ahesford on void-packages repository

https://github.com/void-linux/void-packages/pull/46209#discussion_r1335307528

Comment:
```suggestion
# Seems broken in musl
if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
	make_check=no
fi
```
is idiomatic.

Re: [PR PATCH] [Updated] python3-ipyparallel: enable check

[tornaria]

[-- Attachment #1: Type: text/plain, Size: 1264 bytes --]

There is an updated pull request by tornaria against master on the void-packages repository

https://github.com/tornaria/void-packages ipyparallel
https://github.com/void-linux/void-packages/pull/46209

python3-ipyparallel: enable check
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->


A patch file from https://github.com/void-linux/void-packages/pull/46209.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-ipyparallel-46209.patch --]
[-- Type: text/x-diff, Size: 1646 bytes --]

From ad47fa92a233271cd2485dbb117d2a64a8f79674 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Gonzalo=20Tornar=C3=ADa?= <tornaria@cmat.edu.uy>
Date: Tue, 23 May 2023 23:14:55 -0300
Subject: [PATCH] python3-ipyparallel: enable check

---
 srcpkgs/python3-ipyparallel/template | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/srcpkgs/python3-ipyparallel/template b/srcpkgs/python3-ipyparallel/template
index 9c86bba760a04..ef30202d70f98 100644
--- a/srcpkgs/python3-ipyparallel/template
+++ b/srcpkgs/python3-ipyparallel/template
@@ -7,6 +7,9 @@ hostmakedepends="hatchling"
 depends="python3-entrypoints python3-decorator python3-pyzmq python3-traitlets
  python3-ipython python3-jupyter_client python3-ipython_ipykernel
  python3-tornado python3-psutil python3-dateutil python3-tqdm"
+checkdepends="$depends python3-pytest python3-pytest-asyncio
+ python3-testpath python3-matplotlib python3-joblib python3-numpy
+ python3-pandas"
 short_desc="Interactive parallel computing in Python"
 maintainer="Andrew J. Hesford <ajh@sideband.org>"
 license="BSD-3-Clause"
@@ -14,8 +17,13 @@ homepage="https://ipyparallel.readthedocs.io/"
 changelog="https://ipyparallel.readthedocs.io/en/latest/changelog.html"
 distfiles="${PYPI_SITE}/i/ipyparallel/ipyparallel-${version}.tar.gz"
 checksum=a39aa5ef9560170bf0e9afedca9ff045e1b9c1832c49303377edcc91cea9fb77
-# Too many tests fail with a "local" cluster type
-make_check=no
+# having HOME=/tmp confuses a few tests
+make_check_pre="env HOME=/home"
+
+if [ "$XBPS_TARGET_LIBC" = "musl" ]; then
+	# tests are broken in musl
+	make_check=no
+fi
 
 post_install() {
 	vlicense COPYING.md

Re: [PR PATCH] [Merged]: python3-ipyparallel: enable check

[ahesford]

[-- Attachment #1: Type: text/plain, Size: 1102 bytes --]

There's a merged pull request on the void-packages repository

python3-ipyparallel: enable check
https://github.com/void-linux/void-packages/pull/46209

Description:
<!-- Uncomment relevant sections and delete options which are not applicable -->

#### Testing the changes
- I tested the changes in this PR: **briefly**



<!--
#### New package
- This new package conforms to the [package requirements](https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#package-requirements): **YES**|**NO**
-->

<!-- Note: If the build is likely to take more than 2 hours, please add ci skip tag as described in
https://github.com/void-linux/void-packages/blob/master/CONTRIBUTING.md#continuous-integration
and test at least one native build and, if supported, at least one cross build.
Ignore this section if this PR is not skipping CI.
-->
<!--
#### Local build testing
- I built this PR locally for my native architecture, (ARCH-LIBC)
- I built this PR locally for these architectures (if supported. mark crossbuilds):
  - aarch64-musl
  - armv7l
  - armv6l-musl
-->