Github messages for voidlinux
 help / color / mirror / Atom feed
* [PR PATCH] New package: galene-0.7.2.
@ 2023-09-25  4:06 the-maldridge
  2023-09-25  5:38 ` classabbyamp
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: the-maldridge @ 2023-09-25  4:06 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 566 bytes --]

There is a new pull request by the-maldridge against master on the void-packages repository

https://github.com/the-maldridge/void-packages galene
https://github.com/void-linux/void-packages/pull/46236

New package: galene-0.7.2.
I'm not 100% sure on the args format, I'd like some feedback on if we want to use arrays for service arguments.  I'd also appreciate testing on this since I typically build galene from source at `HEAD` wherever that happens to be at the time.


A patch file from https://github.com/void-linux/void-packages/pull/46236.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-galene-46236.patch --]
[-- Type: text/x-diff, Size: 1697 bytes --]

From e40c6f3f3d7783bdeb0b629445c5dca36ba4279c Mon Sep 17 00:00:00 2001
From: Michael Aldridge <maldridge@voidlinux.org>
Date: Sun, 24 Sep 2023 23:04:47 -0500
Subject: [PATCH] New package: galene-0.7.2.

---
 srcpkgs/galene/files/galene/run |  9 +++++++++
 srcpkgs/galene/template         | 22 ++++++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 srcpkgs/galene/files/galene/run
 create mode 100644 srcpkgs/galene/template

diff --git a/srcpkgs/galene/files/galene/run b/srcpkgs/galene/files/galene/run
new file mode 100644
index 0000000000000..9b9ac409851c4
--- /dev/null
+++ b/srcpkgs/galene/files/galene/run
@@ -0,0 +1,9 @@
+#!/bin/bash
+
+args=$(
+    "-data" "/var/lib/galene"
+    "-groups" "/etc/galene"
+    "-static" "/usr/share/galene/static"
+)
+[ -r conf ] && . ./conf
+exec chpst -u _galene /usr/bin/galene "${args[@]}"
diff --git a/srcpkgs/galene/template b/srcpkgs/galene/template
new file mode 100644
index 0000000000000..b5ae5232936b6
--- /dev/null
+++ b/srcpkgs/galene/template
@@ -0,0 +1,22 @@
+# Template file for 'galene'
+pkgname=galene
+version=0.7.2
+revision=1
+build_style=go
+go_import_path=github.com/jech/galene
+short_desc="Galene videoconference server"
+maintainer="Michael Aldridge <maldridge@voidlinux.org>"
+license="MIT"
+homepage="https://galene.org"
+distfiles="https://github.com/jech/galene/archive/refs/tags/galene-$version.tar.gz"
+checksum=d238d862d84b5126762cc82aaeb249eb9c55e96f241050d5e7158a264ae4f0fb
+system_accounts="_galene"
+make_dirs="/etc/galene/ 0750 root _galene
+ /var/lib/galene 0750 _galene _galene"
+
+post_install() {
+	vlicense LICENCE
+	vmkdir usr/share/galene/
+	vcopy static usr/share/galene/
+	vsv galene
+}

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: New package: galene-0.7.2.
  2023-09-25  4:06 [PR PATCH] New package: galene-0.7.2 the-maldridge
@ 2023-09-25  5:38 ` classabbyamp
  2023-09-25  7:27 ` [PR PATCH] [Updated] " the-maldridge
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-09-25  5:38 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

New comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46236#issuecomment-1732952901

Comment:
I think using bash for services is probably discouraged due to it being not 100% guaranteed on a system?

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] New package: galene-0.7.2.
  2023-09-25  4:06 [PR PATCH] New package: galene-0.7.2 the-maldridge
  2023-09-25  5:38 ` classabbyamp
@ 2023-09-25  7:27 ` the-maldridge
  2023-09-25  7:29 ` [PR REVIEW] " classabbyamp
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: the-maldridge @ 2023-09-25  7:27 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

There is an updated pull request by the-maldridge against master on the void-packages repository

https://github.com/the-maldridge/void-packages galene
https://github.com/void-linux/void-packages/pull/46236

New package: galene-0.7.2.
I'm not 100% sure on the args format, I'd like some feedback on if we want to use arrays for service arguments.  I'd also appreciate testing on this since I typically build galene from source at `HEAD` wherever that happens to be at the time.


A patch file from https://github.com/void-linux/void-packages/pull/46236.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-galene-46236.patch --]
[-- Type: text/x-diff, Size: 1656 bytes --]

From 654669a7719cfa0f95c47ac37def216a1f62a178 Mon Sep 17 00:00:00 2001
From: Michael Aldridge <maldridge@voidlinux.org>
Date: Sun, 24 Sep 2023 23:04:47 -0500
Subject: [PATCH] New package: galene-0.7.2.

---
 srcpkgs/galene/files/galene/run |  6 ++++++
 srcpkgs/galene/template         | 22 ++++++++++++++++++++++
 2 files changed, 28 insertions(+)
 create mode 100644 srcpkgs/galene/files/galene/run
 create mode 100644 srcpkgs/galene/template

diff --git a/srcpkgs/galene/files/galene/run b/srcpkgs/galene/files/galene/run
new file mode 100644
index 0000000000000..1f81d1982c143
--- /dev/null
+++ b/srcpkgs/galene/files/galene/run
@@ -0,0 +1,6 @@
+#!/bin/sh
+
+ARGS="-data /var/lib/galene -groups /etc/galene -static /usr/share/galene/static"
+
+[ -r conf ] && . ./conf
+exec chpst -u _galene /usr/bin/galene $ARGS
diff --git a/srcpkgs/galene/template b/srcpkgs/galene/template
new file mode 100644
index 0000000000000..b5ae5232936b6
--- /dev/null
+++ b/srcpkgs/galene/template
@@ -0,0 +1,22 @@
+# Template file for 'galene'
+pkgname=galene
+version=0.7.2
+revision=1
+build_style=go
+go_import_path=github.com/jech/galene
+short_desc="Galene videoconference server"
+maintainer="Michael Aldridge <maldridge@voidlinux.org>"
+license="MIT"
+homepage="https://galene.org"
+distfiles="https://github.com/jech/galene/archive/refs/tags/galene-$version.tar.gz"
+checksum=d238d862d84b5126762cc82aaeb249eb9c55e96f241050d5e7158a264ae4f0fb
+system_accounts="_galene"
+make_dirs="/etc/galene/ 0750 root _galene
+ /var/lib/galene 0750 _galene _galene"
+
+post_install() {
+	vlicense LICENCE
+	vmkdir usr/share/galene/
+	vcopy static usr/share/galene/
+	vsv galene
+}

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR REVIEW] New package: galene-0.7.2.
  2023-09-25  4:06 [PR PATCH] New package: galene-0.7.2 the-maldridge
  2023-09-25  5:38 ` classabbyamp
  2023-09-25  7:27 ` [PR PATCH] [Updated] " the-maldridge
@ 2023-09-25  7:29 ` classabbyamp
  2023-09-26  7:41 ` [PR PATCH] [Updated] " the-maldridge
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: classabbyamp @ 2023-09-25  7:29 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 226 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46236#discussion_r1335491223

Comment:
```suggestion
exec 2>&1
```
so the generated log service captures stderr


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] New package: galene-0.7.2.
  2023-09-25  4:06 [PR PATCH] New package: galene-0.7.2 the-maldridge
                   ` (2 preceding siblings ...)
  2023-09-25  7:29 ` [PR REVIEW] " classabbyamp
@ 2023-09-26  7:41 ` the-maldridge
  2023-09-29  5:10 ` the-maldridge
  2023-09-29  5:10 ` [PR PATCH] [Merged]: " the-maldridge
  5 siblings, 0 replies; 7+ messages in thread
From: the-maldridge @ 2023-09-26  7:41 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

There is an updated pull request by the-maldridge against master on the void-packages repository

https://github.com/the-maldridge/void-packages galene
https://github.com/void-linux/void-packages/pull/46236

New package: galene-0.7.2.
I'm not 100% sure on the args format, I'd like some feedback on if we want to use arrays for service arguments.  I'd also appreciate testing on this since I typically build galene from source at `HEAD` wherever that happens to be at the time.


A patch file from https://github.com/void-linux/void-packages/pull/46236.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-galene-46236.patch --]
[-- Type: text/x-diff, Size: 1701 bytes --]

From c9cd5f0fd0ab14ff4bea83a6c8a0ef620f2eae9b Mon Sep 17 00:00:00 2001
From: Michael Aldridge <maldridge@voidlinux.org>
Date: Sun, 24 Sep 2023 23:04:47 -0500
Subject: [PATCH] New package: galene-0.7.2.

---
 srcpkgs/galene/files/galene/run |  9 +++++++++
 srcpkgs/galene/template         | 22 ++++++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 srcpkgs/galene/files/galene/run
 create mode 100644 srcpkgs/galene/template

diff --git a/srcpkgs/galene/files/galene/run b/srcpkgs/galene/files/galene/run
new file mode 100644
index 0000000000000..aa5e12d1d9924
--- /dev/null
+++ b/srcpkgs/galene/files/galene/run
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+exec 2>&1
+
+[ -r conf ] && . ./conf
+if [ "$#" = 0 ] ; then
+    set -- -data /var/lib/galene -groups /etc/galene -static /usr/share/galene/static
+fi
+exec chpst -u _galene /usr/bin/galene "$@"
diff --git a/srcpkgs/galene/template b/srcpkgs/galene/template
new file mode 100644
index 0000000000000..b5ae5232936b6
--- /dev/null
+++ b/srcpkgs/galene/template
@@ -0,0 +1,22 @@
+# Template file for 'galene'
+pkgname=galene
+version=0.7.2
+revision=1
+build_style=go
+go_import_path=github.com/jech/galene
+short_desc="Galene videoconference server"
+maintainer="Michael Aldridge <maldridge@voidlinux.org>"
+license="MIT"
+homepage="https://galene.org"
+distfiles="https://github.com/jech/galene/archive/refs/tags/galene-$version.tar.gz"
+checksum=d238d862d84b5126762cc82aaeb249eb9c55e96f241050d5e7158a264ae4f0fb
+system_accounts="_galene"
+make_dirs="/etc/galene/ 0750 root _galene
+ /var/lib/galene 0750 _galene _galene"
+
+post_install() {
+	vlicense LICENCE
+	vmkdir usr/share/galene/
+	vcopy static usr/share/galene/
+	vsv galene
+}

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Updated] New package: galene-0.7.2.
  2023-09-25  4:06 [PR PATCH] New package: galene-0.7.2 the-maldridge
                   ` (3 preceding siblings ...)
  2023-09-26  7:41 ` [PR PATCH] [Updated] " the-maldridge
@ 2023-09-29  5:10 ` the-maldridge
  2023-09-29  5:10 ` [PR PATCH] [Merged]: " the-maldridge
  5 siblings, 0 replies; 7+ messages in thread
From: the-maldridge @ 2023-09-29  5:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 571 bytes --]

There is an updated pull request by the-maldridge against master on the void-packages repository

https://github.com/the-maldridge/void-packages galene
https://github.com/void-linux/void-packages/pull/46236

New package: galene-0.7.2.
I'm not 100% sure on the args format, I'd like some feedback on if we want to use arrays for service arguments.  I'd also appreciate testing on this since I typically build galene from source at `HEAD` wherever that happens to be at the time.


A patch file from https://github.com/void-linux/void-packages/pull/46236.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-galene-46236.patch --]
[-- Type: text/x-diff, Size: 1701 bytes --]

From 1312218aa63bf03de4d3f98dff686923d0db5de3 Mon Sep 17 00:00:00 2001
From: Michael Aldridge <maldridge@voidlinux.org>
Date: Sun, 24 Sep 2023 23:04:47 -0500
Subject: [PATCH] New package: galene-0.7.2.

---
 srcpkgs/galene/files/galene/run |  9 +++++++++
 srcpkgs/galene/template         | 22 ++++++++++++++++++++++
 2 files changed, 31 insertions(+)
 create mode 100644 srcpkgs/galene/files/galene/run
 create mode 100644 srcpkgs/galene/template

diff --git a/srcpkgs/galene/files/galene/run b/srcpkgs/galene/files/galene/run
new file mode 100644
index 0000000000000..aa5e12d1d9924
--- /dev/null
+++ b/srcpkgs/galene/files/galene/run
@@ -0,0 +1,9 @@
+#!/bin/sh
+
+exec 2>&1
+
+[ -r conf ] && . ./conf
+if [ "$#" = 0 ] ; then
+    set -- -data /var/lib/galene -groups /etc/galene -static /usr/share/galene/static
+fi
+exec chpst -u _galene /usr/bin/galene "$@"
diff --git a/srcpkgs/galene/template b/srcpkgs/galene/template
new file mode 100644
index 0000000000000..b5ae5232936b6
--- /dev/null
+++ b/srcpkgs/galene/template
@@ -0,0 +1,22 @@
+# Template file for 'galene'
+pkgname=galene
+version=0.7.2
+revision=1
+build_style=go
+go_import_path=github.com/jech/galene
+short_desc="Galene videoconference server"
+maintainer="Michael Aldridge <maldridge@voidlinux.org>"
+license="MIT"
+homepage="https://galene.org"
+distfiles="https://github.com/jech/galene/archive/refs/tags/galene-$version.tar.gz"
+checksum=d238d862d84b5126762cc82aaeb249eb9c55e96f241050d5e7158a264ae4f0fb
+system_accounts="_galene"
+make_dirs="/etc/galene/ 0750 root _galene
+ /var/lib/galene 0750 _galene _galene"
+
+post_install() {
+	vlicense LICENCE
+	vmkdir usr/share/galene/
+	vcopy static usr/share/galene/
+	vsv galene
+}

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PR PATCH] [Merged]: New package: galene-0.7.2.
  2023-09-25  4:06 [PR PATCH] New package: galene-0.7.2 the-maldridge
                   ` (4 preceding siblings ...)
  2023-09-29  5:10 ` the-maldridge
@ 2023-09-29  5:10 ` the-maldridge
  5 siblings, 0 replies; 7+ messages in thread
From: the-maldridge @ 2023-09-29  5:10 UTC (permalink / raw)
  To: ml

[-- Attachment #1: Type: text/plain, Size: 404 bytes --]

There's a merged pull request on the void-packages repository

New package: galene-0.7.2.
https://github.com/void-linux/void-packages/pull/46236

Description:
I'm not 100% sure on the args format, I'd like some feedback on if we want to use arrays for service arguments.  I'd also appreciate testing on this since I typically build galene from source at `HEAD` wherever that happens to be at the time.


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-09-29  5:10 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-25  4:06 [PR PATCH] New package: galene-0.7.2 the-maldridge
2023-09-25  5:38 ` classabbyamp
2023-09-25  7:27 ` [PR PATCH] [Updated] " the-maldridge
2023-09-25  7:29 ` [PR REVIEW] " classabbyamp
2023-09-26  7:41 ` [PR PATCH] [Updated] " the-maldridge
2023-09-29  5:10 ` the-maldridge
2023-09-29  5:10 ` [PR PATCH] [Merged]: " the-maldridge

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).