* Re: [PR REVIEW] gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
@ 2023-10-02 3:49 ` sgn
2023-10-02 3:49 ` [PR PATCH] [Updated] " sgn
` (8 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2023-10-02 3:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 267 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/46368#discussion_r1342261301
Comment:
```suggestion
distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}-1.tar.gz"
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
2023-10-02 3:49 ` [PR REVIEW] " sgn
@ 2023-10-02 3:49 ` sgn
2023-10-02 3:53 ` [PR REVIEW] " sgn
` (7 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2023-10-02 3:49 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
There is an updated pull request by sgn against master on the void-packages repository
https://github.com/cinerea0/void-packages gnucash
https://github.com/void-linux/void-packages/pull/46368
gnucash: update to 5.4
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/46368.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-46368.patch --]
[-- Type: text/x-diff, Size: 2188 bytes --]
From 0a65e80fd536c6156f3a0483c4a38e466e7d9734 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Sun, 1 Oct 2023 22:09:28 -0400
Subject: [PATCH 1/2] gnucash: update to 5.4
---
srcpkgs/gnucash/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 1a5d08e02469f..7118efeef8107 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=5.3
-revision=2
+version=5.4
+revision=1
build_style=cmake
make_check_target=check
configure_args="-DWITH_PYTHON=1 -DCOMPILE_GSCHEMAS=OFF"
@@ -17,7 +17,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
changelog="https://raw.githubusercontent.com/Gnucash/gnucash/stable/NEWS"
distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}.tar.gz"
-checksum=e0d04e0fd5f03f39136e1f4d941ccd0202b64a6e92418f5382cb6a6772493529
+checksum=9d3eb3cd63730cf34d4c14dea6921bfe57f3936e0ca6e17ffc04c38dc1b40061
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 272e2dea052e03126cd918abc1179b101fe5d4d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<sgn.danh@gmail.com>
Date: Mon, 2 Oct 2023 10:49:44 +0700
Subject: [PATCH 2/2] Update srcpkgs/gnucash/template
---
srcpkgs/gnucash/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 7118efeef8107..91a786520c4ce 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -16,7 +16,7 @@ maintainer="ManfredU <mu@usselmann.it>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
changelog="https://raw.githubusercontent.com/Gnucash/gnucash/stable/NEWS"
-distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}.tar.gz"
+distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}-1.tar.gz"
checksum=9d3eb3cd63730cf34d4c14dea6921bfe57f3936e0ca6e17ffc04c38dc1b40061
pycompile_dirs="usr/share/gnucash/python"
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR REVIEW] gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
2023-10-02 3:49 ` [PR REVIEW] " sgn
2023-10-02 3:49 ` [PR PATCH] [Updated] " sgn
@ 2023-10-02 3:53 ` sgn
2023-10-02 3:53 ` [PR PATCH] [Updated] " sgn
` (6 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2023-10-02 3:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 237 bytes --]
New review comment by sgn on void-packages repository
https://github.com/void-linux/void-packages/pull/46368#discussion_r1342262324
Comment:
```suggestion
checksum=7989c2fff67ff356e99c9a4b8d90a7759c7bde73844afb0595ee1322f4a19ced
```
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
` (2 preceding siblings ...)
2023-10-02 3:53 ` [PR REVIEW] " sgn
@ 2023-10-02 3:53 ` sgn
2023-10-02 4:08 ` cinerea0
` (5 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: sgn @ 2023-10-02 3:53 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 379 bytes --]
There is an updated pull request by sgn against master on the void-packages repository
https://github.com/cinerea0/void-packages gnucash
https://github.com/void-linux/void-packages/pull/46368
gnucash: update to 5.4
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/46368.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-46368.patch --]
[-- Type: text/x-diff, Size: 3188 bytes --]
From 0a65e80fd536c6156f3a0483c4a38e466e7d9734 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Sun, 1 Oct 2023 22:09:28 -0400
Subject: [PATCH 1/3] gnucash: update to 5.4
---
srcpkgs/gnucash/template | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 1a5d08e02469f..7118efeef8107 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=5.3
-revision=2
+version=5.4
+revision=1
build_style=cmake
make_check_target=check
configure_args="-DWITH_PYTHON=1 -DCOMPILE_GSCHEMAS=OFF"
@@ -17,7 +17,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
changelog="https://raw.githubusercontent.com/Gnucash/gnucash/stable/NEWS"
distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}.tar.gz"
-checksum=e0d04e0fd5f03f39136e1f4d941ccd0202b64a6e92418f5382cb6a6772493529
+checksum=9d3eb3cd63730cf34d4c14dea6921bfe57f3936e0ca6e17ffc04c38dc1b40061
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
From 272e2dea052e03126cd918abc1179b101fe5d4d7 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<sgn.danh@gmail.com>
Date: Mon, 2 Oct 2023 10:49:44 +0700
Subject: [PATCH 2/3] Update srcpkgs/gnucash/template
---
srcpkgs/gnucash/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 7118efeef8107..91a786520c4ce 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -16,7 +16,7 @@ maintainer="ManfredU <mu@usselmann.it>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
changelog="https://raw.githubusercontent.com/Gnucash/gnucash/stable/NEWS"
-distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}.tar.gz"
+distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}-1.tar.gz"
checksum=9d3eb3cd63730cf34d4c14dea6921bfe57f3936e0ca6e17ffc04c38dc1b40061
pycompile_dirs="usr/share/gnucash/python"
From 5cfdfe80d081fe546838da6191fe207fb238e488 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=C4=90o=C3=A0n=20Tr=E1=BA=A7n=20C=C3=B4ng=20Danh?=
<sgn.danh@gmail.com>
Date: Mon, 2 Oct 2023 10:53:38 +0700
Subject: [PATCH 3/3] Update srcpkgs/gnucash/template
---
srcpkgs/gnucash/template | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 91a786520c4ce..36094351239f5 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -17,7 +17,7 @@ license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
changelog="https://raw.githubusercontent.com/Gnucash/gnucash/stable/NEWS"
distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}-1.tar.gz"
-checksum=9d3eb3cd63730cf34d4c14dea6921bfe57f3936e0ca6e17ffc04c38dc1b40061
+checksum=7989c2fff67ff356e99c9a4b8d90a7759c7bde73844afb0595ee1322f4a19ced
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
` (3 preceding siblings ...)
2023-10-02 3:53 ` [PR PATCH] [Updated] " sgn
@ 2023-10-02 4:08 ` cinerea0
2023-10-10 16:32 ` [PR PATCH] [Updated] " cinerea0
` (4 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cinerea0 @ 2023-10-02 4:08 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/46368#issuecomment-1742373698
Comment:
@sgn Please stop. I am aware of what went wrong. The distfile link and hash changed out from under me in between when I first built version 5.4 and now. I am testing to make sure that nothing else changed.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
` (4 preceding siblings ...)
2023-10-02 4:08 ` cinerea0
@ 2023-10-10 16:32 ` cinerea0
2023-10-14 23:40 ` Piraty
` (3 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: cinerea0 @ 2023-10-10 16:32 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages gnucash
https://github.com/void-linux/void-packages/pull/46368
gnucash: update to 5.4
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/46368.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-46368.patch --]
[-- Type: text/x-diff, Size: 1303 bytes --]
From ce13fa1aa47731cad4620cb3e3ccbcbd29db6808 Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Tue, 10 Oct 2023 12:31:56 -0400
Subject: [PATCH] gnucash: update to 5.4
---
srcpkgs/gnucash/template | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 672ce13e73fcb..2cf453e5612b4 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=5.3
-revision=3
+version=5.4
+revision=1
build_style=cmake
make_check_target=check
configure_args="-DWITH_PYTHON=1 -DCOMPILE_GSCHEMAS=OFF"
@@ -16,8 +16,8 @@ maintainer="ManfredU <mu@usselmann.it>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
changelog="https://raw.githubusercontent.com/Gnucash/gnucash/stable/NEWS"
-distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}.tar.gz"
-checksum=e0d04e0fd5f03f39136e1f4d941ccd0202b64a6e92418f5382cb6a6772493529
+distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}-1.tar.gz"
+checksum=7989c2fff67ff356e99c9a4b8d90a7759c7bde73844afb0595ee1322f4a19ced
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
` (5 preceding siblings ...)
2023-10-10 16:32 ` [PR PATCH] [Updated] " cinerea0
@ 2023-10-14 23:40 ` Piraty
2023-10-28 3:43 ` cinerea0
` (2 subsequent siblings)
9 siblings, 0 replies; 11+ messages in thread
From: Piraty @ 2023-10-14 23:40 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 190 bytes --]
New comment by Piraty on void-packages repository
https://github.com/void-linux/void-packages/pull/46368#issuecomment-1763209122
Comment:
reporting the failed test on 32bit seems worth it
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
` (6 preceding siblings ...)
2023-10-14 23:40 ` Piraty
@ 2023-10-28 3:43 ` cinerea0
2023-10-28 14:38 ` [PR PATCH] [Updated] " cinerea0
2023-10-28 22:27 ` [PR PATCH] [Merged]: " Piraty
9 siblings, 0 replies; 11+ messages in thread
From: cinerea0 @ 2023-10-28 3:43 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 205 bytes --]
New comment by cinerea0 on void-packages repository
https://github.com/void-linux/void-packages/pull/46368#issuecomment-1783685674
Comment:
Bug reported: https://bugs.gnucash.org/show_bug.cgi?id=799114.
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Updated] gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
` (7 preceding siblings ...)
2023-10-28 3:43 ` cinerea0
@ 2023-10-28 14:38 ` cinerea0
2023-10-28 22:27 ` [PR PATCH] [Merged]: " Piraty
9 siblings, 0 replies; 11+ messages in thread
From: cinerea0 @ 2023-10-28 14:38 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
There is an updated pull request by cinerea0 against master on the void-packages repository
https://github.com/cinerea0/void-packages gnucash
https://github.com/void-linux/void-packages/pull/46368
gnucash: update to 5.4
#### Testing the changes
- I tested the changes in this PR: **YES**
A patch file from https://github.com/void-linux/void-packages/pull/46368.patch is attached
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-gnucash-46368.patch --]
[-- Type: text/x-diff, Size: 3829 bytes --]
From 1a5d574df0baccd1b965fa242569d203d60b15dd Mon Sep 17 00:00:00 2001
From: cinerea0 <cinerea0@disroot.org>
Date: Sat, 28 Oct 2023 10:37:57 -0400
Subject: [PATCH] gnucash: update to 5.4
---
srcpkgs/gnucash/patches/fix-engine-test.patch | 49 +++++++++++++++++++
srcpkgs/gnucash/template | 8 +--
2 files changed, 53 insertions(+), 4 deletions(-)
create mode 100644 srcpkgs/gnucash/patches/fix-engine-test.patch
diff --git a/srcpkgs/gnucash/patches/fix-engine-test.patch b/srcpkgs/gnucash/patches/fix-engine-test.patch
new file mode 100644
index 0000000000000..5ff36fc5bfc01
--- /dev/null
+++ b/srcpkgs/gnucash/patches/fix-engine-test.patch
@@ -0,0 +1,49 @@
+# Fixes engine test failure on i686
+# Upstream: https://github.com/Gnucash/gnucash/commit/8046eb2c0883b884052b241ec6bf331132194cd1
+diff --git a/libgnucash/engine/gnc-pricedb.cpp b/libgnucash/engine/gnc-pricedb.cpp
+index 47ddac57e73..7d335ebe102 100644
+--- a/libgnucash/engine/gnc-pricedb.cpp
++++ b/libgnucash/engine/gnc-pricedb.cpp
+@@ -2179,9 +2179,9 @@ gnc_pricedb_lookup_day_t64(GNCPriceDB *db,
+ }
+
+ // return 0 if price's time matches exactly
+-static int price_same_time (GNCPrice *p, time64 time)
++static int price_same_time (GNCPrice *p, time64 *time)
+ {
+- return !(gnc_price_get_time64 (p) == time);
++ return !(gnc_price_get_time64 (p) == *time);
+ }
+
+ GNCPrice *
+@@ -2194,7 +2194,7 @@ gnc_pricedb_lookup_at_time64(GNCPriceDB *db,
+ if (!db || !c || !currency) return NULL;
+ ENTER ("db=%p commodity=%p currency=%p", db, c, currency);
+ auto price_list = pricedb_get_prices_internal (db, c, currency, TRUE);
+- auto p = g_list_find_custom (price_list, GUINT_TO_POINTER(t), (GCompareFunc) price_same_time);
++ auto p = g_list_find_custom (price_list, &t, (GCompareFunc) price_same_time);
+ if (p)
+ {
+ rv = GNC_PRICE (p->data);
+@@ -2325,9 +2325,9 @@ gnc_pricedb_lookup_nearest_in_time64(GNCPriceDB *db,
+ }
+
+ // return 0 if price's time is less or equal to time
+-static int price_time64_less_or_equal (GNCPrice *p, time64 time)
++static int price_time64_less_or_equal (GNCPrice *p, time64 *time)
+ {
+- return !(gnc_price_get_time64 (p) <= time);
++ return !(gnc_price_get_time64 (p) <= *time);
+ }
+
+ GNCPrice *
+@@ -2341,7 +2341,7 @@ gnc_pricedb_lookup_nearest_before_t64 (GNCPriceDB *db,
+ ENTER ("db=%p commodity=%p currency=%p", db, c, currency);
+ auto price_list = pricedb_get_prices_internal (db, c, currency, TRUE);
+ if (!price_list) return NULL;
+- auto p = g_list_find_custom (price_list, GUINT_TO_POINTER(t), (GCompareFunc)price_time64_less_or_equal);
++ auto p = g_list_find_custom (price_list, &t, (GCompareFunc)price_time64_less_or_equal);
+ if (p)
+ {
+ current_price = GNC_PRICE (p->data);
+
diff --git a/srcpkgs/gnucash/template b/srcpkgs/gnucash/template
index 672ce13e73fcb..2cf453e5612b4 100644
--- a/srcpkgs/gnucash/template
+++ b/srcpkgs/gnucash/template
@@ -1,7 +1,7 @@
# Template file for 'gnucash'
pkgname=gnucash
-version=5.3
-revision=3
+version=5.4
+revision=1
build_style=cmake
make_check_target=check
configure_args="-DWITH_PYTHON=1 -DCOMPILE_GSCHEMAS=OFF"
@@ -16,8 +16,8 @@ maintainer="ManfredU <mu@usselmann.it>"
license="GPL-2.0-or-later"
homepage="http://www.gnucash.org"
changelog="https://raw.githubusercontent.com/Gnucash/gnucash/stable/NEWS"
-distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}.tar.gz"
-checksum=e0d04e0fd5f03f39136e1f4d941ccd0202b64a6e92418f5382cb6a6772493529
+distfiles="https://github.com/Gnucash/gnucash/releases/download/${version}/gnucash-${version}-1.tar.gz"
+checksum=7989c2fff67ff356e99c9a4b8d90a7759c7bde73844afb0595ee1322f4a19ced
pycompile_dirs="usr/share/gnucash/python"
conf_files="/etc/gnucash/environment"
^ permalink raw reply [flat|nested] 11+ messages in thread* Re: [PR PATCH] [Merged]: gnucash: update to 5.4
2023-10-02 2:10 [PR PATCH] gnucash: update to 5.4 cinerea0
` (8 preceding siblings ...)
2023-10-28 14:38 ` [PR PATCH] [Updated] " cinerea0
@ 2023-10-28 22:27 ` Piraty
9 siblings, 0 replies; 11+ messages in thread
From: Piraty @ 2023-10-28 22:27 UTC (permalink / raw)
To: ml
[-- Attachment #1: Type: text/plain, Size: 226 bytes --]
There's a merged pull request on the void-packages repository
gnucash: update to 5.4
https://github.com/void-linux/void-packages/pull/46368
Description:
#### Testing the changes
- I tested the changes in this PR: **YES**
^ permalink raw reply [flat|nested] 11+ messages in thread