[PR PATCH] nerd-fonts: split symbols font

[PR PATCH] nerd-fonts: split symbols font

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 783 bytes --]

There is a new pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages nerd-fonts-symbols
https://github.com/void-linux/void-packages/pull/46319

nerd-fonts: split symbols font
cc maintainer @cinerea0, interested party @chrysos349

- "gets rid of the bloat", if the user desires to only have the symbol font
- doesn't break existing installs (`-ttf` depends on `-symbols-ttf` to preserve continuity best, doesn't enable the fontconfig conf by default, doesn't remove other patched nerd-fonts)
- doesn't create more maintainer burden by having 2 templates

#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/46319.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nerd-fonts-symbols-46319.patch --]
[-- Type: text/x-diff, Size: 2124 bytes --]

From 7cb8f3c2a52e5d848712ad341ff8a98e76bffa92 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 28 Sep 2023 17:37:33 -0400
Subject: [PATCH] nerd-fonts: split symbols font

---
 srcpkgs/nerd-fonts-symbols-ttf |  1 +
 srcpkgs/nerd-fonts/template    | 20 ++++++++++++++++----
 2 files changed, 17 insertions(+), 4 deletions(-)
 create mode 120000 srcpkgs/nerd-fonts-symbols-ttf

diff --git a/srcpkgs/nerd-fonts-symbols-ttf b/srcpkgs/nerd-fonts-symbols-ttf
new file mode 120000
index 0000000000000..e5a8856321374
--- /dev/null
+++ b/srcpkgs/nerd-fonts-symbols-ttf
@@ -0,0 +1 @@
+nerd-fonts
\ No newline at end of file
diff --git a/srcpkgs/nerd-fonts/template b/srcpkgs/nerd-fonts/template
index f4409116aa628..819c1a1114a03 100644
--- a/srcpkgs/nerd-fonts/template
+++ b/srcpkgs/nerd-fonts/template
@@ -1,7 +1,7 @@
 # Template file for 'nerd-fonts'
 pkgname=nerd-fonts
 version=3.0.2
-revision=1
+revision=2
 depends="nerd-fonts-ttf nerd-fonts-otf"
 short_desc="Iconic font aggregator, collection and patcher"
 maintainer="cinerea0 <cinerea0@protonmail.com>"
@@ -25,11 +25,23 @@ do_install() {
 		vinstall $sh 744 usr/lib/NerdFonts
 	done
 
+	vinstall 10-nerd-font-symbols.conf 644 usr/share/fontconfig/conf.avail
+
 	vlicense LICENSE
 }
 
+nerd-fonts-symbols-ttf_package() {
+	short_desc+=" - TTF symbols-only font"
+	font_dirs="/usr/share/fonts/NerdFonts/ttf"
+	depends="font-util"
+	pkg_install() {
+		vmove "usr/share/fonts/NerdFonts/ttf/Symbols*"
+		vmove usr/share/fontconfig/conf.avail/10-nerd-font-symbols.conf
+	}
+}
+
 nerd-fonts-otf_package() {
-	short_desc="Iconic font aggregator, collection and patcher - otf fonts"
+	short_desc+=" - OTF fonts"
 	font_dirs="/usr/share/fonts/NerdFonts/otf"
 	depends="font-util"
 	pkg_install() {
@@ -38,9 +50,9 @@ nerd-fonts-otf_package() {
 }
 
 nerd-fonts-ttf_package() {
-	short_desc="Iconic font aggregator, collection and patcher - ttf fonts"
+	short_desc+=" - TTF fonts"
 	font_dirs="/usr/share/fonts/NerdFonts/ttf"
-	depends="font-util"
+	depends="font-util nerd-fonts-symbols-ttf"
 	pkg_install() {
 		vmove usr/share/fonts/NerdFonts/ttf
 	}

Re: [PR REVIEW] nerd-fonts: split symbols font

[sgn]

[-- Attachment #1: Type: text/plain, Size: 452 bytes --]

New review comment by sgn on void-packages repository

https://github.com/void-linux/void-packages/pull/46319#discussion_r1341971108

Comment:
I would remove `Symbols` in `do_install` and 
```suggestion
	font_dirs="/usr/share/fonts/NerdFonts/symbols"
	depends="font-util"
	pkg_install() {
		vinstall patched-fonts/NerdFontsSymbolsOnly/SymbolsNerdFont-Regular.ttf
		vinstall patched-fonts/NerdFontsSymbolsOnly/SymbolsNerdFontMono-Regular.ttf
```

Re: [PR PATCH] [Updated] nerd-fonts: split symbols font

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 796 bytes --]

There is an updated pull request by classabbyamp against master on the void-packages repository

https://github.com/classabbyamp/void-packages nerd-fonts-symbols
https://github.com/void-linux/void-packages/pull/46319

nerd-fonts: split symbols font
cc maintainer @cinerea0, interested party @chrysos349

- "gets rid of the bloat", if the user desires to only have the symbol font
- doesn't break existing installs (`-ttf` depends on `-symbols-ttf` to preserve continuity best, doesn't enable the fontconfig conf by default, doesn't remove other patched nerd-fonts)
- doesn't create more maintainer burden by having 2 templates

#### Testing the changes
- I tested the changes in this PR: **YES**


A patch file from https://github.com/void-linux/void-packages/pull/46319.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-nerd-fonts-symbols-46319.patch --]
[-- Type: text/x-diff, Size: 2816 bytes --]

From 08de719e25645d00ecc3ae9c89c7fe6e07f93966 Mon Sep 17 00:00:00 2001
From: classabbyamp <void@placeviolette.net>
Date: Thu, 28 Sep 2023 17:37:33 -0400
Subject: [PATCH] nerd-fonts: split symbols font

---
 srcpkgs/nerd-fonts-symbols-ttf |  1 +
 srcpkgs/nerd-fonts/template    | 26 +++++++++++++++++++-------
 2 files changed, 20 insertions(+), 7 deletions(-)
 create mode 120000 srcpkgs/nerd-fonts-symbols-ttf

diff --git a/srcpkgs/nerd-fonts-symbols-ttf b/srcpkgs/nerd-fonts-symbols-ttf
new file mode 120000
index 0000000000000..e5a8856321374
--- /dev/null
+++ b/srcpkgs/nerd-fonts-symbols-ttf
@@ -0,0 +1 @@
+nerd-fonts
\ No newline at end of file
diff --git a/srcpkgs/nerd-fonts/template b/srcpkgs/nerd-fonts/template
index f4409116aa628..eebd5381e74c5 100644
--- a/srcpkgs/nerd-fonts/template
+++ b/srcpkgs/nerd-fonts/template
@@ -1,7 +1,7 @@
 # Template file for 'nerd-fonts'
 pkgname=nerd-fonts
 version=3.0.2
-revision=1
+revision=2
 depends="nerd-fonts-ttf nerd-fonts-otf"
 short_desc="Iconic font aggregator, collection and patcher"
 maintainer="cinerea0 <cinerea0@protonmail.com>"
@@ -17,19 +17,31 @@ do_install() {
 	vmkdir usr/lib/NerdFonts
 
 	# get all patched fonts
-	find patched-fonts -name '*.otf' -exec install -Dm644 '{}' ${DESTDIR}/usr/share/fonts/NerdFonts/otf \;
-	find patched-fonts -name '*.ttf' -exec install -Dm644 '{}' ${DESTDIR}/usr/share/fonts/NerdFonts/ttf \;
+	find patched-fonts -name '*.otf' -exec install -Dm644 '{}' "${DESTDIR}/usr/share/fonts/NerdFonts/otf" \;
+	find patched-fonts -name '*.ttf' -exec install -Dm644 '{}' "${DESTDIR}/usr/share/fonts/NerdFonts/ttf" \;
+	rm "${DESTDIR}"/usr/share/fonts/NerdFonts/ttf/SymbolsNerdFont*.ttf
 
 	# install patching scripts
 	for sh in bin/scripts/lib/i_*.sh; do
-		vinstall $sh 744 usr/lib/NerdFonts
+		vinstall "$sh" 744 usr/lib/NerdFonts
 	done
 
 	vlicense LICENSE
 }
 
+nerd-fonts-symbols-ttf_package() {
+	short_desc+=" - TTF symbols-only font"
+	font_dirs="/usr/share/fonts/NerdFonts/ttf/symbols"
+	depends="font-util"
+	pkg_install() {
+		vmkdir usr/share/fonts/NerdFonts/ttf/symbols
+		vcopy "patched-fonts/NerdFontsSymbolsOnly/*.ttf" usr/share/fonts/NerdFonts/ttf/symbols
+		vinstall 10-nerd-font-symbols.conf 644 usr/share/fontconfig/conf.avail
+	}
+}
+
 nerd-fonts-otf_package() {
-	short_desc="Iconic font aggregator, collection and patcher - otf fonts"
+	short_desc+=" - OTF fonts"
 	font_dirs="/usr/share/fonts/NerdFonts/otf"
 	depends="font-util"
 	pkg_install() {
@@ -38,9 +50,9 @@ nerd-fonts-otf_package() {
 }
 
 nerd-fonts-ttf_package() {
-	short_desc="Iconic font aggregator, collection and patcher - ttf fonts"
+	short_desc+=" - TTF fonts"
 	font_dirs="/usr/share/fonts/NerdFonts/ttf"
-	depends="font-util"
+	depends="font-util nerd-fonts-symbols-ttf"
 	pkg_install() {
 		vmove usr/share/fonts/NerdFonts/ttf
 	}

Re: [PR REVIEW] nerd-fonts: split symbols font

[chrysos349]

[-- Attachment #1: Type: text/plain, Size: 354 bytes --]

New review comment by chrysos349 on void-packages repository

https://github.com/void-linux/void-packages/pull/46319#discussion_r1342003495

Comment:
these are NOT patching scripts.  this is the list of all glyphs for the cheat-sheet. see [here](https://github.com/ryanoasis/nerd-fonts/tree/master/bin/scripts/lib). they're useless. please remove these.

Re: [PR REVIEW] nerd-fonts: split symbols font

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 215 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46319#discussion_r1342004420

Comment:
I'll leave that up to the maintainer.

also please chill out

Re: [PR REVIEW] nerd-fonts: split symbols font

[cinerea0]

[-- Attachment #1: Type: text/plain, Size: 270 bytes --]

New review comment by cinerea0 on void-packages repository

https://github.com/void-linux/void-packages/pull/46319#discussion_r1342229690

Comment:
I was planning on replacing this with the real patching script on the next release. It can be fixed now, if you'd prefer.

Re: [PR REVIEW] nerd-fonts: split symbols font

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 198 bytes --]

New review comment by classabbyamp on void-packages repository

https://github.com/void-linux/void-packages/pull/46319#discussion_r1342229971

Comment:
if you have plans I'll leave it as is for you

Re: [PR PATCH] [Merged]: nerd-fonts: split symbols font

[classabbyamp]

[-- Attachment #1: Type: text/plain, Size: 619 bytes --]

There's a merged pull request on the void-packages repository

nerd-fonts: split symbols font
https://github.com/void-linux/void-packages/pull/46319

Description:
cc maintainer @cinerea0, interested party @chrysos349

- "gets rid of the bloat", if the user desires to only have the symbol font
- doesn't break existing installs (`-ttf` depends on `-symbols-ttf` to preserve continuity best, doesn't enable the fontconfig conf by default, doesn't remove other patched nerd-fonts)
- doesn't create more maintainer burden by having 2 templates

#### Testing the changes
- I tested the changes in this PR: **YES**