[PR PATCH] Berry: add patch

[PR PATCH] Berry: add patch

[namgo]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

There is a new pull request by namgo against master on the void-packages repository

https://github.com/namgo/void-packages berry-zombie-process
https://github.com/void-linux/void-packages/pull/46416

Berry: add patch
#### Testing the changes
- I tested the changes in this PR: **briefly**

I tested berrywm on a VM and it ran, however I'm stuck at a blank screen without any errors or warnings from Xorg - I'm not sure if this is normal behaviour with something I haven't configured.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

There's no new version of berry, but they provide a patch which I've imported that seems to fix the issue as mentioned in https://github.com/void-linux/void-packages/issues/46039

A patch file from https://github.com/void-linux/void-packages/pull/46416.patch is attached

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: github-pr-berry-zombie-process-46416.patch --]
[-- Type: text/x-diff, Size: 1762 bytes --]

From 5ccebb926377eb7e3ecfcfc8e0de234d90a146c0 Mon Sep 17 00:00:00 2001
From: Namgo <nathan@nzm.ca>
Date: Tue, 3 Oct 2023 13:17:36 -0400
Subject: [PATCH] Berry: add patch

---
 srcpkgs/berry/patches/no-zombies.patch | 39 ++++++++++++++++++++++++++
 1 file changed, 39 insertions(+)
 create mode 100644 srcpkgs/berry/patches/no-zombies.patch

diff --git a/srcpkgs/berry/patches/no-zombies.patch b/srcpkgs/berry/patches/no-zombies.patch
new file mode 100644
index 0000000000000..c027021290431
--- /dev/null
+++ b/srcpkgs/berry/patches/no-zombies.patch
@@ -0,0 +1,39 @@
+From 3501ee006ee9bdddc817fd71750e431b4186a0c7 Mon Sep 17 00:00:00 2001
+From: Joseph Eib <xealblade@example.com>
+Date: Wed, 30 Nov 2022 17:10:43 -0500
+Subject: [PATCH] Avoid creation of zombie process by load_config
+
+Previously, a zombie process was created when the process forked in
+load_config terminates because the parent does not call wait or waitpid.
+It is unreasonable to wait for the child because a user may exec their
+autostart script into a long-running process. Instead, the parent now
+simply ignores SIGCHLD which allows the child to be reaped immediately
+upon termination.
+---
+ wm.c | 5 ++++-
+ 1 file changed, 4 insertions(+), 1 deletion(-)
+
+diff --git a/wm.c b/wm.c
+index f3a01b8..b863bea 100644
+--- a/wm.c
++++ b/wm.c
+@@ -4,6 +4,7 @@
+ #include "config.h"
+ 
+ #include <limits.h>
++#include <signal.h>
+ #include <stdbool.h>
+ #include <stdio.h>
+ #include <stdint.h>
+@@ -2536,8 +2537,10 @@ main(int argc, char *argv[])
+     LOGN("Successfully opened display");
+ 
+     setup();
+-    if (conf_found)
++    if (conf_found) {
++        signal(SIGCHLD, SIG_IGN);
+         load_config(conf_path);
++    }
+     run();
+     close_wm();
+     free(font_name);

Re: [PR PATCH] [Closed]: Berry: add patch to address zombie process issue

[abenson]

[-- Attachment #1: Type: text/plain, Size: 731 bytes --]

There's a closed pull request on the void-packages repository

Berry: add patch to address zombie process issue
https://github.com/void-linux/void-packages/pull/46416

Description:
#### Testing the changes
- I tested the changes in this PR: **briefly**

I tested berrywm on a VM and it ran, however I'm stuck at a blank screen without any errors or warnings from Xorg - I'm not sure if this is normal behaviour with something I haven't configured.

#### Local build testing
- I built this PR locally for my native architecture, (x86_64-glibc)

There's no new version of berry, but they provide a patch which I've imported that seems to fix the issue as mentioned in https://github.com/void-linux/void-packages/issues/46039